Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-27 Thread Martin Basti
On 23.10.2015 14:01, Milan Kubík wrote: On 10/20/2015 02:19 PM, Martin Basti wrote: NACK 1) I still see many hardcoded passwords in the code with change_principal(smime_user, "Secret123"): For now changed to module variable. 2) Also the 'alice' username can be extracted to module v

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-23 Thread Milan Kubík
On 10/20/2015 02:19 PM, Martin Basti wrote: NACK 1) I still see many hardcoded passwords in the code with change_principal(smime_user, "Secret123"): For now changed to module variable. 2) Also the 'alice' username can be extracted to module variable instead hardcoding The fixture sh

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-20 Thread Martin Basti
On 20.10.2015 10:00, Milan Kubík wrote: On 10/19/2015 01:38 PM, Martin Basti wrote: On 16.10.2015 15:43, Milan Kubík wrote: On 09/30/2015 02:47 PM, Martin Basti wrote: On 09/24/2015 02:49 PM, Milan Kubík wrote: Hi all, an update for CA ACL tests! I, with help from M. Ba

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-20 Thread Milan Kubík
On 10/19/2015 01:38 PM, Martin Basti wrote: On 16.10.2015 15:43, Milan Kubík wrote: On 09/30/2015 02:47 PM, Martin Basti wrote: On 09/24/2015 02:49 PM, Milan Kubík wrote: Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how to change

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-19 Thread Martin Basti
On 16.10.2015 15:43, Milan Kubík wrote: On 09/30/2015 02:47 PM, Martin Basti wrote: On 09/24/2015 02:49 PM, Milan Kubík wrote: Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how to change the identity during acceptance cest run, whi

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-10-16 Thread Milan Kubík
On 09/30/2015 02:47 PM, Martin Basti wrote: On 09/24/2015 02:49 PM, Milan Kubík wrote: Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how to change the identity during acceptance cest run, which allows to test CA ACLs (and perhaps ot

Re: [Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-09-30 Thread Martin Basti
On 09/24/2015 02:49 PM, Milan Kubík wrote: Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how to change the identity during acceptance cest run, which allows to test CA ACLs (and perhaps other areas with some form of access controll). This allowed

[Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

2015-09-24 Thread Milan Kubík
Hi all, an update for CA ACL tests! I, with help from M. Babinsky, managed to find a way how to change the identity during acceptance cest run, which allows to test CA ACLs (and perhaps other areas with some form of access controll). This allowed me to write a test for CA ACLs and certificate