Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-17 Thread Martin Kosek
On 07/17/2013 01:48 PM, Jan Cholasta wrote: > On 17.7.2013 13:13, Tomas Babej wrote: >> > + class AdviceLogger(object): >> >> > >> >> > Please don't use nested classes. If you want AdviceLogger to be >> >> > private-ish, you can rename it to _AdviceLogger. >> >> > >> >> > Also I think AdviceL

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-17 Thread Jan Cholasta
On 17.7.2013 13:13, Tomas Babej wrote: > + class AdviceLogger(object): > > Please don't use nested classes. If you want AdviceLogger to be > private-ish, you can rename it to _AdviceLogger. > > Also I think AdviceLogger is a little bit misleading name, I would > prefer AdviceOutput o

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-17 Thread Tomas Babej
On Tuesday 16 of July 2013 14:10:44 Jan Cholasta wrote: > On 21.6.2013 11:45, Tomas Babej wrote: > > Newly added features: > > > > - options propagated to plugins > > - made plugin content creation more comfortable, now 3 classes of > > output are > > available (debug, comment, command) > >

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-16 Thread Jan Cholasta
On 21.6.2013 11:45, Tomas Babej wrote: Newly added features: - options propagated to plugins - made plugin content creation more comfortable, now 3 classes of output are available (debug, comment, command) Now pretty much everything that comes into my mind is addressed, so please have a

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-15 Thread Alexander Bokovoy
On Mon, 15 Jul 2013, Martin Kosek wrote: On 07/11/2013 08:59 AM, Tomas Babej wrote: On Wednesday 26 of June 2013 10:12:48 Petr Spacek wrote: [snip] Appropriate error handling = Return 'Permission denied' if particular operation requires higher privileges. IMHO 'cryptic' erro

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-15 Thread Martin Kosek
On 07/11/2013 08:59 AM, Tomas Babej wrote: > On Wednesday 26 of June 2013 10:12:48 Petr Spacek wrote: > > > > [snip] > > > >> > >> Appropriate error handling = Return 'Permission denied' if particular > >> operation requires higher privileges. > >> > >> IMHO 'cryptic' error message is b

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-07-11 Thread Tomas Babej
On Wednesday 26 of June 2013 10:12:48 Petr Spacek wrote: [snip] > > Appropriate error handling = Return 'Permission denied' if particular > operation requires higher privileges. > > IMHO 'cryptic' error message is bad in any case, so the right way how to fix > 'cryptic' error messages is to f

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-26 Thread Petr Spacek
On 24.6.2013 14:55, Tomas Babej wrote: On 06/24/2013 09:35 AM, Petr Spacek wrote: What would happen if require_root = False, UID = 1234 but the plugin requires root access? (I.e. there is an error in the require_root value.) The calling of particular external command that requires root access

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-24 Thread Tomas Babej
On 06/24/2013 09:35 AM, Petr Spacek wrote: What would happen if require_root = False, UID = 1234 but the plugin requires root access? (I.e. there is an error in the require_root value.) The calling of particular external command that requires root access for its execution will fail. I don't

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-24 Thread Petr Spacek
On 21.6.2013 11:45, Tomas Babej wrote: On 06/21/2013 09:32 AM, Jan Cholasta wrote: On 21.6.2013 09:16, Tomas Babej wrote: I'm also thinking about propagating the --verbose, etc. options provided by default by AdminTool down to plugin level so that plugin authors can make use of them. What do yo

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-21 Thread Tomas Babej
On 06/21/2013 09:32 AM, Jan Cholasta wrote: On 21.6.2013 09:16, Tomas Babej wrote: I'm also thinking about propagating the --verbose, etc. options provided by default by AdminTool down to plugin level so that plugin authors can make use of them. What do you think? +1 Newly added features:

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-21 Thread Jan Cholasta
On 21.6.2013 09:16, Tomas Babej wrote: I'm also thinking about propagating the --verbose, etc. options provided by default by AdminTool down to plugin level so that plugin authors can make use of them. What do you think? +1 -- Jan Cholasta ___ Freei

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-21 Thread Tomas Babej
On 06/20/2013 12:52 PM, Jan Cholasta wrote: On 20.6.2013 12:28, Tomas Babej wrote: Providing new version: - no longer requires root access defaultly - headers are printed out as comments Tomas You still have reference(s) to previous names of the script in the patch: +""" +Base

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-20 Thread Rob Crittenden
Martin Kosek wrote: On 06/20/2013 09:29 AM, Petr Spacek wrote: On 19.6.2013 20:56, Alexander Bokovoy wrote: On Wed, 19 Jun 2013, Rob Crittenden wrote: Tomas Babej wrote: [big snip] Providing new version which should address mentioned issues: - advice plugins now inherit directly from Plug

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-20 Thread Jan Cholasta
On 20.6.2013 12:28, Tomas Babej wrote: Providing new version: - no longer requires root access defaultly - headers are printed out as comments Tomas You still have reference(s) to previous names of the script in the patch: +""" +Base class for advices, plugins for ipa-config-ad

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-20 Thread Tomas Babej
[snip] On 06/19/2013 08:58 PM, Alexander Bokovoy wrote: As the output is almost usable for cut&paste to run on client machines, may be prefix the description/instructions with #? [snip] +1 I think the reason why Tomas did it as root was that he can that autobind to the DS. But he could easi

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-20 Thread Martin Kosek
On 06/20/2013 09:29 AM, Petr Spacek wrote: > On 19.6.2013 20:56, Alexander Bokovoy wrote: >> On Wed, 19 Jun 2013, Rob Crittenden wrote: >>> Tomas Babej wrote: [big snip] Providing new version which should address mentioned issues: - advice plugins now inherit directly from Plu

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-20 Thread Petr Spacek
On 19.6.2013 20:56, Alexander Bokovoy wrote: On Wed, 19 Jun 2013, Rob Crittenden wrote: Tomas Babej wrote: [big snip] Providing new version which should address mentioned issues: - advice plugins now inherit directly from Plugin, initial approach via Method class was abandoned - new Namesp

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Alexander Bokovoy
On Wed, 19 Jun 2013, Tomas Babej wrote: [snip] Here's a little preview: [tbabej@vm-001 ~]$ sudo ipa-advise fedora-authconfig Authconfig instructions for configuring Fedora 18/19 client with IPA se

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Tomas Babej
[snip] Here's a little preview: [tbabej@vm-001 ~]$ sudo ipa-advise fedora-authconfig Authconfig instructions for configuring Fedora 18/19 client with IPA server without use of SSSD. --

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Alexander Bokovoy
On Wed, 19 Jun 2013, Tomas Babej wrote: [big snip] Providing new version which should address mentioned issues: - advice plugins now inherit directly from Plugin, initial approach via Method class was abandoned - new Namespace api.Advice collects all the advice plugins - tool renamed to

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Alexander Bokovoy
On Wed, 19 Jun 2013, Rob Crittenden wrote: Tomas Babej wrote: [big snip] Providing new version which should address mentioned issues: - advice plugins now inherit directly from Plugin, initial approach via Method class was abandoned - new Namespace api.Advice collects all the advice plugins

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Tomas Babej
On 06/19/2013 08:30 PM, Rob Crittenden wrote: Tomas Babej wrote: [big snip] Providing new version which should address mentioned issues: - advice plugins now inherit directly from Plugin, initial approach via Method class was abandoned - new Namespace api.Advice collects all the advice pl

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Rob Crittenden
Tomas Babej wrote: [big snip] Providing new version which should address mentioned issues: - advice plugins now inherit directly from Plugin, initial approach via Method class was abandoned - new Namespace api.Advice collects all the advice plugins - tool renamed to ipa-advise to expres

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Tomas Babej
[big snip] Providing new version which should address mentioned issues: - advice plugins now inherit directly from Plugin, initial approach via Method class was abandoned - new Namespace api.Advice collects all the advice plugins - tool renamed to ipa-advise to express a more general use

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Alexander Bokovoy
On Wed, 19 Jun 2013, Dmitri Pal wrote: On 06/19/2013 12:46 PM, Alexander Bokovoy wrote: (please trim conversations) On Wed, 19 Jun 2013, Tomas Babej wrote: So if I want an advise about Solaris 11 client configuration would it look like this? ipa-advise config --client --distro=solaris --vers

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Dmitri Pal
On 06/19/2013 12:46 PM, Alexander Bokovoy wrote: > (please trim conversations) > > On Wed, 19 Jun 2013, Tomas Babej wrote: > So if I want an advise about Solaris 11 client configuration would it > look like this? > > ipa-advise config --client --distro=solaris --version=11 > >>

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Dmitri Pal
On 06/19/2013 12:29 PM, Tomas Babej wrote: > On 06/19/2013 06:19 PM, Dmitri Pal wrote: >> On 06/19/2013 12:18 PM, Tomas Babej wrote: >>> On 06/19/2013 06:13 PM, Dmitri Pal wrote: On 06/19/2013 10:46 AM, Simo Sorce wrote: > - Original Message - >> On 06/19/2013 03:03 PM, Alexand

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Alexander Bokovoy
(please trim conversations) On Wed, 19 Jun 2013, Tomas Babej wrote: So if I want an advise about Solaris 11 client configuration would it look like this? ipa-advise config --client --distro=solaris --version=11 or ipa-advise client-config-solrais-11 The latter. Tomas My point is that if

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Tomas Babej
On 06/19/2013 06:19 PM, Dmitri Pal wrote: On 06/19/2013 12:18 PM, Tomas Babej wrote: On 06/19/2013 06:13 PM, Dmitri Pal wrote: On 06/19/2013 10:46 AM, Simo Sorce wrote: - Original Message - On 06/19/2013 03:03 PM, Alexander Bokovoy wrote: On Wed, 19 Jun 2013, Jan Cholasta wrote: On

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Dmitri Pal
On 06/19/2013 12:18 PM, Tomas Babej wrote: > On 06/19/2013 06:13 PM, Dmitri Pal wrote: >> On 06/19/2013 10:46 AM, Simo Sorce wrote: >>> - Original Message - On 06/19/2013 03:03 PM, Alexander Bokovoy wrote: > On Wed, 19 Jun 2013, Jan Cholasta wrote: >> On 19.6.2013 14:47, Dmitri

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Tomas Babej
On 06/19/2013 06:13 PM, Dmitri Pal wrote: On 06/19/2013 10:46 AM, Simo Sorce wrote: - Original Message - On 06/19/2013 03:03 PM, Alexander Bokovoy wrote: On Wed, 19 Jun 2013, Jan Cholasta wrote: On 19.6.2013 14:47, Dmitri Pal wrote: On 06/19/2013 08:02 AM, Tomas Babej wrote: Do you

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Dmitri Pal
On 06/19/2013 10:46 AM, Simo Sorce wrote: > - Original Message - >> On 06/19/2013 03:03 PM, Alexander Bokovoy wrote: >>> On Wed, 19 Jun 2013, Jan Cholasta wrote: On 19.6.2013 14:47, Dmitri Pal wrote: > On 06/19/2013 08:02 AM, Tomas Babej wrote: >> Do you have something particul

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Simo Sorce
- Original Message - > On 06/19/2013 03:03 PM, Alexander Bokovoy wrote: > > On Wed, 19 Jun 2013, Jan Cholasta wrote: > >> On 19.6.2013 14:47, Dmitri Pal wrote: > >>> On 06/19/2013 08:02 AM, Tomas Babej wrote: > Do you have something particular in mind? > > Tomas > >

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Jan Cholasta
On 19.6.2013 16:09, Tomas Babej wrote: On 06/19/2013 03:03 PM, Alexander Bokovoy wrote: On Wed, 19 Jun 2013, Jan Cholasta wrote: On 19.6.2013 14:47, Dmitri Pal wrote: On 06/19/2013 08:02 AM, Tomas Babej wrote: Do you have something particular in mind? Tomas _

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Martin Kosek
On 06/19/2013 03:03 PM, Alexander Bokovoy wrote: > On Wed, 19 Jun 2013, Jan Cholasta wrote: >> On 19.6.2013 14:47, Dmitri Pal wrote: >>> On 06/19/2013 08:02 AM, Tomas Babej wrote: Do you have something particular in mind? Tomas __

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Tomas Babej
On 06/19/2013 03:03 PM, Alexander Bokovoy wrote: On Wed, 19 Jun 2013, Jan Cholasta wrote: On 19.6.2013 14:47, Dmitri Pal wrote: On 06/19/2013 08:02 AM, Tomas Babej wrote: Do you have something particular in mind? Tomas ___ Freeipa-devel mailing lis

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Alexander Bokovoy
On Wed, 19 Jun 2013, Jan Cholasta wrote: On 19.6.2013 14:47, Dmitri Pal wrote: On 06/19/2013 08:02 AM, Tomas Babej wrote: Do you have something particular in mind? Tomas ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Jan Cholasta
On 19.6.2013 14:47, Dmitri Pal wrote: On 06/19/2013 08:02 AM, Tomas Babej wrote: Do you have something particular in mind? Tomas ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ipa-conf

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Dmitri Pal
On 06/19/2013 08:02 AM, Tomas Babej wrote: > On 06/19/2013 01:31 PM, Petr Spacek wrote: >> On 19.6.2013 09:48, Tomas Babej wrote: >>> Hi, >>> >>> Provides a pluggable framework for generating configuration >>> scriptlets and instructions for various machine setups. >>> >>> Creates a new ipa-client-

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Tomas Babej
On 06/19/2013 01:31 PM, Petr Spacek wrote: On 19.6.2013 09:48, Tomas Babej wrote: Hi, Provides a pluggable framework for generating configuration scriptlets and instructions for various machine setups. Creates a new ipa-client-advise command, available to root user on the IPA server. Also pro

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Petr Spacek
On 19.6.2013 09:48, Tomas Babej wrote: Hi, Provides a pluggable framework for generating configuration scriptlets and instructions for various machine setups. Creates a new ipa-client-advise command, available to root user on the IPA server. Also provides an example configuration plugin. http

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Jan Cholasta
Hi, On 19.6.2013 09:48, Tomas Babej wrote: Hi, Provides a pluggable framework for generating configuration scriptlets and instructions for various machine setups. Creates a new ipa-client-advise command, available to root user on the IPA server. Also provides an example configuration plugin.

Re: [Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Alexander Bokovoy
On Wed, 19 Jun 2013, Tomas Babej wrote: Hi, Provides a pluggable framework for generating configuration scriptlets and instructions for various machine setups. Creates a new ipa-client-advise command, available to root user on the IPA server. Also provides an example configuration plugin. htt

[Freeipa-devel] [PATCH 0072] Provide ipa-client-advise tool

2013-06-19 Thread Tomas Babej
Hi, Provides a pluggable framework for generating configuration scriptlets and instructions for various machine setups. Creates a new ipa-client-advise command, available to root user on the IPA server. Also provides an example configuration plugin. https://fedorahosted.org/freeipa/ticket/3670