Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-19 Thread Petr Vobornik
On 18.11.2014 18:27, Petr Vobornik wrote: On 18.11.2014 17:27, Nathaniel McCallum wrote: This patch still needs to land in 4.1.2, so is it okay as it is? I don't think the label is necessary but it doesn't hurt either, at least it's clear, so ACK. Pushed to: master: 3c900ba7a8d98a72ff4e040b6

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-18 Thread Petr Vobornik
On 18.11.2014 17:27, Nathaniel McCallum wrote: On Tue, 2014-11-18 at 07:45 -0500, Simo Sorce wrote: On Tue, 18 Nov 2014 12:27:28 +0100 Martin Kosek wrote: On 11/14/2014 08:29 PM, Simo Sorce wrote: On Fri, 14 Nov 2014 20:05:35 +0100 Petr Viktorin wrote: On 11/14/2014 08:03 PM, Petr Viktori

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-18 Thread Nathaniel McCallum
On Tue, 2014-11-18 at 07:45 -0500, Simo Sorce wrote: > On Tue, 18 Nov 2014 12:27:28 +0100 > Martin Kosek wrote: > > > On 11/14/2014 08:29 PM, Simo Sorce wrote: > > > On Fri, 14 Nov 2014 20:05:35 +0100 > > > Petr Viktorin wrote: > > > > > >> On 11/14/2014 08:03 PM, Petr Viktorin wrote: > > >>> O

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-18 Thread Simo Sorce
On Tue, 18 Nov 2014 12:27:28 +0100 Martin Kosek wrote: > On 11/14/2014 08:29 PM, Simo Sorce wrote: > > On Fri, 14 Nov 2014 20:05:35 +0100 > > Petr Viktorin wrote: > > > >> On 11/14/2014 08:03 PM, Petr Viktorin wrote: > >>> On 11/14/2014 07:26 PM, Simo Sorce wrote: > On Fri, 14 Nov 2014 14:

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-18 Thread Martin Kosek
On 11/14/2014 08:29 PM, Simo Sorce wrote: > On Fri, 14 Nov 2014 20:05:35 +0100 > Petr Viktorin wrote: > >> On 11/14/2014 08:03 PM, Petr Viktorin wrote: >>> On 11/14/2014 07:26 PM, Simo Sorce wrote: On Fri, 14 Nov 2014 14:08:24 +0100 Petr Viktorin wrote: > On 11/14/2014 01:18 P

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Simo Sorce
On Fri, 14 Nov 2014 20:05:35 +0100 Petr Viktorin wrote: > On 11/14/2014 08:03 PM, Petr Viktorin wrote: > > On 11/14/2014 07:26 PM, Simo Sorce wrote: > >> On Fri, 14 Nov 2014 14:08:24 +0100 > >> Petr Viktorin wrote: > >> > >>> On 11/14/2014 01:18 PM, Petr Vobornik wrote: > >>> [...] > > > >>>

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Petr Viktorin
On 11/14/2014 08:03 PM, Petr Viktorin wrote: On 11/14/2014 07:26 PM, Simo Sorce wrote: On Fri, 14 Nov 2014 14:08:24 +0100 Petr Viktorin wrote: On 11/14/2014 01:18 PM, Petr Vobornik wrote: [...] Nope, defaults are filled in by the client. (And also on the server if they're still missing; it'

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Petr Viktorin
On 11/14/2014 07:26 PM, Simo Sorce wrote: On Fri, 14 Nov 2014 14:08:24 +0100 Petr Viktorin wrote: On 11/14/2014 01:18 PM, Petr Vobornik wrote: [...] Nope, defaults are filled in by the client. (And also on the server if they're still missing; it's part of the common validation.) IMHO this

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Simo Sorce
On Fri, 14 Nov 2014 14:08:24 +0100 Petr Viktorin wrote: > On 11/14/2014 01:18 PM, Petr Vobornik wrote: > [...] > >> > >> Nope, defaults are filled in by the client. (And also on the > >> server if they're still missing; it's part of the common > >> validation.) > > > > IMHO this is quite unfortun

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Nathaniel McCallum
On Fri, 2014-11-14 at 17:20 +0100, Petr Viktorin wrote: > On 11/14/2014 02:25 PM, Petr Vobornik wrote: > > On 14.11.2014 14:08, Petr Viktorin wrote: > >> On 11/14/2014 01:18 PM, Petr Vobornik wrote: > >> [...] > > Nope, defaults are filled in by the client. (And also on the server if > >>

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Petr Viktorin
On 11/14/2014 02:25 PM, Petr Vobornik wrote: On 14.11.2014 14:08, Petr Viktorin wrote: On 11/14/2014 01:18 PM, Petr Vobornik wrote: [...] Nope, defaults are filled in by the client. (And also on the server if they're still missing; it's part of the common validation.) IMHO this is quite unfo

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Petr Vobornik
On 14.11.2014 14:08, Petr Viktorin wrote: On 11/14/2014 01:18 PM, Petr Vobornik wrote: [...] Nope, defaults are filled in by the client. (And also on the server if they're still missing; it's part of the common validation.) IMHO this is quite unfortunate behavior which may also fail horribly

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Petr Viktorin
On 11/14/2014 01:18 PM, Petr Vobornik wrote: [...] Nope, defaults are filled in by the client. (And also on the server if they're still missing; it's part of the common validation.) IMHO this is quite unfortunate behavior which may also fail horribly if there is a newer client and an older ser

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-14 Thread Petr Vobornik
On 13.11.2014 19:12, Petr Viktorin wrote: On 11/13/2014 06:02 PM, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 16:57 +0100, Petr Viktorin wrote: On 11/13/2014 04:40 PM, Petr Vobornik wrote: On 13.11.2014 16:19, Nathaniel McCallum wrote: Like you, I like #2 the best. Attached is an impleme

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-13 Thread Petr Viktorin
On 11/13/2014 06:02 PM, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 16:57 +0100, Petr Viktorin wrote: On 11/13/2014 04:40 PM, Petr Vobornik wrote: On 13.11.2014 16:19, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 16:13 +0100, Petr Vobornik wrote: On 13.11.2014 16:00, Nathaniel McCallum

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-13 Thread Nathaniel McCallum
On Thu, 2014-11-13 at 16:57 +0100, Petr Viktorin wrote: > On 11/13/2014 04:40 PM, Petr Vobornik wrote: > > On 13.11.2014 16:19, Nathaniel McCallum wrote: > >> On Thu, 2014-11-13 at 16:13 +0100, Petr Vobornik wrote: > >>> On 13.11.2014 16:00, Nathaniel McCallum wrote: > On Thu, 2014-11-13 at 13

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-13 Thread Petr Viktorin
On 11/13/2014 04:40 PM, Petr Vobornik wrote: On 13.11.2014 16:19, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 16:13 +0100, Petr Vobornik wrote: On 13.11.2014 16:00, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 13:17 +0100, Martin Kosek wrote: On 11/13/2014 07:53 AM, Nathaniel McCallum

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-13 Thread Petr Vobornik
On 13.11.2014 16:19, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 16:13 +0100, Petr Vobornik wrote: On 13.11.2014 16:00, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 13:17 +0100, Martin Kosek wrote: On 11/13/2014 07:53 AM, Nathaniel McCallum wrote: On Thu, 2014-11-06 at 15:33 -0500, Nat

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-13 Thread Nathaniel McCallum
On Thu, 2014-11-13 at 16:13 +0100, Petr Vobornik wrote: > On 13.11.2014 16:00, Nathaniel McCallum wrote: > > On Thu, 2014-11-13 at 13:17 +0100, Martin Kosek wrote: > >> On 11/13/2014 07:53 AM, Nathaniel McCallum wrote: > >>> On Thu, 2014-11-06 at 15:33 -0500, Nathaniel McCallum wrote: > This i

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-13 Thread Petr Vobornik
On 13.11.2014 16:00, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 13:17 +0100, Martin Kosek wrote: On 11/13/2014 07:53 AM, Nathaniel McCallum wrote: On Thu, 2014-11-06 at 15:33 -0500, Nathaniel McCallum wrote: This is possible because python-qrcode's output now fits in a standard terminal.

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-13 Thread Nathaniel McCallum
On Thu, 2014-11-13 at 13:17 +0100, Martin Kosek wrote: > On 11/13/2014 07:53 AM, Nathaniel McCallum wrote: > > On Thu, 2014-11-06 at 15:33 -0500, Nathaniel McCallum wrote: > >> This is possible because python-qrcode's output now fits in a standard > >> terminal. Also, update ipa-otp-import and otpt

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-13 Thread Martin Kosek
On 11/13/2014 07:53 AM, Nathaniel McCallum wrote: > On Thu, 2014-11-06 at 15:33 -0500, Nathaniel McCallum wrote: >> This is possible because python-qrcode's output now fits in a standard >> terminal. Also, update ipa-otp-import and otptoken-add-yubikey to >> disable QR code output as it doesn't mak

Re: [Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-12 Thread Nathaniel McCallum
On Thu, 2014-11-06 at 15:33 -0500, Nathaniel McCallum wrote: > This is possible because python-qrcode's output now fits in a standard > terminal. Also, update ipa-otp-import and otptoken-add-yubikey to > disable QR code output as it doesn't make sense in these contexts. > > https://fedorahosted.or

[Freeipa-devel] [PATCH 0078] Enable QR code display by default in otptoken-add

2014-11-06 Thread Nathaniel McCallum
This is possible because python-qrcode's output now fits in a standard terminal. Also, update ipa-otp-import and otptoken-add-yubikey to disable QR code output as it doesn't make sense in these contexts. https://fedorahosted.org/freeipa/ticket/4703 From 86d9c7f6ec82db1c4b29e97c0529970e888d7bb8 Mon