Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2016-03-01 Thread Martin Basti
On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends on Martin's patch N 0421 All patches pass pylint.

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2016-03-01 Thread Martin Basti
On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends on Martin's patch N 0421 All patches pass pylint. hello, I cannot apply patches on master branc

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2016-02-29 Thread Oleg Fayans
Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends on Martin's patch N 0421 All patches pass pylint. On 12/19/2015 11:56 PM, Martin Basti wrote: > > > On 17.12.2015 10:04, Oleg Fayans wrot

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2015-12-19 Thread Martin Basti
On 17.12.2015 10:04, Oleg Fayans wrote: Hi Martin, I am sorry, in my previous email I attached the old version of patch 0016. The correct on is attached. On 12/16/2015 05:47 PM, Martin Basti wrote: On 16.12.2015 15:39, Martin Basti wrote: On 15.12.2015 10:29, Oleg Fayans wrote: Hi Martin

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2015-12-17 Thread Oleg Fayans
Hi Martin, I am sorry, in my previous email I attached the old version of patch 0016. The correct on is attached. On 12/16/2015 05:47 PM, Martin Basti wrote: > > > On 16.12.2015 15:39, Martin Basti wrote: >> >> >> On 15.12.2015 10:29, Oleg Fayans wrote: >>> Hi Martin, >>> >>> The updated patche

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2015-12-16 Thread Martin Basti
On 16.12.2015 15:39, Martin Basti wrote: On 15.12.2015 10:29, Oleg Fayans wrote: Hi Martin, The updated patches are attached. Patch 0017 includes all changes from patch 0018, so, if you approve this one, there would be no need to continue with the review of 0018. This one contains all chang

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2015-12-16 Thread Martin Basti
On 15.12.2015 10:29, Oleg Fayans wrote: Hi Martin, The updated patches are attached. Patch 0017 includes all changes from patch 0018, so, if you approve this one, there would be no need to continue with the review of 0018. This one contains all changes related to you remarks from 0018 review.

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2015-12-15 Thread Martin Babinsky
On 12/15/2015 10:29 AM, Oleg Fayans wrote: Hi Martin, The updated patches are attached. Patch 0017 includes all changes from patch 0018, so, if you approve this one, there would be no need to continue with the review of 0018. This one contains all changes related to you remarks from 0018 review.

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2015-12-15 Thread Oleg Fayans
Hi Martin, The updated patches are attached. Patch 0017 includes all changes from patch 0018, so, if you approve this one, there would be no need to continue with the review of 0018. This one contains all changes related to you remarks from 0018 review. Please see my explanation on the stdout+stde

Re: [Freeipa-devel] [PATCH 016 - 017] First part of the replica promotion tests + testplan

2015-12-13 Thread Martin Basti
On 09.12.2015 12:10, Martin Basti wrote: On 09.12.2015 11:14, Oleg Fayans wrote: Hi Martin On 12/09/2015 10:30 AM, Martin Basti wrote: On 08.12.2015 23:48, Oleg Fayans wrote: Substituted a hardcoded suffix name with a constant DOMAIN_SUFFIX_NAME On 12/08/2015 02:33 PM, Oleg Fayans wrote