Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-26 Thread Martin Kosek
On Fri, 2012-04-20 at 10:14 +0200, Petr Viktorin wrote: > On 04/19/2012 08:35 PM, John Dennis wrote: > > On 04/19/2012 07:04 AM, Petr Viktorin wrote: > >> On 04/18/2012 09:32 PM, John Dennis wrote: > Now that there are warnings, is pedantic mode necessary? > >>> > >>> Great question, I also po

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-20 Thread Petr Viktorin
On 04/19/2012 08:35 PM, John Dennis wrote: On 04/19/2012 07:04 AM, Petr Viktorin wrote: On 04/18/2012 09:32 PM, John Dennis wrote: Now that there are warnings, is pedantic mode necessary? Great question, I also pondered that as well. My conclusion was there was value in separating aggressiven

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-19 Thread John Dennis
On 04/19/2012 07:04 AM, Petr Viktorin wrote: On 04/18/2012 09:32 PM, John Dennis wrote: Now that there are warnings, is pedantic mode necessary? Great question, I also pondered that as well. My conclusion was there was value in separating aggressiveness of error checking from the verbosity of

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-19 Thread Petr Viktorin
On 04/18/2012 09:32 PM, John Dennis wrote: On 04/18/2012 07:33 AM, Petr Viktorin wrote: On 04/16/2012 10:32 PM, John Dennis wrote: On 04/12/2012 09:26 AM, Petr Viktorin wrote: On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-18 Thread John Dennis
On 04/18/2012 07:33 AM, Petr Viktorin wrote: On 04/16/2012 10:32 PM, John Dennis wrote: On 04/12/2012 09:26 AM, Petr Viktorin wrote: On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely vali

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-18 Thread Petr Viktorin
On 04/16/2012 10:32 PM, John Dennis wrote: On 04/12/2012 09:26 AM, Petr Viktorin wrote: On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely validate those strings. A recent checkin to instal

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-16 Thread John Dennis
On 04/12/2012 09:26 AM, Petr Viktorin wrote: On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely validate those strings. A recent checkin to install/po/test_i18n.py makes it possible to valid

Re: [Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-04-12 Thread Petr Viktorin
On 03/30/2012 03:45 AM, John Dennis wrote: Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely validate those strings. A recent checkin to install/po/test_i18n.py makes it possible to validate the contents of our current pot file by se

[Freeipa-devel] [PATCH 70] validate i18n strings when running "make lint"

2012-03-29 Thread John Dennis
Translatable strings have certain requirements for proper translation and run time behaviour. We should routinely validate those strings. A recent checkin to install/po/test_i18n.py makes it possible to validate the contents of our current pot file by searching for problematic strings. However, w