URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
jcholast commented:
"""
1. I'm afraid `certrequest` (actually `certreq`) is already taken. What about
`csrgen`?
2. I would be perfectly happy with `ipaclient.`.
3. OK.
Logistical stuff:
- I'm fine with
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
LiptonB commented:
"""
`csrgen` sounds good to me. The new modules have now been moved to
`ipaclient.plugins.csrgen`, `ipaclient.csrgen`, and
`ipatests.test_ipaclient.test_csrgen`.
FYI: I force pushed a
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
LiptonB commented:
"""
@jcholast, when you get a chance, could you take another look at this and let
me know what else is needed?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/10#i
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
jcholast commented:
"""
@LiptonB, I have added some inline comments.
Also, have you seen [my latest reply in the design
thread](https://www.redhat.com/archives/freeipa-devel/2016-September/msg00082.html)
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
LiptonB commented:
"""
Thanks, I've updated the code based on your comments (force pushed to fix
conflicts with master). And thanks for pointing out that email! I don't know
how I missed it, but I will r
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
LiptonB commented:
"""
Updated to fix conflicts with master again. I'm not sure what's up with Travis,
it seems to be checking out PR #109 instead of this one for the pep8 check:
```
$ cd freeipa/freeipa
