[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-30 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ @martbab The wheel bundle and packages need some documentation. I have started some docs but they are not finished.. """ See the full comment at https://github.com/freeipa/fre

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-30 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/ed9645b2ac58fd4664810f05970ea258c7948420 """ See the full comment at https://github.com/freeipa/freeipa/pull

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-30 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements martbab commented: """ Installing python-wheel worked, thanks. I have discovered some other missing dependencies in minimal Docker container. I will investigate them some more and open a ticket. I

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-30 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ The bdist_wheel command requires the Python wheel package installed in the system. Since setup.py no longer contains ```setup_requires=["wheel"]```, the dependency is no longer

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-30 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements martbab commented: """ Thank you. It seems that 'bdist_wheel' target is broken in your PR: ``` # make bdist_wheel mkdir -p ./dist/wheels for dir in ipaclient ipalib ipaplatform ipapython; do \

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-30 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ I opened PR #289 and #290. """ See the full comment at https://github.com/freeipa/freeipa/pull/255#issuecomment-263840863 -- Manage your subscription for the Freeipa-devel mai

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-30 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements martbab commented: """ As I said, if 0.9 break your PyPI work feel freee to bump it but please split the version bumps into a separate commit on top of ipasetup fixes. """ See the full comment at

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ @martbab Welcome to the party! This discussion has been running for a very long time and in multiple places. Let me bring you up to speed. First of all the requirements in ```i

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements martbab commented: """ Well from our (as upstream) POV 0.9 and later is required for Custodia to work correctly. This requirement was introduced by me in commit aa749957360b85fecaed2f9f8dc286f560b8

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ Would you rather claim to be compatible with a broken, unsupported, and old version? """ See the full comment at https://github.com/freeipa/freeipa/pull/255#issuecomment-26357

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ So create a separate commits: - fixes ipasetup.py - bumps python-gssapi for pypi, with proper explanation in commit message and maybe comment in code may be helpful. And we

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ You said Fedora, I didn't. The build bug is not related to Fedora at all. Cryptography 0.9 does not build on any distribution or platform with a recent version of OpenSSL. Tou

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ You said Fedora, I didn't. The build bug is not related to Fedora at all. Cryptography 0.9 does not build on any distribution or platform with a recent version of OpenSSL. """

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ > PS: There is no technical reason to bump the version of python-gssapi in > freeipa.spec. The enum34 dependency issues is solely a Python packaging bug. > It does not affe

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ PS: There is no technical reason to bump the version of python-gssapi in freeipa.spec. The enum34 dependency issues is solely a Python packaging bug. It does not affect RPM pac

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ > @mbasti-rh The bumped version numbers are required. gssapi needs to be bumped > because 1.1.x has wrong dependency information for Python 3 (enum34). So, this is broken f

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ @mbasti-rh The bumped version numbers are required. gssapi needs to be bumped because 1.1.x has wrong dependency information for Python 3 (enum34). cryptography 0.9 does not bu

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements tiran commented: """ @mbasti-rh The bumped version numbers are required. gssapi needs to be bumped because 1.1.x has wrong dependency information for Python 3 (enum34). cryptography 0.9 does not bu

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-29 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ @tiran You can split patch to useful part and please send unneeded bumping of requires as separate pull request, we can continue with discussion there about bumping version

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements pvoborni commented: """ The commit message doesn't explain why python-gssapi version is raised. Is it required by something? It also doesn't explain if the minimal required version of python-crypt

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-28 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ Better now, but commit message missing explanation why bumping requires was needed. """ See the full comment at https://github.com/freeipa/freeipa/pull/255#issuecomment-26

[Freeipa-devel] [freeipa PR#255][comment] Adjustments for setup requirements

2016-11-21 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/255 Title: #255: Adjustments for setup requirements mbasti-rh commented: """ I found some changes in versions of dependencies I don't like, because there is no explanation why it is needed and it is out of sync between specfile and setup.py """ Se