URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
MartinBasti commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/66fa0585aa3a7219aa3f5b548a0a84f052d62b8e
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
LGTM
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/336#issuecomment-276612233
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
MartinBasti commented:
"""
bump for review
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/336#issuecomment-276607135
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tomaskrizek commented:
"""
@HonzaCholasta Perhaps it's more of a personal preference, but I'd rather see
an existing version of a certain package. Since the spec file is processed
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
I see, didn't notice that. In this case, IMO either the current `pki-base >=
10.2.1` or an unversioned `pki-base-python2` is fine.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
You would still depend on potentially non-existing package.
```pki-base-python2``` was introduced in 10.3. ```pki-base``` will switch to
Python 3 as soon as
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
@tiran, I'm sorry to have to point this out, but the decision whether this PR
is accepted or not is not yours to make, you are not a member of the core
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tomaskrizek commented:
"""
I agree with @tiran here. Even though `>= 10.2.1` will match the correct
package, I don't think it's a good practice to use non-existent package numbers
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
I can't see a valid argument in your response. As a co-maintainer of PKI's
Python packages I'm strictly against claiming compatibility with a non-existing
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
That is of no concern to us. `pki-base-python3 >= 10.2.1` will get us the
correct package in all cases and under no circumstances will it cause an
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
```pki-base-python3 >= 10.2.1``` would mean that FreeIPA is compatible with
```pki-base-python2 == 10.2.1``` which clearly does not exist.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
@tiran, the dependency says `>= 10.2.1`, not `== 10.2.1`, so we are not
depending on any non-existent packages.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
What's the hold up here?
Martin and I discussed the necessity to raise the version requirements. Python
3 packages for PKI simply do not exist until 10.3. I
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
jcholast commented:
"""
@mbasti-rh, please don't bump BuildRequires unless it is actually necessary for
the build to not fail. Raising the version does not guarantee that the
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
jcholast commented:
"""
@mbasti-rh, please don't bump BuildRequires unless it is actually necessary for
the build to not fail. Raising the version does not guarantee that the
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
mbasti-rh commented:
"""
Ah my previous patch was right then. BuildRequires version is lower because
build works with lower version. I can raise that version just to be sure that
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
What I meant with different minimal version, FreeIPA requires pki-ca and kra
10.3.5 and newer.
```
Requires: pki-ca >= 10.3.5-6
Requires: pki-kra >= 10.3.5-6
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
mbasti-rh commented:
"""
It has Py3 Build dependency
Fixed.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/336#issuecomment-267355819
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
BuildRequires has no python3 dependency and a different minimal version.
```
BuildRequires: pki-base >= 10.2.1
```
"""
See the full comment at
19 matches
Mail list logo
