URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
MartinBasti commented:
"""
master:
* 5d489ac5604ca959cfe439c0594b8739073f3cea pylint_plugins: add forbidden import
checker
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
HonzaCholasta commented:
"""
I have now incorporated the suggestions.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/463#issuecomment-285646604
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
HonzaCholasta commented:
"""
@martbab, I haven't incorporated @MartinBasti's suggestions in yet.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
martbab commented:
"""
@MartinBasti any progress in reviewing this PR?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/463#issuecomment-285605217
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
HonzaCholasta commented:
"""
The format could be nicer though - suggestions are welcome.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/463#issuecomment-279689307
--
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
MartinBasti commented:
"""
Awesome then
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/463#issuecomment-279689037
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
HonzaCholasta commented:
"""
You can, using:
```
ipaclient/install/
```
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/463#issuecomment-279688754
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
MartinBasti commented:
"""
In this case:
```
ipaclient/:ipaclient.install:ipalib.install:ipaplatform:ipaserver,
ipaclient/install/:ipaserver,
```
`ipaclient/install` allows all
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
HonzaCholasta commented:
"""
I don't know what you mean, could you give me an example?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/463#issuecomment-279678738
--
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
MartinBasti commented:
"""
Ok, this will not work if ipaclient/submodule allows to import any module, but
seems OK for me now, can be improved when needed
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
HonzaCholasta commented:
"""
@MartinBasti, this issue is already solved in the PR without using regular
expressions. See `pylintrc` for example.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/463
Title: #463: pylint_plugins: add forbidden import checker
MartinBasti commented:
"""
> Can you turn module matching into a regular expression? We need bit more
> advanced checks, e.g. ipalib should not import from ipaplatform except for
>
12 matches
Mail list logo
