URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
master:
* fd1b4f6ec9a349196d5df510008c4745f0b1fb84 Add options to run only ipaclient
unittests
ipa-4-5:
* 29b885a8fac82e963f5ab98d178e81854056930e Add options to
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
I have one small question and am going to try out some integration tests to see
if we did not break something in them as Travis won't catch that.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
tiran commented:
"""
@martbab I've cleanup up some white space noise and squashed all commits.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
I like the second approach better. If you squash the commits I will Ack the PR.
I still think we need a substantial reorganization of the test suites but that
needs
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
tiran commented:
"""
I pushed an alternative approach that checks for the option and raises skip in
packages. It needs some extra workaround in the integration plugin.
"""
See the full
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
Oh my, every time I think about something nice that should work there is some
corner case that ruins it.
I guess that one way to work around it would be to keep the
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
tiran commented:
"""
I'm not a big fan either. Can you come up with a better solution that does not
result in import errors? Because the module marker or class markers still
import the
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
I am not a big fan of mixing filename matching and markers in this PR. I feel
that using only one of those approaches is a more cleaner solution and it seems
that
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
tiran commented:
"""
My first PoC used the approach. ipa-run-tests can already takes arguments to
limit tests to subdirectories. One has to remember that ipa-run-tests performs
chdir()...
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
I was thinking that instead of making up more options to test runner we could
reorganize the `ipatests/` directory to actually make sense from the consumer's
POV,
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
tiran commented:
"""
PS: I'm not attached to the new of the option. Please speak up if you can come
up with a better name than ```--ipaclient-unittests```.
"""
See the full comment at
11 matches
Mail list logo
