URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
MartinBasti commented:
"""
master:
* 4ba6b968399204aac66d82d917a8cc159e77ad4d Refactor the code checking for
missing SIDs
* c5bae577597fbababdd25ab3ae6463c490d90a40 only check for
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
MartinBasti commented:
"""
Please rebase
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/479#issuecomment-283332782
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
martbab commented:
"""
I have added a commit that fixes the choeck for missing dependencies in
composite installers.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
martbab commented:
"""
OK I will then hard-code `add_sids=True` in ipa-server-install
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/479#issuecomment-282784419
--
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
abbra commented:
"""
Unless you specified --add-sids to ipa-adtrust-install (or `add_sids=True` in
ADTrustInstance.setup() call), no task would be run. 'Activating sidgen task'
only adds
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
martbab commented:
"""
@abbra I think that I am confused by the way sidgen plugin works. During LDAP
configuration I can see that sidgen/extdom plugins are activated. e.g:
```
...
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
abbra commented:
"""
If you can differentiate how the installer is being run, then for composite
installer always run add_sids.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
martbab commented:
"""
I have noticed that the check for installed dependencies is buggy, I will have
to fix it before pushing.
Also we would need to move the 'editors' group addition to
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
MartinBasti commented:
"""
Works for me, except, ipa-server-install --setup-adtrust works even without
freeipa-server-trust-ad package. Please fix this in a new PR in way how DNS is
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
martbab commented:
"""
I have added a basic integration tests for the built-in AD trust installation,
you can run them on 3 machines (master + 2 replicas) by running
```bash
#
URL: https://github.com/freeipa/freeipa/pull/479
Title: #479: Merge AD trust installer into composite ones
martbab commented:
"""
Bump for review.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/479#issuecomment-281635086
--
Manage your subscription for the Freeipa-devel
11 matches
Mail list logo
