URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
HonzaCholasta commented:
"""
I took the hard way and removed the URI argument from `ldap2.__init__()`.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/492#issuecomment-28
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
tiran commented:
"""
It's probably easier to always define options like ```'ldap_uri``` but use
```None``` as default.
```
cd .; ./makeaci --validate
./makeaci: ipaserver/plugins/dogtag.py:2
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
HonzaCholasta commented:
"""
Sure.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/492#issuecomment-281597461
--
Manage your subscription for the Freeipa-devel mailing l
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
tiran commented:
"""
Can you add a comment to explain the order of checks and assignments? Without
explanation, it's going to confuse the next poor developer.
"""
See the full comment at
ht
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
HonzaCholasta commented:
"""
I stand corrected, but it does not make sense to reorder the code as you
suggested anyway, as it would change the current default of `server` when only
`xmlrpc_u
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
tiran commented:
"""
It does matter. In the current version ```if 'server' not in self:``` is
checked and ```self.server``` is checked a couple of lines after ```if
'ldap_uri' not in self an
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
HonzaCholasta commented:
"""
@tiran, not really, the order does not matter here.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/492#issuecomment-281373944
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults
tiran commented:
"""
https://github.com/HonzaCholasta/freeipa/blob/4ebf4b907213c9951eb9cbd276e0460552563fb1/ipalib/config.py#L579
initializes server from jsonrpc_uri. Does it make sense move
