jcholast commented on a pull request
"""
Functional ACK, but please don't use newlines in exception messages. If you
want the original error on a separate line, you can use the logger to log it,
but I think it would be preferable to use this format:
```
Peer's certificate issuer is not trusted
flo-renaud commented on a pull request
"""
Bump for review
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/50#issuecomment-246921696
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: h
jcholast commented on a pull request
"""
More comments inline.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/50#issuecomment-244967015
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIP
jcholast commented on a pull request
"""
NACK, see my inline comments above.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/50#issuecomment-244858726
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contri
