[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution MartinBasti commented: """ master: * 594c87daf873ceec0c0cf3464bcb1aadb9f2b92a Short name resolution: introduce the required schema *

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution martbab commented: """ Ok thanks for explanation. """ See the full comment at https://github.com/freeipa/freeipa/pull/573#issuecomment-286464608 -- Manage your

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution abbra commented: """ Yes, it is expected too. Remember that 'Default Trust View' is a view that applies globally. You have already global setting to apply. """ See the

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution martbab commented: """ PR rebased, I have fixed bugs in ID view objectclass handling and re-used the trusted domain retrieval code in certmap plugin. This is a separate

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution HonzaCholasta commented: """ Ah, right. """ See the full comment at https://github.com/freeipa/freeipa/pull/573#issuecomment-286395012 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution MartinBasti commented: """ @HonzaCholasta it will break in case when idview entry is created on older replica, so it is more safe to appending the objectclass dynamically

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution HonzaCholasta commented: """ IMO you should add the object class to all existing idviews on upgrade rather than add it on-demand. """ See the full comment at

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-14 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution martbab commented: """ @HonzaCholasta I agree, I have removed the commit which introduces special param handling and resorted to simple splitting in validator. I have also

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-13 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution abbra commented: """ I don't see ACI.txt regenerated. """ See the full comment at https://github.com/freeipa/freeipa/pull/573#issuecomment-286097962 -- Manage your

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-13 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution martbab commented: """ Updated PR, added ACIs and fixed Py2/Py3 compatibility of doctests. """ See the full comment at

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-13 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution HonzaCholasta commented: """ I would rather avoid the refactoring in 4.5 - this is fragile code you are touching and I'm afraid it might break in some cases (think

[Freeipa-devel] [freeipa PR#573][comment] Provide centralized management of user short name resolution

2017-03-13 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/573 Title: #573: Provide centralized management of user short name resolution MartinBasti commented: """ ACIs? AFAIK SSSD should be able to read this """ See the full comment at https://github.com/freeipa/freeipa/pull/573#issuecomment-286094363 --