[Freeipa-devel] [freeipa PR#73][comment] Tests for certificates with SAN

2016-10-04 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4f8e212c428b1fff63f38ea15d7ce9f230085c5c

[Freeipa-devel] [freeipa PR#73][comment] Tests for certificates with SAN

2016-09-29 Thread apophys
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN apophys commented: """ I have fixed typos and implemented the proposed test cases. I have also provided docstring to the change_principal context manager. """ See the full comment at

[Freeipa-devel] [freeipa PR#73][comment] Tests for certificates with SAN

2016-09-29 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/73 Title: #73: Tests for certificates with SAN martbab commented: """ NACK: you probably forgot to add service fixtures as params to the added test cases: https://paste.fedoraproject.org/437721/51355181/ In addition please write sensible commit