Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-06-07 Thread Rob Crittenden
Jakub Hrozek wrote: On 06/06/2011 12:28 PM, Jan Cholasta wrote: On 2.6.2011 08:23, Jakub Hrozek wrote: On 06/02/2011 08:18 AM, Jakub Hrozek wrote: On 05/23/2011 08:00 AM, Jan Cholasta wrote: On 22.5.2011 18:28, Jakub Hrozek wrote: On 05/20/2011 08:27 PM, Jan Cholasta wrote: TODO: Clean unre

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-06-07 Thread Jakub Hrozek
On 06/06/2011 12:28 PM, Jan Cholasta wrote: > On 2.6.2011 08:23, Jakub Hrozek wrote: >> On 06/02/2011 08:18 AM, Jakub Hrozek wrote: >>> On 05/23/2011 08:00 AM, Jan Cholasta wrote: On 22.5.2011 18:28, Jakub Hrozek wrote: > On 05/20/2011 08:27 PM, Jan Cholasta wrote: >> TODO: Clean unrea

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-06-06 Thread Jan Cholasta
On 2.6.2011 08:23, Jakub Hrozek wrote: On 06/02/2011 08:18 AM, Jakub Hrozek wrote: On 05/23/2011 08:00 AM, Jan Cholasta wrote: On 22.5.2011 18:28, Jakub Hrozek wrote: On 05/20/2011 08:27 PM, Jan Cholasta wrote: TODO: Clean unreachable code paths off of ipa-server-install (?) In general I ag

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-06-01 Thread Jakub Hrozek
On 06/02/2011 08:18 AM, Jakub Hrozek wrote: On 05/23/2011 08:00 AM, Jan Cholasta wrote: On 22.5.2011 18:28, Jakub Hrozek wrote: On 05/20/2011 08:27 PM, Jan Cholasta wrote: TODO: Clean unreachable code paths off of ipa-server-install (?) In general I agree even though I don't know exactly wha

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-30 Thread Martin Kosek
On Fri, 2011-05-27 at 22:09 +0200, Jan Cholasta wrote: > On 27.5.2011 18:59, Martin Kosek wrote: > > On Fri, 2011-05-27 at 16:47 +0200, Jan Cholasta wrote: > >> On 24.5.2011 15:38, Jan Cholasta wrote: > >>> On 20.5.2011 20:27, Jan Cholasta wrote: > On 10.5.2011 20:06, Jan Cholasta wrote: > >>>

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-27 Thread Jan Cholasta
On 27.5.2011 18:59, Martin Kosek wrote: On Fri, 2011-05-27 at 16:47 +0200, Jan Cholasta wrote: On 24.5.2011 15:38, Jan Cholasta wrote: On 20.5.2011 20:27, Jan Cholasta wrote: On 10.5.2011 20:06, Jan Cholasta wrote: Parse netmasks in IP addresses passed to server install. ticket 1212 Patch

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-27 Thread Martin Kosek
On Fri, 2011-05-27 at 16:47 +0200, Jan Cholasta wrote: > On 24.5.2011 15:38, Jan Cholasta wrote: > > On 20.5.2011 20:27, Jan Cholasta wrote: > >> On 10.5.2011 20:06, Jan Cholasta wrote: > >>> Parse netmasks in IP addresses passed to server install. > >>> > >>> ticket 1212 > >> > >> Patch updated. >

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-27 Thread Jan Cholasta
On 24.5.2011 15:38, Jan Cholasta wrote: On 20.5.2011 20:27, Jan Cholasta wrote: On 10.5.2011 20:06, Jan Cholasta wrote: Parse netmasks in IP addresses passed to server install. ticket 1212 Patch updated. TODO: Write unit test for ipapython.ipautil.CheckedIPAddress TODO: Clean unreachable co

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-24 Thread Jan Cholasta
On 20.5.2011 20:27, Jan Cholasta wrote: On 10.5.2011 20:06, Jan Cholasta wrote: Parse netmasks in IP addresses passed to server install. ticket 1212 Patch updated. TODO: Write unit test for ipapython.ipautil.CheckedIPAddress TODO: Clean unreachable code paths off of ipa-server-install (?) TO

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-22 Thread Jan Cholasta
On 22.5.2011 18:28, Jakub Hrozek wrote: On 05/20/2011 08:27 PM, Jan Cholasta wrote: TODO: Clean unreachable code paths off of ipa-server-install (?) In general I agree even though I don't know exactly what code you have in mind -- if the code is dead there's no reason to keep it. I've notice

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-22 Thread Jakub Hrozek
On 05/20/2011 08:27 PM, Jan Cholasta wrote: TODO: Clean unreachable code paths off of ipa-server-install (?) In general I agree even though I don't know exactly what code you have in mind -- if the code is dead there's no reason to keep it. TODO: Workarounds for netaddr bugs (?) Are these

Re: [Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

2011-05-20 Thread Jan Cholasta
On 10.5.2011 20:06, Jan Cholasta wrote: Parse netmasks in IP addresses passed to server install. ticket 1212 Patch updated. TODO: Write unit test for ipapython.ipautil.CheckedIPAddress TODO: Clean unreachable code paths off of ipa-server-install (?) TODO: Workarounds for netaddr bugs (?) --