Re: [Freeipa-devel] [PATCH] 0031 ipa-restore: Check if directory is provided + better errors.

2014-11-21 Thread David Kupka
On 11/21/2014 02:12 PM, Tomas Babej wrote: On 11/21/2014 01:56 PM, David Kupka wrote: On 11/21/2014 01:42 PM, Tomas Babej wrote: On 11/21/2014 01:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4683 ___ Freeipa-devel mailing

[Freeipa-devel] [PATCH] 0032 Fix error message for nonexistent members and add tests.

2014-11-21 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4643 -- David Kupka From 3403f21a15d1e1dcb05187708ff16a2750052f7a Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Tue, 21 Oct 2014 18:12:23 -0400 Subject: [PATCH] Fix error message for nonexistent members and add tests. https

Re: [Freeipa-devel] [PATCH] 0032 Fix error message for nonexistent members and add tests.

2014-11-24 Thread David Kupka
On 11/21/2014 04:23 PM, Tomas Babej wrote: On 11/21/2014 04:11 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4643 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 0033 Use singular in help metavars + update man pages.

2014-11-24 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4695 IMO this is one of two reasonable ways how to fix this ticket. The other one is to change just the manual page but it seems more consistent to use singular for metavars everywhere. -- David Kupka From 54f396b9b8316173b1c295c15feb0bb38025b64a Mon Sep

Re: [Freeipa-devel] [PATCH] 0033 Use singular in help metavars + update man pages.

2014-11-25 Thread David Kupka
On 11/24/2014 03:59 PM, Martin Basti wrote: On 24/11/14 15:54, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4695 IMO this is one of two reasonable ways how to fix this ticket. The other one is to change just the manual page but it seems more consistent to use singular

Re: [Freeipa-devel] [PATCH] 0033 Use singular in help metavars + update man pages.

2014-11-25 Thread David Kupka
On 11/25/2014 09:51 AM, David Kupka wrote: On 11/24/2014 03:59 PM, Martin Basti wrote: On 24/11/14 15:54, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4695 IMO this is one of two reasonable ways how to fix this ticket. The other one is to change just the manual page but it seems

Re: [Freeipa-devel] [PATCH] 0033 Use singular in help metavars + update man pages.

2014-11-25 Thread David Kupka
On 11/25/2014 09:57 AM, David Kupka wrote: On 11/25/2014 09:51 AM, David Kupka wrote: On 11/24/2014 03:59 PM, Martin Basti wrote: On 24/11/14 15:54, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4695 IMO this is one of two reasonable ways how to fix this ticket. The other one

Re: [Freeipa-devel] [PATCH] 0033 Use singular in help metavars + update man pages.

2014-11-25 Thread David Kupka
On 11/25/2014 03:23 PM, Martin Basti wrote: On 25/11/14 13:16, David Kupka wrote: On 11/25/2014 09:57 AM, David Kupka wrote: On 11/25/2014 09:51 AM, David Kupka wrote: On 11/24/2014 03:59 PM, Martin Basti wrote: On 24/11/14 15:54, David Kupka wrote: https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCH] 0033 Use singular in help metavars + update man pages.

2014-11-26 Thread David Kupka
On 11/26/2014 12:23 PM, Martin Basti wrote: On 25/11/14 15:44, David Kupka wrote: On 11/25/2014 03:23 PM, Martin Basti wrote: On 25/11/14 13:16, David Kupka wrote: On 11/25/2014 09:57 AM, David Kupka wrote: On 11/25/2014 09:51 AM, David Kupka wrote: On 11/24/2014 03:59 PM, Martin Basti

Re: [Freeipa-devel] [PATCH 0038] Update default NTP Configuration

2014-12-01 Thread David Kupka
for patch. I guess that you wanted to add the iburst option only once. Right now it will generate lines like: server server-fqdn iburst iburst Attaching the fixed patch. Are you satisfied with it? -- David Kupka From f571e379b3e7498e5f32092d633bd6219b1b9c5c Mon Sep 17 00:00:00 2001 From: Gabe

Re: [Freeipa-devel] [PATCH 0162] Upgrade fix: masking named service should be executed only once

2014-12-05 Thread David Kupka
-devel Works as expected but: 0) mask_named_regular() returns True, False and None. None evaluates as False so why not use False directly? 1) missing link to ticket in commit message. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] [PATCH 0162] Upgrade fix: masking named service should be executed only once

2014-12-09 Thread David Kupka
On 12/05/2014 12:58 PM, Martin Basti wrote: On 05/12/14 10:23, David Kupka wrote: On 11/12/2014 01:43 PM, Martin Basti wrote: Hello, masking named service is executed more than once, following patch fixes it. Patch attached. ___ Freeipa-devel

Re: [Freeipa-devel] [PATCH] 382 Fix automatic CA cert renewal endless loop in dogtag-ipa-ca-renew-agent

2014-12-09 Thread David Kupka
for me, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 383 Check subject name encoding in ipa-cacert-manage renew

2014-12-09 Thread David Kupka
for me, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 384 Do not renew the IPA CA cert by serial number in dogtag-ipa-ca-renew-agent

2014-12-09 Thread David Kupka
for me, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 0034 Always add /etc/hosts record when DNS is being configured.

2014-12-17 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4817 -- David Kupka From df963852d39ee476b9795da10edaef62f9869799 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Tue, 16 Dec 2014 20:35:05 -0500 Subject: [PATCH] Always add /etc/hosts record when DNS is being configured. This was done

Re: [Freeipa-devel] [PATCHES 297-299] Improvements for idviews xmlrpc tests

2015-01-22 Thread David Kupka
mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Hi, thanks for patches. Works for me, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa

Re: [Freeipa-devel] [PATCH] 0003-2 User life cycle: new stageuser plugin with add verb

2015-02-04 Thread David Kupka
break anything as far as I tested. We should push them now to avoid further rebases. Thierry can then prepare other patches delivering the rest of ULC functionality. -- David Kupka From 0aa8d71acfb6ae63c5cb9a8ab02ad67c7d15a430 Mon Sep 17 00:00:00 2001 From: Thierry bordaz (tbordaz) tbor

Re: [Freeipa-devel] [PATCH] 0035 client: Update DNS with all available local IP addresses.

2015-01-15 Thread David Kupka
On 01/15/2015 03:22 PM, David Kupka wrote: On 01/15/2015 12:43 PM, David Kupka wrote: On 01/12/2015 06:34 PM, Martin Basti wrote: On 09/01/15 14:43, David Kupka wrote: On 01/07/2015 04:15 PM, Martin Basti wrote: On 07/01/15 12:27, David Kupka wrote: https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

2015-01-20 Thread David Kupka
On 01/20/2015 12:07 PM, Martin Kosek wrote: On 01/20/2015 10:49 AM, Jan Cholasta wrote: Dne 13.1.2015 v 18:55 Jan Cholasta napsal(a): Dne 13.1.2015 v 18:46 David Kupka napsal(a): On 01/13/2015 05:55 PM, Jan Cholasta wrote: Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a): Hi, the attached

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

2015-01-20 Thread David Kupka
On 01/20/2015 10:49 AM, Jan Cholasta wrote: Dne 13.1.2015 v 18:55 Jan Cholasta napsal(a): Dne 13.1.2015 v 18:46 David Kupka napsal(a): On 01/13/2015 05:55 PM, Jan Cholasta wrote: Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a): Hi, the attached patch fixes https://fedorahosted.org/freeipa

Re: [Freeipa-devel] [PATCH] 488-489 PermissionsV2 related winsync fixes

2015-01-19 Thread David Kupka
are resolved we can push. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0035 client: Update DNS with all available local IP addresses.

2015-01-15 Thread David Kupka
On 01/12/2015 06:34 PM, Martin Basti wrote: On 09/01/15 14:43, David Kupka wrote: On 01/07/2015 04:15 PM, Martin Basti wrote: On 07/01/15 12:27, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4249 Thank you for patch: 1) -root_logger.error(Cannot update DNS records

Re: [Freeipa-devel] [PATCH] 0035 client: Update DNS with all available local IP addresses.

2015-01-15 Thread David Kupka
On 01/15/2015 12:43 PM, David Kupka wrote: On 01/12/2015 06:34 PM, Martin Basti wrote: On 09/01/15 14:43, David Kupka wrote: On 01/07/2015 04:15 PM, Martin Basti wrote: On 07/01/15 12:27, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4249 Thank you for patch: 1

Re: [Freeipa-devel] [PATCHES 0191-0194] Fix restoring states of services after uninstalling

2015-02-18 Thread David Kupka
On 02/17/2015 02:49 PM, Martin Basti wrote: On 17/02/15 12:18, David Kupka wrote: On 02/11/2015 05:13 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4869 Fixes: - enable/start a service after uninstallation if the service was enabled/running before in correct way - store

Re: [Freeipa-devel] [PATCH 0177] Fix add version warning only on server side

2015-02-12 Thread David Kupka
understand that this modification should prevent it. AFAIK it doesn't break anything, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0012] migrate-ds: exit with error message if no users/groups to migrate are found

2015-02-13 Thread David Kupka
parameters (yes, there is not only one :-) should be removed please do it in separate patch. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCHES 0191-0194] Fix restoring states of services after uninstalling

2015-02-17 Thread David Kupka
Hi, thanks for patches. The code looks good to me but I found 2 issues: 1. httpd is left in non-working state after installing and uninstalling ipa-server. Tried on clean Fedora 21, the httpd was not configured before ipa-server installation. 2. Patch 191 needs (trivial) rebase. -- David Kupka

Re: [Freeipa-devel] [PATCHES 301-302] ID override sshpubkey handling

2015-01-27 Thread David Kupka
___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Hi, thanks for the patches but right now we need just a small fix for ipa-4-1 (attached). Your patches will latter go into ipa-4-2. -- David Kupka From

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-12 Thread David Kupka
On 01/12/2015 01:41 PM, Jan Cholasta wrote: Dne 12.1.2015 v 13:37 David Kupka napsal(a): On 01/12/2015 01:14 PM, Jan Cholasta wrote: Dne 12.1.2015 v 13:08 Martin Kosek napsal(a): On 01/12/2015 12:53 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4823 Looking at this patch

[Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-12 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4823 -- David Kupka From f04a311b98c6db0bd19486e21dbe07addf2c0f87 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Sun, 11 Jan 2015 18:45:11 -0500 Subject: [PATCH] Abort full backup restoration on not matching host. Full backup cannot

Re: [Freeipa-devel] [PATCH 0179] Fix traceback if zonemgr error message contains unicode characters

2015-01-12 Thread David Kupka
On 01/12/2015 01:25 PM, Martin Basti wrote: On 09/01/15 14:07, David Kupka wrote: On 12/12/2014 02:26 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4805 Patch attached. Does not work properly. $ locale LANG=cs_CZ.iso88592 LC_CTYPE=cs_CZ.iso88592 LC_NUMERIC=cs_CZ.iso88592

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-12 Thread David Kupka
On 01/12/2015 01:14 PM, Jan Cholasta wrote: Dne 12.1.2015 v 13:08 Martin Kosek napsal(a): On 01/12/2015 12:53 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4823 Looking at this patch, are data-only backups supposed to work properly then? Wouldn't for example Directory Server

[Freeipa-devel] [PATCH] 0035 client: Update DNS with all available local IP addresses.

2015-01-07 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4249 -- David Kupka From 3bd0b78b7b6f77d39478aa75d7f808a06fed562b Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Sun, 4 Jan 2015 15:04:18 -0500 Subject: [PATCH] client: Update DNS with all available local IP addresses. Detect all usable

Re: [Freeipa-devel] [PATCH] 386 Fix CA certificate renewal syslog alert

2015-01-13 Thread David Kupka
for the patch. Works for me, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

2015-01-13 Thread David Kupka
. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Hi! Thanks for the patch. Works for me, ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

Re: [Freeipa-devel] [PATCHES] 391-392 Make certificate renewal process synchronized

2015-01-13 Thread David Kupka
this fix ASAP I'll cope with it. ACK. -- David Kupka ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-13 Thread David Kupka
On 01/13/2015 02:57 PM, Jan Cholasta wrote: Dne 13.1.2015 v 14:44 David Kupka napsal(a): On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 12.1.2015 v 13:37 David Kupka napsal(a): On 01/12/2015 01:14 PM

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-13 Thread David Kupka
On 01/13/2015 03:07 PM, David Kupka wrote: On 01/13/2015 02:57 PM, Jan Cholasta wrote: Dne 13.1.2015 v 14:44 David Kupka napsal(a): On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 12.1.2015 v 13:37

[Freeipa-devel] [PATCH] 0037 Remove ipanttrustauthincoming/ipanttrustauthoutgoing from ipa trust-add output.

2015-01-13 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4787 -- David Kupka From 801c2e16b2fca523cf1116095cdec530417e9ff0 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Tue, 13 Jan 2015 13:23:16 +0100 Subject: [PATCH] Remove ipanttrustauthincoming/ipanttrustauthoutgoing from ipa trust-add

Re: [Freeipa-devel] [PATCH] 0037 Remove ipanttrustauthincoming/ipanttrustauthoutgoing from ipa trust-add output.

2015-01-13 Thread David Kupka
On 01/13/2015 01:39 PM, Petr Vobornik wrote: On 01/13/2015 01:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4787 Haven't try it, but: have you considered: result['result'].pop('ipanttrustauthincoming', None) ? I haven't and it looks better, thanks. Fixed patch

Re: [Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

2015-01-13 Thread David Kupka
On 01/12/2015 04:50 PM, Rob Crittenden wrote: Jan Cholasta wrote: Dne 12.1.2015 v 16:30 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 12.1.2015 v 13:37 David Kupka napsal(a): On 01/12/2015 01:14 PM, Jan Cholasta wrote: Dne 12.1.2015 v 13:08 Martin Kosek napsal(a): On 01/12/2015 12:53

Re: [Freeipa-devel] [PATCH] 0035 client: Update DNS with all available local IP addresses.

2015-01-09 Thread David Kupka
On 01/07/2015 04:15 PM, Martin Basti wrote: On 07/01/15 12:27, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4249 Thank you for patch: 1) -root_logger.error(Cannot update DNS records! - Failed to connect to server '%s'., server) +ips

Re: [Freeipa-devel] [PATCH 0179] Fix traceback if zonemgr error message contains unicode characters

2015-01-09 Thread David Kupka
to: ĹĽaĹžko.redhat.com The provided value isn't right and must be normalized but the one displayed in error message doesn't match. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel -- David Kupka

Re: [Freeipa-devel] [PATCH] 0035 client: Update DNS with all available local IP addresses.

2015-01-07 Thread David Kupka
On 01/07/2015 03:12 PM, Rob Crittenden wrote: David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4249 Rather than scraping the output of ip is the python-netifaces package a viable alternative? Yes it adds another dep, and I'm not sure it is available for all platforms, but it makes

[Freeipa-devel] [PATCH] 0041 Always reload StateFile before getting or modifying the, stored values.

2015-03-16 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4901 -- David Kupka From f7c47015b40141e0d1c5d93add4b7293a95cd830 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Mon, 16 Mar 2015 08:05:59 -0400 Subject: [PATCH] Always reload StateFile before getting or modifying the stored values

Re: [Freeipa-devel] [PATCH] 0003-3 User life cycle: new stageuser plugin with add verb

2015-03-16 Thread David Kupka
On 03/06/2015 07:30 PM, thierry bordaz wrote: On 02/19/2015 04:19 PM, Martin Basti wrote: On 19/02/15 13:01, thierry bordaz wrote: On 02/04/2015 05:14 PM, Jan Cholasta wrote: Hi, Dne 4.2.2015 v 15:25 David Kupka napsal(a): On 02/03/2015 11:50 AM, thierry bordaz wrote: On 09/17/2014 12:32

Re: [Freeipa-devel] [PATCH 0208] Remove --test option from upgrade

2015-03-19 Thread David Kupka
On 03/17/2015 01:07 PM, Martin Basti wrote: On 12/03/15 16:10, David Kupka wrote: On 03/06/2015 06:00 PM, Martin Basti wrote: Upgrade plugins which modify LDAP data directly should not be executed in --test mode. This patch is a workaround, to ensure update with --test option will not modify

Re: [Freeipa-devel] [PATCHES 0204-0207, 0211] Server upgrade: Make LDAP data upgrade deterministic

2015-03-19 Thread David Kupka
that switch default value for ordered to True attached. Looks and works as expected, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCHES 404-407] client-install: Do not crash on invalid CA certificate in LDAP

2015-03-19 Thread David Kupka
before pushing to master. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0199] Remove unused disable-betxn.ldif file

2015-03-09 Thread David Kupka
___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel IIUC ipa stopped using this file in commit f1f1b4e7f2e9c1838ad7ec76002b78ca0c2a3c46 but it was not removed. Works for me, ACK. -- David Kupka -- Manage your

Re: [Freeipa-devel] [PATCH 0208] Respect --test option in upgrade plugins

2015-03-12 Thread David Kupka
. Ideally we want to fix all plugins to dry-run the upgrade not just skip when there is '--test' option but it is a good first step. Works for me, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute

Re: [Freeipa-devel] [PATCHES 0204-0207] Server upgrade: Make LDAP data upgrade deterministic

2015-03-12 Thread David Kupka
Patches attached. Changes in code looks good and the upgrade process still works, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0203] Remove unused PRE_SCHEMA upgrade

2015-03-12 Thread David Kupka
On 03/06/2015 04:52 PM, Martin Basti wrote: This upgrade step is not used anymore. Required by: https://fedorahosted.org/freeipa/ticket/4904 Patch attached. Looks and works good to me, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https

Re: [Freeipa-devel] [PATCH 0212] Server Upgrade: Fix comments

2015-03-24 Thread David Kupka
. -- Martin Basti Updated patch attached Thanks for the patch, LGTM, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] New installer PoC

2015-03-24 Thread David Kupka
Hi! I haven't tested the patch yet but it looks good at first glance. I definitely like the generator-style (un)installation steps. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA

Re: [Freeipa-devel] [PATCH 0043-0045] Use mod_auth_gssapi instead of mod_auth_kerb.

2015-03-30 Thread David Kupka
On 03/30/2015 07:15 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:09 Petr Vobornik napsal(a): On 27.3.2015 15:26, David Kupka wrote: On 03/27/2015 03:14 PM, Rob Crittenden wrote: David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4190 To test this on F22 my patch 42 is needed. NACK

[Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-03-27 Thread David Kupka
pylint changed slightly so we must react otherwise we'll be unable to build freeipa rpms on Fedora 22. This patch should go to master for sure but I don't know if we want it in 4.1. -- David Kupka From a0ffcd6f8ba610c20808a2f863d384b7631c64ac Mon Sep 17 00:00:00 2001 From: David Kupka dku

Re: [Freeipa-devel] [PATCH 0043] Use mod_auth_gssapi instead of mod_auth_kerb.

2015-03-27 Thread David Kupka
On 03/27/2015 03:10 PM, Simo Sorce wrote: On Fri, 2015-03-27 at 15:04 +0100, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4190 To test this on F22 my patch 42 is needed. Please require mod_auth_gssapi = 1.1.0-2 Any lower version will fail to work. Otherwise patch looks good

[Freeipa-devel] [PATCH 0043] Use mod_auth_gssapi instead of mod_auth_kerb.

2015-03-27 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4190 To test this on F22 my patch 42 is needed. -- David Kupka From 135faa61e0252cc35cca75aa9814610db0883aa4 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Wed, 25 Mar 2015 05:22:03 -0400 Subject: [PATCH] Use mod_auth_gssapi instead

Re: [Freeipa-devel] [PATCH 0043] Use mod_auth_gssapi instead of mod_auth_kerb.

2015-03-27 Thread David Kupka
On 03/27/2015 03:14 PM, Rob Crittenden wrote: David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4190 To test this on F22 my patch 42 is needed. NACK. You need to bump the VERSION in ipa.conf for this file to be replaced on upgrades. Thanks for the catch, Rob. I've forget about

Re: [Freeipa-devel] [PATCH] 0039 Try continue ipa-client-automount even if nsslapd-minssf 0.

2015-02-27 Thread David Kupka
On 02/27/2015 02:26 PM, Martin Basti wrote: On 27/02/15 14:21, Martin Basti wrote: On 26/02/15 15:54, David Kupka wrote: On 02/26/2015 02:55 PM, Rob Crittenden wrote: Martin Basti wrote: On 26/02/15 10:57, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4902

Re: [Freeipa-devel] [PATCH] 0040 Add realm name to backup header file.

2015-03-04 Thread David Kupka
On 03/04/2015 02:11 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4896 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Honza proposed different approach. We can extract

[Freeipa-devel] [PATCH] 0040 Add realm name to backup header file.

2015-03-04 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4896 -- David Kupka From c295d33db32152118013d4e85493b012dd687347 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Wed, 4 Mar 2015 06:49:54 -0500 Subject: [PATCH] Add realm name to backup header file. When ipa server is restored after

Re: [Freeipa-devel] [PATCH] 0040 Add realm name to backup header file.

2015-03-05 Thread David Kupka
On 03/04/2015 06:52 PM, David Kupka wrote: On 03/04/2015 02:11 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4896 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Honza

Re: [Freeipa-devel] [PATCH] 0039 Try continue ipa-client-automount even if nsslapd-minssf 0.

2015-02-26 Thread David Kupka
On 02/26/2015 02:55 PM, Rob Crittenden wrote: Martin Basti wrote: On 26/02/15 10:57, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4902 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo

[Freeipa-devel] [PATCH] 0039 Try continue ipa-client-automount even if nsslapd-minssf 0.

2015-02-26 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4902 -- David Kupka From 06f268e0c6435f3ba421787cf57e49c2ef2ac00d Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Thu, 26 Feb 2015 04:44:26 -0500 Subject: [PATCH] Try continue ipa-client-automount even if nsslapd-minssf 0

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-24 Thread David Kupka
On 04/24/2015 03:17 PM, Martin Basti wrote: On 23/04/15 15:26, David Kupka wrote: On 04/13/2015 01:23 PM, David Kupka wrote: On 04/10/2015 02:55 PM, Simo Sorce wrote: On Fri, 2015-04-10 at 12:55 +0200, Lukas Slebodnik wrote: On (08/04/15 08:53), Simo Sorce wrote: On Wed, 2015-04-08 at 10:22

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-23 Thread David Kupka
On 04/13/2015 01:23 PM, David Kupka wrote: On 04/10/2015 02:55 PM, Simo Sorce wrote: On Fri, 2015-04-10 at 12:55 +0200, Lukas Slebodnik wrote: On (08/04/15 08:53), Simo Sorce wrote: On Wed, 2015-04-08 at 10:22 +0200, David Kupka wrote: On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015

Re: [Freeipa-devel] [PATCHES 0227-0229] Server upgrade: introduce ipa-server-upgrade command

2015-04-20 Thread David Kupka
and 228. In patch 227 you add whole file ipa_server_upgrade.py and in patch 228 add forgotten import and change option description slightly. Otherwise it works for me. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa

Re: [Freeipa-devel] [PATCHES 0233-0234] DNSSEC: forwarders validation

2015-04-30 Thread David Kupka
'. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-27 Thread David Kupka
On 04/27/2015 12:18 PM, Martin Basti wrote: On 27/04/15 11:04, Martin Kosek wrote: On 04/27/2015 10:49 AM, Martin Basti wrote: On 27/04/15 10:31, David Kupka wrote: On 04/24/2015 03:58 PM, Tomas Babej wrote: On 04/24/2015 03:50 PM, Martin Basti wrote: On 24/04/15 15:22, David Kupka wrote

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-27 Thread David Kupka
On 04/24/2015 03:58 PM, Tomas Babej wrote: On 04/24/2015 03:50 PM, Martin Basti wrote: On 24/04/15 15:22, David Kupka wrote: On 04/24/2015 03:17 PM, Martin Basti wrote: On 23/04/15 15:26, David Kupka wrote: On 04/13/2015 01:23 PM, David Kupka wrote: On 04/10/2015 02:55 PM, Simo Sorce

Re: [Freeipa-devel] [PATCHES 0227-0229] Server upgrade: introduce ipa-server-upgrade command

2015-04-27 Thread David Kupka
the exception most of the time. I can raise error in that case and ignore the exception. Honza Martin^2 Updated patches attached. Updated patches attached -- Martin Basti Updated patch attached Looks good to me and works as expected. Honza, are you OK with the patches? -- David Kupka

Re: [Freeipa-devel] [PATCH 0230] Server upgrade: fix comment in ldapupdater

2015-04-27 Thread David Kupka
On 04/16/2015 05:14 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4904 Patch attached I guess the rest of the comment is also outdated. Can you update it, too? -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman

Re: [Freeipa-devel] [PATCH] 0005 User life cycle: del/mod/find/show stageuser commands

2015-04-28 Thread David Kupka
On 04/28/2015 10:28 AM, thierry bordaz wrote: On 04/28/2015 10:23 AM, David Kupka wrote: On 04/16/2015 01:00 PM, thierry bordaz wrote: Hello, Here is the next patch for User life cycle that introduces del/mod/find and show stageuser plugin commands. * -User Life Cycle (create

Re: [Freeipa-devel] [PATCH 0230] Server upgrade: fix comment in ldapupdater

2015-04-29 Thread David Kupka
On 04/28/2015 02:48 PM, Martin Basti wrote: On 27/04/15 18:42, David Kupka wrote: On 04/16/2015 05:14 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4904 Patch attached I guess the rest of the comment is also outdated. Can you update it, too? Updated patch attached

Re: [Freeipa-devel] behavior change in DNS dynamic updates: #155

2015-04-29 Thread David Kupka
, report the error here' logic. I do not see a way to change this without changes to BIND internals and IMHO it is not worth the effort. Thank you for your time! -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0005 User life cycle: del/mod/find/show stageuser commands

2015-04-28 Thread David Kupka
database -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0322-0337] Fix mysterious failures in PTR record synchronization

2015-05-06 Thread David Kupka
bind-dyndb-ldap. To test the patch set I used ipa-client-install with patch freeipa-dkupka-0035-6. DNS server does not return an error unless creation/update of record that I requested has failed. This is exactly the behavior I expect, thanks. -- David Kupka -- Manage your subscription

Re: [Freeipa-devel] [PATCHES 0233-0234] DNSSEC: forwarders validation

2015-05-07 Thread David Kupka
On 05/06/2015 03:20 PM, Martin Basti wrote: On 05/05/15 15:00, Martin Basti wrote: On 30/04/15 15:37, David Kupka wrote: On 04/24/2015 02:56 PM, Martin Basti wrote: Patches attached. Hi, thanks for patches. 1. You changed message in DNSServerNotRespondingWarning class but not the test

Re: [Freeipa-devel] [PATCH] 381 Fix stop_tracking_certificates call in ipa-restore

2015-05-07 Thread David Kupka
for patch (with 5 months delay :-) The patch needs a trivial rebase but otherwise works for me and is needed for ipa-restore to work. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http

Re: [Freeipa-devel] [PATCH] 381 Fix stop_tracking_certificates call in ipa-restore

2015-05-07 Thread David Kupka
On 05/07/2015 10:11 AM, Jan Cholasta wrote: Dne 7.5.2015 v 10:04 David Kupka napsal(a): On 12/03/2014 10:23 AM, Jan Cholasta wrote: Hi, the attached patch fixes https://fedorahosted.org/freeipa/ticket/4775. Honza ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCHES 0239-0243] Server Upgrade: minor fixes

2015-05-13 Thread David Kupka
On 05/12/2015 02:44 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4904 Patches attached. Works for me, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http

Re: [Freeipa-devel] [PATCH] 0048 Remove unused enable() method from DogtagInstance.

2015-05-14 Thread David Kupka
On 05/13/2015 12:07 PM, Martin Basti wrote: On 12/05/15 16:54, David Kupka wrote: On 05/12/2015 02:16 PM, Martin Basti wrote: On 12/05/15 13:53, David Kupka wrote: DogtagInstance.enable() overrides Service.enable() and does nothing usefulll. Also removing it solves bug discovered recently

Re: [Freeipa-devel] [PATCH] 832-850 Stage Users Web UI and its prerequisites

2015-05-15 Thread David Kupka
clicking button not switching 'mode' radio button and then clicking 'delete'. Otherwise everything seems to work well. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http

Re: [Freeipa-devel] [PATCH] 0005 User life cycle: del/mod/find/show stageuser commands

2015-05-15 Thread David Kupka
David - Original Message - From: thierry bordaz tbor...@redhat.com To: Jan Cholasta jchol...@redhat.com, David Kupka dku...@redhat.com Cc: freeipa-devel freeipa-devel@redhat.com Sent: Tuesday, May 12, 2015 5:05:29 PM Subject: Re: [Freeipa-devel] [PATCH] 0005 User life cycle: del/mod/find

Re: [Freeipa-devel] [TEST PLAN] User lifecycle plugin

2015-05-13 Thread David Kupka
to add/modify the attributes in staging are freely all the check must be applied when the user is activated. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page

[Freeipa-devel] [PATCH] 0048 Remove unused enable() method from DogtagInstance.

2015-05-12 Thread David Kupka
DogtagInstance.enable() overrides Service.enable() and does nothing usefulll. Also removing it solves bug discovered recently in uninstall procedure. -- David Kupka From dbf020b1703a9cf2f4d3614f4c9caa83f340f571 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Tue, 12 May 2015

Re: [Freeipa-devel] [PATCH] 0048 Remove unused enable() method from DogtagInstance.

2015-05-12 Thread David Kupka
On 05/12/2015 02:16 PM, Martin Basti wrote: On 12/05/15 13:53, David Kupka wrote: DogtagInstance.enable() overrides Service.enable() and does nothing usefulll. Also removing it solves bug discovered recently in uninstall procedure. NACK 1) this is used in step() call, which means the tomcatd

Re: [Freeipa-devel] design review: Certificate Profiles

2015-04-16 Thread David Kupka
change the command to 'ipa certprofile-add' to stay consistent with rest of FreeIPA commands. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread David Kupka
On 04/08/2015 10:23 AM, Jan Cholasta wrote: Dne 8.4.2015 v 10:22 David Kupka napsal(a): On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015 14

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread David Kupka
On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal(a): On 27.3.2015 14:58, David Kupka wrote: pylint changed slightly so we must react otherwise we'll be unable

Re: [Freeipa-devel] [PATCH 0042] Make lint work on Fedora 22.

2015-04-08 Thread David Kupka
On 04/08/2015 02:53 PM, Simo Sorce wrote: On Wed, 2015-04-08 at 10:22 +0200, David Kupka wrote: On 04/06/2015 02:48 PM, Simo Sorce wrote: On Mon, 2015-03-30 at 12:15 +0200, David Kupka wrote: On 03/30/2015 07:12 AM, Jan Cholasta wrote: Dne 28.3.2015 v 00:05 Petr Vobornik napsal

Re: [Freeipa-devel] [PATCHES 0033-0034] fix recent bugs introduced by letting httpd use file-based ccache

2015-05-19 Thread David Kupka
On 05/15/2015 04:41 PM, Martin Babinsky wrote: On 05/15/2015 04:25 PM, Jan Cholasta wrote: Dne 15.5.2015 v 16:16 Martin Babinsky napsal(a): These two patches fix two issues reported by David Kupka in most recent freeipa-master builds, which are caused by my previous patch 0031 provide

Re: [Freeipa-devel] [PATCH 0049] Move CA installation code into single module.

2015-06-05 Thread David Kupka
On 06/03/2015 05:49 PM, David Kupka wrote: Updated patch attached. -- David Kupka From ca004a585f86a5e35d02a90dc9db0753f786b84a Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Wed, 3 Jun 2015 17:43:27 +0200 Subject: [PATCH] Move CA installation code into single module

Re: [Freeipa-devel] [patch 0002] Abstract the HostTracker class from host plugin test

2015-06-05 Thread David Kupka
class which is used for most of the xml-rpc tests at the moment. For an example usage take a look at the host plugin test. Cheers, Milan Hello! Thanks for the patch. Works for me, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman

[Freeipa-devel] [PATCH 0051] Use 389-ds centralized scripts.

2015-06-09 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4051 -- David Kupka From da898ff6fbe760ff6786763297ecbf31bf10d300 Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Wed, 1 Apr 2015 11:27:36 -0400 Subject: [PATCH] Use 389-ds centralized scripts. Directory server is deprecating use

[Freeipa-devel] [PATCH 0052] Stage User: Fix permissions naming and split them where, apropriate.

2015-06-10 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/5057 -- David Kupka From ea25f9942c529ab91f1fe09f4eed087c6e5e92be Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Wed, 10 Jun 2015 12:52:10 +0200 Subject: [PATCH] Stage User: Fix permissions naming and split them where apropriate. Split

Re: [Freeipa-devel] [PATCHES 439-442] install: Migrate ipa-replica-install to the install framework

2015-06-10 Thread David Kupka
On 06/09/2015 02:06 PM, Jan Cholasta wrote: Hi, the attached patches implement another part of https://fedorahosted.org/freeipa/ticket/4468. Honza Works for me, ACK. -- David Kupka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo

<    1   2   3   4   5   >