RE: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-22 Thread Paul Hampson
> From: Alan DeKok > Sent: Sunday, 22 June 2003 10:50 PM > Oliver Graf <[EMAIL PROTECTED]> wrote: > > The BSD style check is done last. BSD style gethostby is not > > thread safe on glibc2 systems. Cause the BSD check is done last, the > > configure script overwrites the previous detected GNU

Re: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-22 Thread Alan DeKok
Oliver Graf <[EMAIL PROTECTED]> wrote: > > Oh, and when submitting patches to configure.in, I'd suggest submitting > > the equivalent patch to configure. Otherwise if someone overlooks the > > regeneration, it appears to not work for no apparent reason. > > Hmmm. I did not do this, cause other pro

Re: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-22 Thread Alan DeKok
Oliver Graf <[EMAIL PROTECTED]> wrote: > The BSD style check is done last. BSD style gethostby is not > thread safe on glibc2 systems. Cause the BSD check is done last, the > configure script overwrites the previous detected GNU style > gethostbyaddr_r. Just look at the diff, you will see that

RE: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-22 Thread Paul Hampson
> From: Oliver Graf > Sent: Sunday, 22 June 2003 6:36 PM > On Sun, Jun 22, 2003 at 05:58:42PM +1000, Paul Hampson wrote: > > However, problems with the patch: > > the patch to src/lib/misc.c shows a cut and paste oversight by testing > > GETHOSTBYADDRRSTYLE when choosing the gethostbyname_r functi

Re: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-22 Thread Oliver Graf
On Sun, Jun 22, 2003 at 05:58:42PM +1000, Paul Hampson wrote: > > But the server ALREADY uses the '..._r' functions. What's the > > problem? Or am I missing something? > > The problems are: > gethostbyaddr_r determination will pick BSD (The non-_r version) > over GNU or SYSV. This is because t

RE: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-22 Thread Paul Hampson
> From: Alan DeKok > Sent: Sunday, 22 June 2003 9:48 AM > Oliver Graf <[EMAIL PROTECTED]> wrote: > > > > This patchs enables the detection of the correct > > > > gethostby(name|addr)_r command, which is needed by a threaded radiusd. > Unless I'm greatly mistaken, that functionality was added ma

Re: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-22 Thread Oliver Graf
On Sun, Jun 22, 2003 at 08:47:25AM +0200, Oliver Graf wrote: > On Sat, Jun 21, 2003 at 07:47:37PM -0400, Alan DeKok wrote: > > Oliver Graf <[EMAIL PROTECTED]> wrote: > > > > > This patchs enables the detection of the correct > > > > > gethostby(name|addr)_r command, which is needed by a threaded ra

Re: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-21 Thread Oliver Graf
On Sat, Jun 21, 2003 at 07:47:37PM -0400, Alan DeKok wrote: > Oliver Graf <[EMAIL PROTECTED]> wrote: > > > > This patchs enables the detection of the correct > > > > gethostby(name|addr)_r command, which is needed by a threaded radiusd. > > Unless I'm greatly mistaken, that functionality was add

Re: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-21 Thread Alan DeKok
Oliver Graf <[EMAIL PROTECTED]> wrote: > > > This patchs enables the detection of the correct > > > gethostby(name|addr)_r command, which is needed by a threaded radiusd. Unless I'm greatly mistaken, that functionality was added many months ago. See 'src/main/misc.c' > > I haven't looked at th

Re: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-21 Thread Oliver Graf
On Sat, Jun 21, 2003 at 02:52:50AM +1000, Paul Hampson wrote: > > From: Oliver Graf > > Sent: Saturday, 21 June 2003 12:39 AM > > > This patchs enables the detection of the correct > > gethostby(name|addr)_r command, which is needed by a threaded radiusd. > > Which patch? Hmpf... now its attache

RE: [PATCH] gethostbyaddr_r and gethostbyname_r corrections

2003-06-20 Thread Paul Hampson
> From: Oliver Graf > Sent: Saturday, 21 June 2003 12:39 AM > This patchs enables the detection of the correct > gethostby(name|addr)_r command, which is needed by a threaded radiusd. Which patch? Oh, did you have a look at the CVS history for configure.in and configure.in? I noticed the other d