Re: Handing out duplicate IP addresses

2009-01-19 Thread Alan DeKok
t...@kalik.net wrote: When multiple threads ask for an IP at the same time it is possible for same IP to be issued to different users. That's because allocate-find works 10 or more times faster than allocate-update. There is a chance that several allocate-finds will complete before first

Re: Handing out duplicate IP addresses

2009-01-19 Thread tnt
When multiple threads ask for an IP at the same time it is possible for same IP to be issued to different users. That's because allocate-find works 10 or more times faster than allocate-update. There is a chance that several allocate-finds will complete before first allocate-update makes the

Re: Handing out duplicate IP addresses

2009-01-19 Thread Alan DeKok
t...@kalik.net wrote: solution :-D You have to use a real database for that (e.g. PostgreSQL -- where they're supported in the form of save points) ;) I've added a note to sqlippool.conf about MySQL. This should hopefully cut down on the problems questions. Alan DeKok. - List

Re: Handing out duplicate IP addresses

2009-01-18 Thread Alan DeKok
Dave wrote: Can I ask what happens when the module fails ? If the module is allocated two IP addresses to the same user, it is failing in a big way. My reading of the code is that it *intends* to do the queries allocations as part of one SQL transaction. It appears, though, that

Re: Handing out duplicate IP addresses

2009-01-18 Thread tnt
Can I ask what happens when the module fails ? If the module is allocated two IP addresses to the same user, it is failing in a big way. It's the other way around. Not two IPs to the same user but same IP to multiple users. It's a threading issue. When multiple threads ask for an IP at the

Re: Handing out duplicate IP addresses

2009-01-18 Thread Dave
I made this modification to the ippool.conf and still testing it, I have not seen the issue yet again but I havent loaded the server down. I made some other modifications to the server and database to try to make it move as fast possible but removing non-used modules, database indexing, other

Re: Handing out duplicate IP addresses

2009-01-17 Thread Dave
AFAIK it is the transaction. Problem is that update will work for all three users. Adding expiry_time IS NULL to update will cause it to work only for the first user. Ivan Kalik Kalik Informatika ISP - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Re: Handing out duplicate IP addresses

2009-01-17 Thread tnt
My guess is it will still return an access-accept with all other attributes accumulated minus the Framed-Ip-Address ? Id rather it return a big fat reject, and let the NAS resend a new request? You can configure more than one sqlippool instance. Then put as many as you like in a fail-over

Re: Handing out duplicate IP addresses

2009-01-15 Thread tnt
The requests all came in at the same time, to the second (among others), its like FR took 3 requests and looked at the database at the exact same time, saw it was an available IP and all those 3 requests assigned it. That can't be avoided. SELECT (allocate-find) will always work much faster than

Re: Handing out duplicate IP addresses

2009-01-15 Thread Padam J Singh
Hello Ivan, Would adding a mutex around the select-update code in the sqlippool module solve this issue? Padam t...@kalik.net wrote: The requests all came in at the same time, to the second (among others), its like FR took 3 requests and looked at the database at the exact same

RE: Handing out duplicate IP addresses

2009-01-15 Thread Ben Wiechman
9:39 AM To: FreeRadius users mailing list Subject: Re: Handing out duplicate IP addresses Hello Ivan, Would adding a mutex around the select-update code in the sqlippool module solve this issue? Padam t...@kalik.net wrote: The requests all came in at the same time, to the second (among

Re: Handing out duplicate IP addresses

2009-01-15 Thread Dave
Of *Padam J Singh *Sent:* Thursday, January 15, 2009 9:39 AM *To:* FreeRadius users mailing list *Subject:* Re: Handing out duplicate IP addresses Hello Ivan, Would adding a mutex around the select-update code in the sqlippool module solve this issue? Padam t...@kalik.net mailto:t

RE: Handing out duplicate IP addresses

2009-01-15 Thread tnt
Can't you do the select and update as part of one transaction? For example with MySQL: START TRANSACTION; SELECT @A:=SUM(salary) FROM table1 WHERE type=1; UPDATE table2 SET summa...@a WHERE type=1; COMMIT; AFAIK it is the transaction. Problem is that update will work for all three users.

Re: Handing out duplicate IP addresses

2009-01-15 Thread tnt
[mailto:freeradius-users-bounces+ben=wisper-wireless@lists.freeradius.org] *On Behalf Of *Padam J Singh *Sent:* Thursday, January 15, 2009 9:39 AM *To:* FreeRadius users mailing list *Subject:* Re: Handing out duplicate IP addresses Hello Ivan, Would adding a mutex around the select

Handing out duplicate IP addresses

2009-01-14 Thread Dave
I thought I had this problem licked, but I still suffer from it. Anyone know why FR 2.1.3 with sqlippool (mysql) might decide to hand out the same IP more than once while its processing more than one request at a time? Wed Jan 14 22:05:59 2009 : Info: Allocated IP: 75.119.xxx,211 from