SoH patch (was Re: Microsoft SoH Support)

2011-01-06 Thread James J J Hooper
On 11/10/2010 22:14, James J J Hooper wrote: On 11/10/2010 12:37, Phil Mayers wrote: On 09/10/10 15:01, Garber, Neal wrote: Thanks to a lot of work by Phil Mayers, the server now has support for Microsoft SoH in PEAP, normal RADIUS (MS VPN gateway), and in DHCP. Wow! That *must* have been a l

Re: Microsoft SoH Support

2010-10-12 Thread Alan DeKok
Phil Mayers wrote: > Ok, "aefe73e885198b5735fad6fbd59d63a9116912b7" looks good; patch against > that attached - it's nothing complex, but seems to work for me. Pushed, thanks. > (Is there an equivalent of "debug_pair_list" outputting via > request->radlog?) No, sorry. Alan DeKok. - List i

Re: Microsoft SoH Support

2010-10-12 Thread Alan DeKok
Alan Buxey wrote: > Hi, > > you know...some sicko side of me things it'd be great if > stats on SoH could be output via access with radmin or the Server-Status > packet... That's the kind of information which belongs in a DB, I think. It's not RADIUS related (packets sent / received), and it's

Re: Microsoft SoH Support

2010-10-12 Thread Alan Buxey
Hi, you know...some sicko side of me things it'd be great if stats on SoH could be output via access with radmin or the Server-Status packet... alan - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Re: Microsoft SoH Support

2010-10-12 Thread Phil Mayers
On 12/10/10 15:29, Alan DeKok wrote: OK... see "git". I've moved src/lib/soh.c -> src/main/soh.c, and done minimal updates to get it to compile. Ok, "aefe73e885198b5735fad6fbd59d63a9116912b7" looks good; patch against that attached - it's nothing complex, but seems to work for me. (Is t

Re: Microsoft SoH Support

2010-10-12 Thread Alan DeKok
OK... see "git". I've moved src/lib/soh.c -> src/main/soh.c, and done minimal updates to get it to compile. If you can redo the debug patches, I'll put them in. Or maybe I should just give you direct "git" access... Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.

Re: Microsoft SoH Support

2010-10-12 Thread Phil Mayers
On 12/10/10 11:11, Alan DeKok wrote: Phil Mayers wrote: Yeah - that's in 0004-*.patch (I noticed it when using the excellent raddebug to test that the SoH stuff appeared) OK... the patch doesn't apply, and adding/deleting the "\n" is Rats. Sorry about that. awkward. I'll make a few sim

Re: Microsoft SoH Support

2010-10-12 Thread Alan DeKok
Phil Mayers wrote: > Yeah - that's in 0004-*.patch (I noticed it when using the excellent > raddebug to test that the SoH stuff appeared) OK... the patch doesn't apply, and adding/deleting the "\n" is awkward. I'll make a few simple changes today, and push them to git.freeradius.org. Please

Re: Microsoft SoH Support

2010-10-12 Thread Phil Mayers
On 10/11/2010 10:14 PM, James J J Hooper wrote: Hi Phil, Alan, http://msdn.microsoft.com/en-us/library/cc251376%28v=PROT.10%29.aspx -> Independent of the above states, the last bit of the third byte of the AU ClientStatusCode can take the value of 1 if the AU settings on the client are contr

Re: Microsoft SoH Support

2010-10-11 Thread James J J Hooper
On 11/10/2010 22:14, James J J Hooper wrote: On 11/10/2010 12:37, Phil Mayers wrote: On 09/10/10 15:01, Garber, Neal wrote: Thanks to a lot of work by Phil Mayers, the server now has support for Microsoft SoH in PEAP, normal RADIUS (MS VPN gateway), and in DHCP. Wow! That *must* have been a l

Re: Microsoft SoH Support

2010-10-11 Thread James J J Hooper
On 11/10/2010 12:37, Phil Mayers wrote: On 09/10/10 15:01, Garber, Neal wrote: Thanks to a lot of work by Phil Mayers, the server now has support for Microsoft SoH in PEAP, normal RADIUS (MS VPN gateway), and in DHCP. Wow! That *must* have been a lot of work! Thank you Phil. Does this mean Fr

Re: Microsoft SoH Support

2010-10-11 Thread Phil Mayers
On 11/10/10 16:23, Alan DeKok wrote: Phil Mayers wrote: Ok, the attached should be more sane Debug messages shouldn't have "\n". The log function adds the "\n" itself. Yeah - that's in 0004-*.patch (I noticed it when using the excellent raddebug to test that the SoH stuff appeared) - L

Re: Microsoft SoH Support

2010-10-11 Thread Alan DeKok
Phil Mayers wrote: > Ok, the attached should be more sane Debug messages shouldn't have "\n". The log function adds the "\n" itself. Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Re: Microsoft SoH Support

2010-10-11 Thread James J J Hooper
--On Monday, October 11, 2010 14:24:07 +0200 Alan DeKok wrote: Phil Mayers wrote: I've tested it with WinXP SP3, Vista and Win7. There is one compile fix needed which must have snuck through (attached) I deleted all references to the REQUEST structure from src/lib/soh.c. The library f

Re: Microsoft SoH Support

2010-10-11 Thread Alan Buxey
Hi, > It's fairly useful though - you can enable it, and SoH-enabled clients > will submit info like: > This can be punted to a virtual server, and you can assign a vlan or > reject authentication etc. > > I've tested it with WinXP SP3, Vista and Win7. There is one compile fix > needed whic

Re: Microsoft SoH Support

2010-10-11 Thread Alan DeKok
Phil Mayers wrote: > Indeed. Is there a good way besides the DEBUG macro to emit debugging > output in lib/*.c code? Nope. > I imagine there will be SoH type/value or > type/len/value stuff that we'll want to log (but others that we won't - > it's probably too noisy as-is) OK. > Also I gues

Re: Microsoft SoH Support

2010-10-11 Thread Phil Mayers
On 11/10/10 13:24, Alan DeKok wrote: Phil Mayers wrote: I've tested it with WinXP SP3, Vista and Win7. There is one compile fix needed which must have snuck through (attached) I deleted all references to the REQUEST structure from src/lib/soh.c. The library functions are for clients, not

Re: Microsoft SoH Support

2010-10-11 Thread Alan DeKok
Phil Mayers wrote: > I've tested it with WinXP SP3, Vista and Win7. There is one compile fix > needed which must have snuck through (attached) I deleted all references to the REQUEST structure from src/lib/soh.c. The library functions are for clients, not just the server. The code in "git" s

Re: Microsoft SoH Support

2010-10-11 Thread Phil Mayers
On 09/10/10 15:01, Garber, Neal wrote: Thanks to a lot of work by Phil Mayers, the server now has support for Microsoft SoH in PEAP, normal RADIUS (MS VPN gateway), and in DHCP. Wow! That *must* have been a lot of work! Thank you Phil. Does this mean FreeRADIUS can now act as a Health Policy

Re: Microsoft SoH Support

2010-10-09 Thread Alan DeKok
Garber, Neal wrote: >> Thanks to a lot of work by Phil Mayers, the server now has support for >> Microsoft SoH in PEAP, normal RADIUS (MS VPN gateway), and in DHCP. > > Wow! That *must* have been a lot of work! Thank you Phil. ~1400 lines, including documentation. > Does this mean FreeRADIUS

RE: Microsoft SoH Support

2010-10-09 Thread Garber, Neal
> Thanks to a lot of work by Phil Mayers, the server now has support for > Microsoft SoH in PEAP, normal RADIUS (MS VPN gateway), and in DHCP. Wow! That *must* have been a lot of work! Thank you Phil. Does this mean FreeRADIUS can now act as a Health Policy Server? - List info/subscribe/unsubs

Microsoft SoH Support

2010-10-09 Thread Alan DeKok
Thanks to a lot of work by Phil Mayers, the server now has support for Microsoft SoH in PEAP, normal RADIUS (MS VPN gateway), and in DHCP. The code is in the "v2.1.x" branch, and in the "stable" branch. It will be in 2.1.11, and all later versions of the server. The documentation is in doc