Re: sql_log and Accounting On/Off

2012-08-11 Thread Alan DeKok
Arran Cudbard-Bell wrote: > Crazy idea, but could we just junk the sql_log module, and add a null driver > to rlm_sql? Geez, get with the program already: https://github.com/alandekok/freeradius-server/tree/master/src/modules/rlm_sql/drivers/rlm_sql_null :) It's had minimal testing, of c

Re: sql_log and Accounting On/Off

2012-08-11 Thread Arran Cudbard-Bell
On 10 Aug 2012, at 12:43, Alan DeKok wrote: > Stefan Winter wrote: >> Hi, >> Anyway, adding an example would still be nice :-) >>> Submit a patch, or edit the wiki? :D >> >> Here goes a unified diff - took the statement from sql/mysql/dialup.conf. > > Looks good to me, thanks. Crazy id

Re: sql_log and Accounting On/Off

2012-08-10 Thread Alan DeKok
Stefan Winter wrote: > Hi, > >>> Anyway, adding an example would still be nice :-) >> Submit a patch, or edit the wiki? :D > > Here goes a unified diff - took the statement from sql/mysql/dialup.conf. Looks good to me, thanks. Alan DeKok. - List info/subscribe/unsubscribe? See http://www.fr

Re: sql_log and Accounting On/Off

2012-08-10 Thread Stefan Winter
Hi, >> Anyway, adding an example would still be nice :-) > > Submit a patch, or edit the wiki? :D Here goes a unified diff - took the statement from sql/mysql/dialup.conf. Greetings, Stefan Winter --- sql_log.orig2012-08-10 11:05:49.690247808 +0200 +++ sql_log 2012-08-10 11:08:51.

Re: sql_log and Accounting On/Off

2012-08-09 Thread Fajar A. Nugraha
On Thu, Aug 9, 2012 at 7:53 PM, Stefan Winter wrote: > Hi, > >> That would be cute; but it's hard to find - one has to go into the code. >> So if I'm right with that, could the documentation in modules/sql_log be >> updated for 2.2.0? At least adding it as an example like the others >> would be ni

Re: sql_log and Accounting On/Off

2012-08-09 Thread Stefan Winter
Hi, > That would be cute; but it's hard to find - one has to go into the code. > So if I'm right with that, could the documentation in modules/sql_log be > updated for 2.2.0? At least adding it as an example like the others > would be nice. Ah, man 5 rlm_sql_log. Right. Sorry for the noise. Anyw

Re: sql_log and Accounting On/Off

2012-08-09 Thread Stefan Winter
Hi, > I wonder how to send stuff to sql_log when an On/Off arrives... guessing > that I'm simply overlooking something. Looking at the code: could it be that I can just use "Accounting-On" and "Accounting-Off" as keys, because the code seems to reference the values of Acct-Status-Type? That woul

sql_log and Accounting On/Off

2012-08-09 Thread Stefan Winter
Hello, I'm currently migrating a number of direct accounting sql module calls to delayed writes using sql_log. I noticed that sql_log has statements for Start, Stop, Alive (and Post-Auth, about which I don't care at that point). The real SQL modules have accounting_on_off_query, too. I wonder h