Re: [Freerdp-devel] FreeRDP API suggestion

2013-01-13 Thread arvid norr
Thank you for your reply Marc-André. I agree that it’s hard to understand how each variable is used and that can of course be solved with more comments and documentation, but some of that can also be solved with separation of the variables. It’s not a big change that I suggest. Maybe you misunder

Re: [Freerdp-devel] FreeRDP API suggestion

2013-01-12 Thread Marc-André Moreau
Hi, I have to disagree: this would create a lot of duplication and therefore causing even more confusion and making the code harder to maintain. Performance flags are a special case. To process them correctly in the client, you need to separately consider them and then construct the final Perform

[Freerdp-devel] FreeRDP API suggestion

2013-01-11 Thread arvid norr
In the rdpSettings structure many settings can be configured. Some of the parameters are used by the freeRDP libaries but some are only used internally by the client software. This is very hard to understand and also complicates the API to freeRDP. I suggest that all settings that are only used by