Re: [ft-devel] Integrating Docwriter into FreeType

2018-07-27 Thread Werner LEMBERG
> Why not just require virtualenv (Python 3 comes with the venv module > built-in and doesn’t need anything else), I know you are a BIG fan of Python 3, but not everybody has it as the default... > automatically make a virtual environment in the working directory > (pip should be installed

Re: [ft-devel] Integrating Docwriter into FreeType

2018-07-27 Thread Nikolaus Waxweiler
Why not just require virtualenv (Python 3 comes with the venv module built-in and doesn’t need anything else), automatically make a virtual environment in the working directory (pip should be installed automatically in it and if not, a call to `python -m ensurepip` in the venv fixes that) and

Re: [ft-devel] Integrating Docwriter into FreeType

2018-07-27 Thread Werner LEMBERG
> In any case, we must ensure `pip' is available. Yes. But packages should *not* be installed by the script but by the user. I think something like the following might work. 1. Check whether all needed modules are available, ideally using a simple solution that doesn't need `pip'. No need

Re: [ft-devel] Integrating Docwriter into FreeType

2018-07-27 Thread Nikhil Ramakrishnan
> Hmm. `make refdoc' is not a target that is to be called by Joe User. > It was always handled specially, i.e., it was assumed, for example, > that Python is available, without testing for its existence. > True. I'm not sure if we should shift the responsibility of creating a virtualenv to the

Re: [ft-devel] Integrating Docwriter into FreeType

2018-07-27 Thread Cosimo Lupo
I can confirm that running `make refdoc` from a within a fresh virtual environment (after having removed the --user) option, works for me. I'm running python 2.7.14 on Debian. I don't get the error that Werner gets, because I'm installing all the dependencies from scratch in the new virtual

Re: [ft-devel] Integrating Docwriter into FreeType

2018-07-27 Thread Cosimo Lupo
Besides, the `--user` option of pip install is incompatible with a virtual environment, you should remove that in any case, because it will prevent users like me, who would prefer to install the dependencies in a temporary virtual environment, from being able to run `make refdoc` from within an

Re: [ft-devel] Integrating Docwriter into FreeType

2018-07-27 Thread Cosimo Lupo
It's not a good idea to have the `make refdoc` target call pip to install missing requirements in the user's python lib. I don't want those packages to pollute my environment, if I just want to build the freetype documentation. You should either exit with error if the requirements are not met, and

Re: [ft-devel] GF + TFM

2018-07-27 Thread Parth Wazurkar
> > > For testing the `tfm' module in `ftview', I tried to do some changes > > in the `ftcommon.c' file, but could not solve the problem, can you > > tell me what am I missing in this. > > > > Here is the diff of my changes in `ftcommon.c': > > > > diff --git a/src/ftcommon.c b/src/ftcommon.c > >

Re: [ft-devel] GF + TFM

2018-07-27 Thread Werner LEMBERG
> For testing the `tfm' module in `ftview', I tried to do some changes > in the `ftcommon.c' file, but could not solve the problem, can you > tell me what am I missing in this. > > Here is the diff of my changes in `ftcommon.c': > > diff --git a/src/ftcommon.c b/src/ftcommon.c > index

Re: [ft-devel] GF + TFM

2018-07-27 Thread Parth Wazurkar
Hi, For testing the `tfm' module in `ftview', I tried to do some changes in the `ftcommon.c' file, but could not solve the problem, can you tell me what am I missing in this. Here is the diff of my changes in `ftcommon.c': diff --git a/src/ftcommon.c b/src/ftcommon.c index 1ef3495..3526231