Chandan Pitta wrote:
> Looks right. Hopefully we are done here...
Me too, I had detected your frustration :)
Duncan
>
>
> On 1/3/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
>> Chandan Pitta wrote:
>>> Ok I made the changes just apply the patch and it should make use of
>>> the fileops.py now.
>>
Looks right. Hopefully we are done here...
On 1/3/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
> Chandan Pitta wrote:
> > Ok I made the changes just apply the patch and it should make use of
> > the fileops.py now.
> >
> > However I am having doubts regarding the scaling using imlib2. Look at
> > s
Chandan Pitta wrote:
> Ok I made the changes just apply the patch and it should make use of
> the fileops.py now.
>
> However I am having doubts regarding the scaling using imlib2. Look at
> snapshot4.png and you will see that the images seem to be stretched
> out.
> I am using imlib2 v1.3 and gif
Chandan Pitta wrote:
> Code reuse is always good. But once again the question arises, how
> does freevo handle changes to WWW_IMAGE_THUMBNAIL_SIZE if images are
> already cached. I am guessing we may need another function in
> fileops.py like
freevo cache --rebuild should do it. It may not work un
Code reuse is always good. But once again the question arises, how
does freevo handle changes to WWW_IMAGE_THUMBNAIL_SIZE if images are
already cached. I am guessing we may need another function in
fileops.py like
def is_image_cached(scaled_image_path):
new_size = config.WWW_IMAGE_THUMBNAIL_SI
Duncan Webb wrote:
> Chandan Pitta wrote:
>> Try this patch.
>
> Patch worked fine now in svn rel-1 at r8917
>
> I have these functions in util.fileops.py which is now updated from the
> patch you have sent. They is called when "freevo cache" is run.
>
> def cache_www_thumbnail_path(filename):
>
Chandan Pitta wrote:
> Try this patch.
Patch worked fine now in svn rel-1 at r8917
I have these functions in util.fileops.py which is now updated from the
patch you have sent. They is called when "freevo cache" is run.
def cache_www_thumbnail_path(filename):
'''returns the path to the thumbn
No it was only intended for images. The movie and music arts will not
be scaled and cached.
On 1/2/07, Ryan Roth <[EMAIL PROTECTED]> wrote:
> This works more movie cover art too right? Because I cannot get it to work.
>
> Chandan Pitta wrote:
> > Try this patch.
> >
> >
> > On 1/2/07, Duncan Webb
This works more movie cover art too right? Because I cannot get it to work.
Chandan Pitta wrote:
> Try this patch.
>
>
> On 1/2/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
>> Chandan Pitta wrote:
>> > Sorry attached the wrong diff file. See this one
>>
>> I can't apply this patch, says that it has
Try this patch.
On 1/2/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
Chandan Pitta wrote:
> Sorry attached the wrong diff file. See this one
I can't apply this patch, says that it has been previously detected.
Will you try an svn update, I applied Wout's patch at 8912 and your
one-liner after.
Chandan Pitta wrote:
> Sorry attached the wrong diff file. See this one
I can't apply this patch, says that it has been previously detected.
Will you try an svn update, I applied Wout's patch at 8912 and your
one-liner after.
Thanks
Duncan
>
>
> On 1/2/07, Chandan Pitta <[EMAIL PROTECTED]> wro
Sorry attached the wrong diff file. See this one
On 1/2/07, Chandan Pitta <[EMAIL PROTECTED]> wrote:
Hi Duncan,
Here is another patch (hopefully the last one) that fixes the following issues:
* Images with spaces in the filename or in the directories are not
being displayed properly (see Wout'
Hi Duncan,
Here is another patch (hopefully the last one) that fixes the following issues:
* Images with spaces in the filename or in the directories are not
being displayed properly (see Wout's issue)
* Since the WWW_IMAGE_THUMBNAIL_SIZE is a tuple of 2 values, I decided
to change get_fit_to_squ
It should be (100, 100).
On 1/2/07, Ryan Roth <[EMAIL PROTECTED]> wrote:
> o should it be set to ( 100, 100 ) or just ( 100 ) ?
>
> Chandan Pitta wrote:
> > Hello Ryan,
> >
> > It seems to be working for me. I am wondering if you are expecting all
> > your images to be scaled to 100 x 75. If that
o should it be set to ( 100, 100 ) or just ( 100 ) ?
Chandan Pitta wrote:
> Hello Ryan,
>
> It seems to be working for me. I am wondering if you are expecting all
> your images to be scaled to 100 x 75. If that is true than the
> assumption is wrong. The webserver currently expects the thumbnail
>
Hello Ryan,
It seems to be working for me. I am wondering if you are expecting all
your images to be scaled to 100 x 75. If that is true than the
assumption is wrong. The webserver currently expects the thumbnail
size to be a square so you should be using 100x100. And all your
images will be scale
Thank you, this fixed it!
Wout
Chandan Pitta wrote:
Hi Wout,
I got the fix. Apply this patch on the latest svn
Index: src/www/htdocs/library.rpy
===
--- src/www/htdocs/library.rpy (revision 8911)
+++ src/www/htdocs/library.rpy
Hi Wout,
I got the fix. Apply this patch on the latest svn
Index: src/www/htdocs/library.rpy
===
--- src/www/htdocs/library.rpy (revision 8911)
+++ src/www/htdocs/library.rpy (working copy)
@@ -465,7 +465,7 @@
Chandan Pitta wrote:
On 1/2/07, wout clymans <[EMAIL PROTECTED]> wrote:
Chandan Pitta wrote:
On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
Chandan Pitta wrote:
Changed all images sizes to tuples. fileinfo.rpy does not need any
changes. freevo_config.py is already using tuple.
Ch
I have WWW_IMAGE_THUMBNAIL_SIZE = (100, 75) set in my local_conf, but I
don't seethat it is doing anything. Do I have it set right?
Thanks
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsa
On 1/2/07, wout clymans <[EMAIL PROTECTED]> wrote:
>
> Chandan Pitta wrote:
> On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
>
>
> Chandan Pitta wrote:
>
>
> Changed all images sizes to tuples. fileinfo.rpy does not need any
> changes. freevo_config.py is already using tuple.
>
> Cheers.
>
Chandan Pitta wrote:
> On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
>> Chandan Pitta wrote:
>>> Changed all images sizes to tuples. fileinfo.rpy does not need any
>>> changes. freevo_config.py is already using tuple.
>> Cheers.
>>
>> The library images are starting to look very good, terrific
Chandan Pitta wrote:
On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
Chandan Pitta wrote:
Changed all images sizes to tuples. fileinfo.rpy does not need any
changes. freevo_config.py is already using tuple.
Cheers.
The library images are starting to look very good, terrific w
On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
> Chandan Pitta wrote:
> > Changed all images sizes to tuples. fileinfo.rpy does not need any
> > changes. freevo_config.py is already using tuple.
>
> Cheers.
>
> The library images are starting to look very good, terrific work.
>
> How would we ch
Ryan Roth wrote:
> So do the WWW_IMAGE_THRESHOLD_SIZE &.WWW_IMAGE_THUMBNAIL_SIZE options work?
Yes, but I don't think we need WWW_IMAGE_THRESHOLD_SIZE as the
thumbnails are created for all images when cached. I will remove it today.
Duncan
>
> Duncan Webb wrote:
>> Chandan Pitta wrote:
>>
>>>
So do the WWW_IMAGE_THRESHOLD_SIZE &.WWW_IMAGE_THUMBNAIL_SIZE options work?
Duncan Webb wrote:
> Chandan Pitta wrote:
>
>> Changed all images sizes to tuples. fileinfo.rpy does not need any
>> changes. freevo_config.py is already using tuple.
>>
>
> Cheers.
>
> The library images are start
Chandan Pitta wrote:
> Changed all images sizes to tuples. fileinfo.rpy does not need any
> changes. freevo_config.py is already using tuple.
Cheers.
The library images are starting to look very good, terrific work.
How would we change the clicking of the image so that it fits the newly
opened b
Changed all images sizes to tuples. fileinfo.rpy does not need any
changes. freevo_config.py is already using tuple.
Index: src/www/htdocs/library.rpy
===
--- src/www/htdocs/library.rpy (revision 8895)
+++ src/www/htdocs/library.rpy
On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
> Chandan Pitta wrote:
> > On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
> >> Chandan Pitta wrote:
> >>> Hi Duncan,
> >>>
> >>
> >> I'm wondering about this line, why is a + ".jpg" at the end of the line?
> >>
> >> scaled_image_path = self.cache
Chandan Pitta wrote:
> On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
>> Chandan Pitta wrote:
>>> Hi Duncan,
>>>
>>
>> I'm wondering about this line, why is a + ".jpg" at the end of the line?
>>
>> scaled_image_path = self.cache_dir + filepath.replace("/",
>> "_").replace(".", "_") + ".jpg"
>
>
On 1/1/07, Duncan Webb <[EMAIL PROTECTED]> wrote:
> Chandan Pitta wrote:
> > Hi Duncan,
> >
> > I could not apply your patch. I get the following error messages.
> >
> > patching file www/htdocs/library.rpy
> > Hunk #2 FAILED at 70.
> > Hunk #3 FAILED at 289.
> > Hunk #4 FAILED at 313.
> > Hunk #5
Duncan Webb wrote:
> Chandan Pitta wrote:
>
> It was you patch with, but using:
> new_image = image.scale_preserve_aspect(config.WWW_IMAGE_THUMBNAIL_SIZE)
> Which means that resize_image_to_square could go, but I see we need this.
>
> This means that I can now change freevo cache to create these
Chandan Pitta wrote:
> Hi Duncan,
>
> I could not apply your patch. I get the following error messages.
>
> patching file www/htdocs/library.rpy
> Hunk #2 FAILED at 70.
> Hunk #3 FAILED at 289.
> Hunk #4 FAILED at 313.
> Hunk #5 FAILED at 465.
> Hunk #6 FAILED at 607.
> 5 out of 7 hunks FAILED --
Hi Duncan,
I could not apply your patch. I get the following error messages.
patching file www/htdocs/library.rpy
Hunk #2 FAILED at 70.
Hunk #3 FAILED at 289.
Hunk #4 FAILED at 313.
Hunk #5 FAILED at 465.
Hunk #6 FAILED at 607.
5 out of 7 hunks FAILED -- saving rejects to file www/htdocs/library.
Added WWW_IMAGE_SIZE and WWW_IMAGE_THRESHOLD to library.rpy. Did not
know if I should add those variable to freevo_config.py or the
maintainer will add them.
Example usage
WWW_IMAGE_SIZE = (100, 100)
WWW_IMAGE_THRESHOLD = (800, 600)
Regards,
Chandan
On 12/30/06, Ryan Roth <[EMAIL PROTECTED]> w
WWW_IMAGE_THRESHOLD
Chandan Pitta wrote:
> Can you think up of a variable name for threshold_size as well? That
> way we can decide on which images to scale.
>
> Although I like the flexibility of configuration variables, they have
> some limitations as well. For example in this case we are only
>
Can you think up of a variable name for threshold_size as well? That
way we can decide on which images to scale.
Although I like the flexibility of configuration variables, they have
some limitations as well. For example in this case we are only
checking if the scaled image is in cache, and if it
Could we make the images size a variable that could be also set from the
local_conf? I would personally like the image to be 100x100.
You could use 'if hasattr(conf, 'WWW_IMAGE_SIZE'):' then fall back to
200x200 if its not set
Chandan Pitta wrote:
> Hi Duncan,
>
> I think these patches must
Hi Duncan,
I think these patches must have got lost in the noise. I sent the
patches on 28, but to save you some trouble I am reattaching the files
again and pasting the message for reference.
Hello Duncan and Wout,
I fixed the issue where you can have ITEMS which may not be a tuple
(like in th
wout clymans wrote:
> Chandan Pitta wrote:
>> On 12/28/06, Duncan Webb <[EMAIL PROTECTED]> wrote:
>>
>>> Chandan Pitta wrote:
>> I think it is a good idea, but this has to be done only for
>> media=images. I will take a look at it.
>>
> If you need any help, let me know!
> Question i already
Doh I forgot the attachments.
On 12/28/06, Chandan Pitta <[EMAIL PROTECTED]> wrote:
Hello Duncan and Wout,
I fixed the issue where you can have ITEMS which may not be a tuple
(like in the case of web radio). So Duncan with the new patch you
should be able to use webserver without any modificat
Hello Duncan and Wout,
I fixed the issue where you can have ITEMS which may not be a tuple
(like in the case of web radio). So Duncan with the new patch you
should be able to use webserver without any modifications and
(hopefully) no crashes :-). Before adding child resources to twisted I
check to
Chandan Pitta wrote:
> On 12/28/06, Duncan Webb <[EMAIL PROTECTED]> wrote:
>> Chandan Pitta wrote:
>>> Hello,
>>>
>>> I was unable to attach files in the tracker so I am replying to this
>>> email with attachments. I made some changes to the webserver so that
>>> it can make use of child resources
Chandan Pitta wrote:
On 12/28/06, Duncan Webb <[EMAIL PROTECTED]> wrote:
Chandan Pitta wrote:
I think it is a good idea, but this has to be done only for
media=images. I will take a look at it.
If you need any help, let me know!
Question i already have:
do we need to resize all images or
On 12/28/06, Duncan Webb <[EMAIL PROTECTED]> wrote:
> Chandan Pitta wrote:
> > Hello,
> >
> > I was unable to attach files in the tracker so I am replying to this
> > email with attachments. I made some changes to the webserver so that
> > it can make use of child resources instead of creating seve
Chandan Pitta wrote:
> Hello,
>
> I was unable to attach files in the tracker so I am replying to this
> email with attachments. I made some changes to the webserver so that
> it can make use of child resources instead of creating several links
> in /var/cache/freevo. Not that I have anything agai
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by duncanwebb
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment
Hello,
I was unable to attach files in the tracker so I am replying to this
email with attachments. I made some changes to the webserver so that
it can make use of child resources instead of creating several links
in /var/cache/freevo. Not that I have anything against having all the
links but it
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by reudeudeu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by woutc
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment thre
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by woutc
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment thre
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by reudeudeu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by woutc
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment thre
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by reudeudeu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by duncanwebb
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment
Yeah that button was missing. I have attached files before, I had even
done some earlier today I think, it just wasn't there that time.
Duncan Webb wrote:
Ryan Roth wrote:
Duncan Webb wrote:
Ryan Roth wrote:
I could not attach these on the
Ryan Roth wrote:
> Duncan Webb wrote:
>> Ryan Roth wrote:
>>
>>> I could not attach these on the sf.net page for some reason.
>>>
>> But anyway thanks for the patch it looks good, I'll add but call the
>> config variable WEBSERVER_HTDOCS. Wonder why I didn't change WWW_USERS
>> at the time.
Thanks. I'm not sure why I couldn't attach. The button just wasn't there.
Duncan Webb wrote:
> Ryan Roth wrote:
>
>> I could not attach these on the sf.net page for some reason.
>>
>
> But anyway thanks for the patch it looks good, I'll add but call the
> config variable WEBSERVER_HTDO
Ryan Roth wrote:
> I could not attach these on the sf.net page for some reason.
But anyway thanks for the patch it looks good, I'll add but call the
config variable WEBSERVER_HTDOCS. Wonder why I didn't change WWW_USERS
at the time.
I'm curious why couldn't you attach a patch, could it be because
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by duncanwebb
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Comment added) made by duncanwebb
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment
I could not attach these on the sf.net page for some reason.
Index: fileinfo.rpy
===
--- fileinfo.rpy(revision 8748)
+++ fileinfo.rpy(working copy)
@@ -112,7 +112,10 @@
return String( fv.res )
def c
Bugs item #1604844, was opened at 2006-11-28 22:08
Message generated for change (Comment added) made by ryanroth
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy of the comment t
Bugs item #1604844, was opened at 2006-11-28 23:08
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1604844&group_id=46652
Please note that this message will contain a full copy o
64 matches
Mail list logo
