Re: [fricas-devel] [PATCH] fix title related memory issues

2024-05-24 Thread Qian Yun
I wanted to avoid pulling in "fricas_sprintf_to_buf". Turns out I can use const char *errorStr = "read from viewport manager\n"; Are you OK with this? - Qian On 5/24/24 07:19, Waldek Hebisch wrote: It is good to fix buffer overflow. But you also remove error checking (use of 'check'). A

Re: [fricas-devel] Serial part of build

2024-05-24 Thread Qian Yun
On 5/24/24 06:32, Waldek Hebisch wrote: I am not sure. At least we world need proper dependencies. Most of those files are categories. We compile categories because compiling may need to load compiled categories. And compiling a category need categories that it uses. Our list of categori

Re: [fricas-devel] Serial part of build

2024-05-24 Thread Waldek Hebisch
On Fri, May 24, 2024 at 05:13:10PM +0800, Qian Yun wrote: > > > On 5/24/24 06:32, Waldek Hebisch wrote: > > > > I am not sure. At least we world need proper dependencies. Most of > > those files are categories. We compile categories because compiling > > may need to load compiled categories.

Re: [fricas-devel] [PATCH] fix title related memory issues

2024-05-24 Thread Waldek Hebisch
On Fri, May 24, 2024 at 05:04:08PM +0800, Qian Yun wrote: > I wanted to avoid pulling in "fricas_sprintf_to_buf". > > Turns out I can use > > const char *errorStr = "read from viewport manager\n"; > > Are you OK with this? OK if we really need to remove uses of "fricas_sprintf_to_buf". But wh

Re: [fricas-devel] )fin, restart, (|spad|) with Clozure CL based FriCAS

2024-05-24 Thread Waldek Hebisch
On Wed, May 22, 2024 at 10:03:32PM +0200, Grégory Vanuxem wrote: > Le mar. 21 mai 2024 à 20:32, Waldek Hebisch a écrit : > > > > On Tue, May 21, 2024 at 01:57:45PM +0200, Grégory Vanuxem wrote: > > > > The function to start FriCAS is 'fricas_restart'. 'fricas_restart' > > is doing some initializa

Re: [fricas-devel] )fin, restart, (|spad|) with Clozure CL based FriCAS

2024-05-24 Thread Grégory Vanuxem
Hello Waldek, > When this code was written Clozure CL documentation about building > text mode applications was rather poor. I just followed one of > examples that worked OK. And Clozure CL folks did not mention > 'ccl::toplevel-loop'. IIUC they later simplified and improved > creation of appli