[fw-general] Request to correct a sample code in ZF Manual

2008-02-01 Thread AmirBehzad Eslami
@see: 7.8.4.3.2. Basic Usage Examples ... $this->_redirector->setCode('303') should become: $this->_redirector->setCode(303)

Re: [fw-general] Request to correct a sample code in ZF Manual

2008-02-01 Thread Matthew Weier O'Phinney
-- AmirBehzad Eslami <[EMAIL PROTECTED]> wrote (on Friday, 01 February 2008, 05:47 PM +0330): > >> My understanding is > >> that PHP will convert it to an integer before sending it anyways. > > No. In my experience an exception thrown > @see: Controller/Response/Abstract.php , Line 230 > >

Re: [fw-general] Request to correct a sample code in ZF Manual

2008-02-01 Thread Matthew Weier O'Phinney
-- AmirBehzad Eslami <[EMAIL PROTECTED]> wrote (on Friday, 01 February 2008, 04:13 PM +0330): > @see: 7.8.4.3.2. Basic Usage Examples > ... > > $this->_redirector->setCode('303') > > should become: > > $this->_redirector->setCode(303) Have you actually experienced an issue with that? My underst

Re: [fw-general] Request to correct a sample code in ZF Manual

2008-02-01 Thread AmirBehzad Eslami
>> My understanding is >> that PHP will convert it to an integer before sending it anyways. No. In my experience an exception thrown @see: Controller/Response/Abstract.php , Line 230 if (!is_int($code) || (100 > $code) || (599 < $code)) { require_once 'Zend/Controller/Response

Re: [fw-general] Request to correct a sample code in ZF Manual

2008-02-01 Thread AmirBehzad Eslami
Also see: Controller/Action/Helper/Redirector.php Line 89: if (!is_int($code) || (300 > $code) || (307 < $code)) { require_once 'Zend/Controller/Exception.php'; throw new Zend_Controller_Action_Exception('Invalid redirect HTTP status code (' . $code . ')');

Re: [fw-general] Request to correct a sample code in ZF Manual

2008-02-01 Thread Matthew Weier O'Phinney
-- AmirBehzad Eslami <[EMAIL PROTECTED]> wrote (on Friday, 01 February 2008, 07:07 PM +0330): > I just found the following note in PHP Manual (@see: entry for is_int()) > > Note: > > To test if a variable is a number or a numeric string (such as form input, > which is always a string), you must u

Re: [fw-general] Request to correct a sample code in ZF Manual

2008-02-01 Thread AmirBehzad Eslami
I just found the following note in PHP Manual (@see: entry for is_int()) *Note: * *To test if a variable is a number or a numeric string (such as form input, which is always a string), you must use is_numeric(). * OK. I'll place an issue in the tracker. Thank you for your attention. On Feb 1, 2

Re: [fw-general] Request to correct a sample code in ZF Manual

2008-02-01 Thread Lars Strojny
Hi, Am Freitag, den 01.02.2008, 09:48 -0500 schrieb Matthew Weier O'Phinney: [...] > So, what I'm thinking is that instead of checking for is_int(), we > should cast to int prior to any other checks. That way, both '303' and > 303 will work, and users don't need to be worried about the specific >