Re: [fw-general] Writing a patch help

2009-03-04 Thread Ben Scholzen 'DASPRiD'
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 When the current unit tests do not fail, you have to create a new test which fails with the current version (1.7.6) but successes with your patch. The test itself should be located in the test suite of the component. ...

[fw-general] Writing a patch help

2009-03-04 Thread keith Pope
Hi, I am just going through creating a patch for Zend_Db_Table* for issue http://framework.zend.com/issues/browse/ZF-4167 I am wondering if unit tests are required for this, as the standard tests already cover the area of change? Also for a specific issue where should tests be created if needed?