Re: [PATCH stable-2.15] Fix CLI option typo in NEWS file

LGTM, Thanks for tracing this down, and cleaning it up! On Fri, May 6, 2016 at 3:35 PM, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > As reported in 1177, the option is --new-node-certificates not > --renew-node-certificates. > > While here, fix a few other

[PATCH stable-2.15] Fix CLI option typo in NEWS file

As reported in 1177, the option is --new-node-certificates not --renew-node-certificates. While here, fix a few other miscellaneous docs typos. Signed-off-by: Brian Foley --- NEWS | 2 +- doc/design-2.0.rst| 6 +++--- doc/design-2.1.rst| 6 +++---

Re: [PATCH stable-2.15] Fix CLI option typo in NEWS file

Hey Brian, patch seems pretty straightforward, thanks for taking your time to go through it. I just have a very minor nitpick (I mean, this is a typo-based patch anyway). On Friday, May 6, 2016 at 3:35:34 PM UTC+1, Brian Foley wrote: > > As reported in 1177, the option is

Re: [PATCH stable-2.16] Fix broken parameters in storage create methods

Thanks for the quick fix. May I ask you to reference the commit hash of the offending patch in the comment? On Fri, May 6, 2016 at 5:22 PM, 'Federico Morg Pareschi' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > Signed-off-by: Federico Morg Pareschi > --- >

[PATCH stable-2.16] Fix broken parameters in storage create methods

This bug was introduced by commit 38c735d62ae and should be now fixed. Signed-off-by: Federico Morg Pareschi --- lib/storage/bdev.py| 13 +++-- lib/storage/drbd.py| 2 +- lib/storage/extstorage.py | 8 lib/storage/filestorage.py | 4 ++--

Re: Issue 1177 in ganeti: Misnamed option in NEWS file

Updates: Status: Fixed Comment #1 on issue 1177 by bpfo...@google.com: Misnamed option in NEWS file https://code.google.com/p/ganeti/issues/detail?id=1177 Woops. You're quite right. Fixed in http://git.ganeti.org/?p=ganeti.git;a=commit;h=1aa3037c00fe66821512c259f4ec41a6749ef5e4 --

Re: [PATCH stable-2.15] Fix CLI option typo in NEWS file

Fri, May 06, 2016 at 07:44:25AM -0700, 'Federico Pareschi' via ganeti-devel wrote: >Hey Brian, patch seems pretty straightforward, thanks for taking your >time to go through it. >I just have a very minor nitpick (I mean, this is a typo-based patch >anyway). >On Friday, May 6,

Issue 1177 in ganeti: Misnamed option in NEWS file

Status: New Owner: New issue 1177 by bcandler...@googlemail.com: Misnamed option in NEWS file https://code.google.com/p/ganeti/issues/detail?id=1177 In the NEWS file: "- RPC security got enhanced by using different client SSL certificates for each node. In this context 'gnt-cluster

[PATCH stable-2.16] Fix broken parameters in storage create methods

Signed-off-by: Federico Morg Pareschi --- lib/storage/bdev.py| 13 +++-- lib/storage/drbd.py| 2 +- lib/storage/extstorage.py | 8 lib/storage/filestorage.py | 4 ++-- lib/storage/gluster.py | 4 ++-- 5 files changed, 16 insertions(+),

[PATCH stable-2.16] Fix broken parameters in storage create methods

Due to a previous commit, some parameters and function calls were broken. This commit should fix it by moving all the arguments to **kwargs rather than *args (for consistency). Apologies for the inconvenience. Federico Morg Pareschi (1): Fix broken parameters in storage create methods

Re: [PATCH stable-2.16] Don't verify disks when all disk templates are ext

On Thu, May 05, 2016 at 12:41:13PM +0100, 'Federico Morg Pareschi' via ganeti-devel wrote: > Verify disks should not run on clusters or nodegroups with only ext > storage, as it requires an unnecessary amount of locks for its jobs. > This commit performs additional checks when submitting a

[PATCH master] Patch based on Brian's suggestions

Signed-off-by: David Mohr --- lib/storage/bdev.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/storage/bdev.py b/lib/storage/bdev.py index 4892ec2..94ded76 100644 --- a/lib/storage/bdev.py +++ b/lib/storage/bdev.py @@ -887,9 +887,8 @@

Re: [PATCH stable-2.16 2/2] Fix for commit: 7698b603

On Thu, May 05, 2016 at 02:53:30PM +0100, 'Federico Morg Pareschi' via ganeti-devel wrote: > Signed-off-by: Federico Morg Pareschi LGTM! Cheers, Brian. > --- > lib/backend.py | 11 ++- > lib/storage/bdev.py | 11 +++ > 2 files changed, 9 insertions(+), 13

[PATCH stable-2.16 02/10] Remove unused ConfigWriter._CheckUUIDpresent

Last use removed in 608e90eacda when AddInstanceDisk moved to wconfd. Signed-off-by: Brian Foley --- lib/config/__init__.py | 13 - 1 file changed, 13 deletions(-) diff --git a/lib/config/__init__.py b/lib/config/__init__.py index 096b213..85c88ee 100644 ---

[PATCH stable-2.16 06/10] Remove unused jqueue HasJobBeenFinalized

Last use removed when queue processing moved to luxi in 8c749925678. Signed-off-by: Brian Foley --- lib/jqueue/__init__.py | 22 -- 1 file changed, 22 deletions(-) diff --git a/lib/jqueue/__init__.py b/lib/jqueue/__init__.py index 906e37e..d22eac3 100644

[PATCH stable-2.16 05/10] Remove unused jqueue _RemoveEmptyWaitersUnlocked

Became dead code when NotifyWaiters was removed in 3d3a7a9f92e12 Signed-off-by: Brian Foley --- lib/jqueue/__init__.py | 8 1 file changed, 8 deletions(-) diff --git a/lib/jqueue/__init__.py b/lib/jqueue/__init__.py index 7b42e5e..906e37e 100644 ---

[PATCH stable-2.16 01/10] Remove unused SingleFileEventHandler inotify code

Last use removed in 53843e5ca when the job status watching logic moved from jqueue to luxid. Signed-off-by: Brian Foley --- lib/asyncnotifier.py | 66 test/py/ganeti.asyncnotifier_unittest.py | 124 --- 2

[PATCH stable-2.16 08/10] Remove unused filestorage _CheckFileStoragePathExist

This was never used from its introduction in 9c1c3c198cc6a2a2. Signed-off-by: Brian Foley --- lib/storage/filestorage.py | 16 test/py/ganeti.storage.filestorage_unittest.py | 16 2 files changed, 32 deletions(-) diff

[PATCH stable-2.16 09/10] Remove unused uidpool ExecWithUnusedUid

Never used since its introduction in 5833b7e63bb751. Signed-off-by: Brian Foley --- doc/design-2.1.rst | 6 -- lib/uidpool.py | 27 --- 2 files changed, 33 deletions(-) diff --git a/doc/design-2.1.rst b/doc/design-2.1.rst index

[PATCH stable-2.16 04/10] Remove unused jqueue _ResolveJobDependencies

Last use removed when 704b51ff5 removed _SubmitManyJobsUnlocked Signed-off-by: Brian Foley --- lib/jqueue/__init__.py | 31 --- 1 file changed, 31 deletions(-) diff --git a/lib/jqueue/__init__.py b/lib/jqueue/__init__.py index a4c25ba..7b42e5e

[PATCH stable-2.16 03/10] Remove unused jqueue _GetJobIDsUnlocked

Last use removed when AddNode was removed in 779de503275157. Signed-off-by: Brian Foley --- lib/jqueue/__init__.py | 26 -- 1 file changed, 26 deletions(-) diff --git a/lib/jqueue/__init__.py b/lib/jqueue/__init__.py index b4cedb4..a4c25ba 100644 ---

[PATCH stable-2.16 00/10] Remove dead python code

Run the vulture static analysis tool over lib/ and manually inspect and remove some of the unused functions/classes it reported. Most of these come from refactorings and the move of job queue handling to luxid and config management to wconfd. Brian Foley (10): Remove unused

[PATCH stable-2.16 10/10] Remove unused util FirstFree

Last use removed in 9271c98e6fd918. Signed-off-by: Brian Foley --- lib/utils/__init__.py| 28 test/py/ganeti.utils_unittest.py | 16 +--- 2 files changed, 1 insertion(+), 43 deletions(-) diff --git a/lib/utils/__init__.py

[PATCH stable-2.16 07/10] Remove unused noded _DefaultAlternative

Last use removed in aa922d646f3af97b80a. Signed-off-by: Brian Foley --- lib/server/noded.py | 17 - 1 file changed, 17 deletions(-) diff --git a/lib/server/noded.py b/lib/server/noded.py index a5e05dd..4519287 100644 --- a/lib/server/noded.py +++