[Ganglia-developers] RE: [torqueusers] ANNOUNCE: Public release of Ganglia Job Monarch v0.1.0

2006-03-21 Thread Bernard Li
Hey Ramon: In the future, it would be nice to be able to mouse over on the little job boxes (under Joblist) and get some tooltip info regarding details of the job and which node the job is running on. Just a suggestion. Cheers, Bernard > -Original Message- > From: [EMAIL PROTECTED] >

Re: [Ganglia-developers] Possible bug in hosts up calculation when federating clusters.

2006-03-21 Thread Martin Knoblauch
Hi Richard, oops. You are both right and wrong :-) Looking at the code and comments for "old", it seems that the whole logic is pre-3.0. It was used to distinguish between 2.5.x and prior versions. For that purpose the code is right. Of course, it now fails when it encounters the 3.0.X string.

RE: [Ganglia-developers] Possible bug in hosts up calculation when federating clusters.

2006-03-21 Thread Richard.Grevis
Hi, just tested, yup - it works, and you are right, strcmp is required. Thanks. But I still think you need the else to set xmldata->old to 0. If not done, surely this will mean that the variable gets stuck on 1 for subsequent clusters/grids after the first old cluster is encountered. There is no

RE: [Ganglia-developers] Possible bug in hosts up calculation when federating clusters.

2006-03-21 Thread Martin Knoblauch
Richard, OK. After another look at the code I am sure setting "old" to 0 does not hurt. So, what about below one? Martin diff -u -r1.45 process_xml.c --- process_xml.c 18 Nov 2004 20:14:31 - 1.45 +++ process_xml.c 21 Mar 2006 12:46:45 - @@ -821,11 +821,15 @@ i

RE: [Ganglia-developers] Possible bug in hosts up calculation when federating clusters.

2006-03-21 Thread Richard.Grevis
Martin, no doubt you will see matt's mail soon, we are doing a bit of mail tag. The version I already tested had an explicit assignment to 0, because I was pretty sure it was needed. I will happily go with whatever code version you and Matt prefer. In the meantime I am patched and happy. kind re

RE: [Ganglia-developers] Possible bug in hosts up calculation when federating clusters.

2006-03-21 Thread Martin Knoblauch
super. It seems that SF is lagging a bit right now, as I am not seeing my postings there. Added Matt to CC. Cheers Martin --- [EMAIL PROTECTED] wrote: > Martin, > > no doubt you will see matt's mail soon, we are doing a bit of mail > tag. > The version I already tested had an explicit assignm

[Ganglia-developers] Possible bug in hosts up calculation when federating clusters.

2006-03-21 Thread Richard.Grevis
All, when I had debugging turned on in gmetad, the daemon was announcing data sources as old, when they were not. Looking at the code, 3.0.2 or 3.0.3 gmetad/process_xml.c, line 821 or so, function startElement_GANGLIA_XML: if (xt->tag == VERSION_TAG) { /* Pr