Re: [Ganglia-developers] Disk IO as gmond core metric

2009-07-09 Thread JB Kim
Ok I've isolated iostat code into its own module and managed to get the whole autoconf/automake work. http://www.remnantone.com/pkgs/ganglia/modiostat.tar.gz Provided that ganglia 3.1.x is already installed, it should just be a matter of running ./configure & make. Also, here's my attempt at mak

Re: [Ganglia-developers] PATCH: ensure string metrics arenull terminated for python-based user metrics

2009-07-09 Thread Greg Bruno
On Thu, Jul 9, 2009 at 2:59 PM, Rick Cobb wrote: > Why would this be true? gmetric strings that are longer than 32 bytes work > and have for a long time. In the wire encoding, xdr_string encodes a length > followed by a set of octets.  The old (<3.1) protocol.x says that all the > gmond metric stri

Re: [Ganglia-developers] PATCH: ensure string metrics arenull terminated for python-based user metrics

2009-07-09 Thread Rick Cobb
Why would this be true? gmetric strings that are longer than 32 bytes work and have for a long time. In the wire encoding, xdr_string encodes a length followed by a set of octets. The old (<3.1) protocol.x says that all the gmond metric strings are xdr_strings. We use them, e.g., to encode the

Re: [Ganglia-developers] PATCH: ensure string metrics are nullterminated for python-based user metrics

2009-07-09 Thread Greg Bruno
On Thu, Jul 9, 2009 at 12:06 PM, Brad Nicholes wrote: > > Yes, the disk python module under gmond/python_modules/disk adds a 'mount' > extra data to the definition.  Basically in a python module, any extra > properties that you add to the metric definition dictionary will show up as > extra data

Re: [Ganglia-developers] PATCH: ensure string metrics are nullterminated for python-based user metrics

2009-07-09 Thread Brad Nicholes
>>> On 7/9/2009 at 12:16 PM, in message , Greg Bruno wrote: > On Thu, Jul 9, 2009 at 10:52 AM, Brad Nicholes wrote: >> >> One of the new feature in Ganglia 3.1 is the ability to add extra data to > the metric definition that is passed on with the metric metadata. Would > anything like that help

Re: [Ganglia-developers] PATCH: ensure string metrics are nullterminated for python-based user metrics

2009-07-09 Thread Greg Bruno
On Thu, Jul 9, 2009 at 10:52 AM, Brad Nicholes wrote: > > One of the new feature in Ganglia 3.1 is the ability to add extra data to the > metric definition that is passed on with the metric metadata.  Would anything > like that help you? yes, that may help. do you have an example of how add ex

Re: [Ganglia-developers] PATCH: ensure string metrics arenull terminated for python-based user metrics

2009-07-09 Thread Brad Nicholes
>>> On 7/9/2009 at 9:27 AM, in message <4a560c5a.2090...@mail.nih.gov>, Jesse Becker wrote: > Greg Bruno wrote: >> also, regarding MAX_G_STRING_SIZE, would it be possible to increase it >> in future releases? i've currently set it to 128 in >> include/gm_value.h. > > I don't object, although I'm

Re: [Ganglia-developers] PATCH: ensure string metrics are nullterminated for python-based user metrics

2009-07-09 Thread Brad Nicholes
>>> On 7/9/2009 at 10:03 AM, in message , Greg Bruno wrote: > On Thu, Jul 9, 2009 at 8:27 AM, Jesse Becker wrote: >> >>> also, regarding MAX_G_STRING_SIZE, would it be possible to increase it >>> in future releases? i've currently set it to 128 in >>> include/gm_value.h. >> >> I don't object, alth

Re: [Ganglia-developers] PATCH: ensure string metrics are null terminated for python-based user metrics

2009-07-09 Thread Greg Bruno
On Thu, Jul 9, 2009 at 8:27 AM, Jesse Becker wrote: > >> also, regarding MAX_G_STRING_SIZE, would it be possible to increase it >> in future releases? i've currently set it to 128 in >> include/gm_value.h. > > I don't object, although I'm not the most familiar with this part of the > code.  I'm cur

Re: [Ganglia-developers] PATCH: ensure string metrics are null terminated for python-based user metrics

2009-07-09 Thread Jesse Becker
Greg Bruno wrote: > for ganglia v3.1.2, the patch below ensures that all 'string' metrics > are null terminated for python-based user metrics. without this patch, > any string metric that is longer than MAX_G_STRING_SIZE (currently 32 > bytes), will not be null terminated and will corrupt the value