On Mon, Dec 28, 2009 at 01:22:47PM +0100, Sebastien Termeau wrote: > > > > On Wed, Dec 16, 2009 at 1:18 PM, Carlo Marcelo Arenas Belon < > > care...@sajinet.com.pe> wrote: > > > >> On Tue, Dec 15, 2009 at 02:32:07PM +0100, Sebastien Termeau wrote: > >> > Dear Ganglia Developers, > >> > > >> > Please find below a patch that brings trends to Ganglia. > >> > >> Really interesting, would you mind filing and enhancement bug on > >> www.ganglia.info?, that would be also a great place for attaching > >> those images you said were also needed. > > Just to inform you that I have submitted 2 enhancement requests:
would assume you wanted them eventually included as part of some 3.1 release? (most likely 3.1.7), if so would be better to adjust the target. > http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=249 committed in r2161, but as explained in bugzilla the use of <TR></TR> is invalid HTML4, and so unless we rely on browsers doing the right thing (which seems to happen at least on Firefox 3.5) it will need to be "patched" to do something a little more complicated or as ugly as the following hack (which again will rely on browsers doing the "Right Thing (tm)" while rendering) : --- web/templates/default/host_view.tpl 2009-12-29 02:30:30.000000000 -0800 +++ web/templates/default/host_view.tpl 2009-12-29 02:56:05.000000000 -0800 @@ -129,7 +129,7 @@ </A></TD> {new_row} <!-- END BLOCK : vol_metric_info --> -</TR> +<TD></TD></TR> </TABLE> </DIV> <!-- END BLOCK : vol_group_info --> > http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=250 patch provided is broken as shown by : patch: **** malformed patch at line 104: diff -ur ganglia_trunk_tables/host_view.php ganglia/host_view.php but after massaging slightly I am still having the following comments : * with_trends should be a bool instead (true/false) * probably to avoid surprises it should be "false" in 3.1 when backported * the same "TR" abuse issue from BUG249 applies here * the use of magic constants for the prediction trends should be explained to allow for customization or not made configurable at all. * the hardcoded "double the currently selected range" should be made flexible somehow or at least explained in the graph to avoid surprises. * I am using rrdtool 1.3.8 so I only got "projection" but the use of the icons for it seemed strange and not particularly good looking looking forward for a newer version that could be more broadly tested though as the feature is definitely interesting. Carlo ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
