Sounds great. Thanks for the feedback!
alex
On Feb 25, 2011, at 2:26 PM, Vladimir Vuksan wrote:
>
> I see what you are saying. Sounds like a good plan. If you want to rename
> all $GLOBALS to $conf and user input to $user that would be cool :-).
--
I see what you are saying. Sounds like a good plan. If you want to rename
all $GLOBALS to $conf and user input to $user that would be cool :-).
On Fri, 25 Feb 2011 14:04:20 -0600, Alex Dean wrote:
> Hi!
>
> I want the code to be clearer about which values are from configuration,
> which are fro
Hi!
I want the code to be clearer about which values are from configuration, which
are from user input, and which are just local variables. Using $GLOBALS on
it's own doesn't really address that concern. You could use something like
$GLOBALS['conf']['ganglia_dir'], but it seems unnecessarily
Alex,
I have been using the $GLOBALS array for global configuration options. I
would recommend using that instead of $conf
http://sourceforge.net/apps/trac/ganglia/browser/branches/monitor-web-2.0/conf.php.in?rev=2489#L8
Thanks,
Vladimir
On Fri, 25 Feb 2011 09:51:17 -0600, Alex Dean wrote:
>
I created http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=299.
Added the conf-conversion script & patches for eval_config.php and graph.php.
I'll continue to convert other scripts as time allows.
alex
On Feb 24, 2011, at 10:05 PM, Alex Dean wrote:
> I wrote a script to read in
I wrote a script to read in a conf.php file and convert it to use a $conf
array. I don't think we have a place for utility scripts like this right now.
Where should it go?
https://github.com/alexdean/ganglia-stuff/blob/master/reformat_conf.php
After you use this tool, but before all code i
+1 to that too
On Wed, Feb 23, 2011 at 23:49, Bernard Li wrote:
> +1 from me as well.
>
> I guess we should probably check it into both monitor-web-2.0 and trunk.
>
> Cheers,
>
> Bernard
>
> On Wed, Feb 23, 2011 at 7:35 PM, Jesse Becker wrote:
>> +1
>>
>> On Wed, Feb 23, 2011 at 21:27, Alex Dean
+1 from me as well.
I guess we should probably check it into both monitor-web-2.0 and trunk.
Cheers,
Bernard
On Wed, Feb 23, 2011 at 7:35 PM, Jesse Becker wrote:
> +1
>
> On Wed, Feb 23, 2011 at 21:27, Alex Dean wrote:
>> One of my gripes with the current PHP frontend code is how hard it can
+1
On Wed, Feb 23, 2011 at 21:27, Alex Dean wrote:
> One of my gripes with the current PHP frontend code is how hard it can be to
> recall where which variables are configuration, which come from user input,
> and which are just local variables. As one step toward fixing this issue, I
> think
One of my gripes with the current PHP frontend code is how hard it can be to
recall where which variables are configuration, which come from user input, and
which are just local variables. As one step toward fixing this issue, I think
it would be nice to place all configuration values (mainly i
10 matches
Mail list logo
