Re: [Ganglia-developers] [PATCH] isblank is undefined without ISOC99

2009-02-23 Thread Jesse Becker
On Mon, Feb 23, 2009 at 01:11, Carlo Marcelo Arenas Belon wrote: > On Sat, Feb 21, 2009 at 07:40:44PM -0500, Jesse Becker wrote: >> committed to trunk. r1967 > > AFAIK trunk wasn't affected as it was fixed in r1951. as reported 3.1 is > affected but just because the fix was never backported. > >

Re: [Ganglia-developers] [PATCH] isblank is undefined without ISOC99

2009-02-22 Thread Carlo Marcelo Arenas Belon
On Sat, Feb 21, 2009 at 03:54:46PM -0500, Justin Bronder wrote: > I get the following warning when compiling 3.1.1 and 3.1.2. 3.0 has also the same problem but warnings (-Wall) weren't enabled when compiling libmetrics hence the message wasn't visible by default. > Following the way > that __USE_

Re: [Ganglia-developers] [PATCH] isblank is undefined without ISOC99

2009-02-22 Thread Carlo Marcelo Arenas Belon
On Sat, Feb 21, 2009 at 07:40:44PM -0500, Jesse Becker wrote: > committed to trunk. r1967 AFAIK trunk wasn't affected as it was fixed in r1951. as reported 3.1 is affected but just because the fix was never backported. r1967 shouldn't be needed and should be reverted IMHO. Carlo -

Re: [Ganglia-developers] [PATCH] isblank is undefined without ISOC99

2009-02-21 Thread Jesse Becker
committed to trunk. r1967 On Sat, Feb 21, 2009 at 15:54, Justin Bronder wrote: > I get the following warning when compiling 3.1.1 and 3.1.2. Following the way > that __USE_GNU is defined in libmetrics/linux/metrics.c, the attached patch > removes this warning. > > if /bin/sh ../libtool --tag=CC

[Ganglia-developers] [PATCH] isblank is undefined without ISOC99

2009-02-21 Thread Justin Bronder
I get the following warning when compiling 3.1.1 and 3.1.2. Following the way that __USE_GNU is defined in libmetrics/linux/metrics.c, the attached patch removes this warning. if /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../../lib -I../../include -march=noc