I finally upgraded the FreeBSD port last week and bumped into the extra library dependencies in newer versions. On some user machines I had trouble figuring out what went wrong because they were getting to the build stage without a Makefile. The FreeBSD ports infrastructure should have prevented that because configure had failed. The problem is that configure had simply run "exit" so it appeared to be successful, but had not generated a Makefile.
The following untested patch should fix this issue. I'm happy to commit
it but I'd like a head nod that's acceptable before I do.
In reality most of the code I'm touching here should die. The ganglia
configure.in contains way too much hard-coded magic.
-- Brooks
Index: configure.in
===================================================================
--- configure.in (revision 2603)
+++ configure.in (working copy)
@@ -296,7 +296,7 @@
echo "monitoring core with gmetad but librrd could not be found.
Please"
echo "visit http://www.rrdtool.org/, download rrdtool and then try
again"
echo
- exit;
+ exit 1
fi
fi
fi
@@ -389,7 +389,7 @@
echo "Found a suitable libapr1 library"
else
echo "libapr not found"
- exit;
+ exit 1
fi
echo
@@ -413,7 +413,7 @@
AC_CHECK_LIB(confuse, cfg_parse)
if test x"$ac_cv_lib_confuse_cfg_parse" = xno; then
echo "libconfuse not found"
- exit
+ exit 1
fi
fi
fi
@@ -434,7 +434,7 @@
echo "Found a suitable Expat library"
else
echo "libexpat not found"
- exit;
+ exit 1
fi
echo
@@ -452,7 +452,7 @@
echo "Found a suitable pcre library"
else
echo "libpcre not found, specify --with-libpcre=no to build without PCRE
support"
- exit;
+ exit 1
fi
else
echo "building without PCRE support"
@@ -474,7 +474,7 @@
dnl if test "$ac_cv_lib_crypto_RSA_sign" = no; then
dnl echo "$PACKAGE $VERSION requires IPv4 OpenSSL."
dnl echo "See http://www.openssl.org/.";
-dnl exit;
+dnl exit 1
dnl fi
dnl ##################################################################
pgpcfBkW9t9GN.pgp
Description: PGP signature
------------------------------------------------------------------------------ vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
