Re: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068)

2011-05-05 Thread Jason Merrill
On 05/05/2011 05:33 PM, ccout...@google.com wrote: I couldn't convince myself that a subprogram definition inside a type declaration would never happen, so I took the defensive approach. If you're confident that it can't (or shouldn't) ever happen, then what if I leave the predicate

Re: [pph] Save keyed_classes, unemitted_tinfo_decls, TYPE_BINFO (issue4486042)

2011-05-05 Thread dnovillo
http://codereview.appspot.com/4486042/diff/1/gcc/cp/pph-streamer.h File gcc/cp/pph-streamer.h (right): http://codereview.appspot.com/4486042/diff/1/gcc/cp/pph-streamer.h#newcode152 gcc/cp/pph-streamer.h:152: for (i = 0; i c; ++i) +#if 0 +static inline void +pph_output_tree_array (pph_stream

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Meissner
On Thu, May 05, 2011 at 03:08:43PM -0400, Michael Meissner wrote: Yes, it was an error on my part. Sorry. I will fix the GCC 4.6 branch. I will hold off fixing the on trunk, on the assumption this patch will go in. I can fix it if desired. I committed the following patch on the GCC 4.6

Re: [PATCH] Fix PR c++/48838

2011-05-05 Thread Dodji Seketeli
Jason Merrill ja...@redhat.com writes: On 05/05/2011 03:52 PM, Dodji Seketeli wrote: + if (is_overloaded_fn (fn)) +fn = get_first_fn (fn); + else if (BASELINK_P (fn)) is_overloaded_fn should be true for a BASELINK. Correct. I should have seen that. I have bootstrapped the patch

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Alan Modra
On Thu, May 05, 2011 at 11:29:13AM -0400, David Edelsohn wrote: Alan, is mcmodel suppose to set m64? No, that was an accident. -- Alan Modra Australia Development Lab, IBM

[PATCH] Fix PR c++/48574

2011-05-05 Thread Dodji Seketeli
Hello, This is a leftover of the fix for PR c++/48574. When fold_non_dependent_expr sees the lvalue reference 'b' in the example of the patch below (because in finish_call_expr, make_args_non_dependent on 'b' calls build_non_dependent_expr which calls null_ptr_cst_p which calls

Re: [PATCH] Fix PR c++/48838

2011-05-05 Thread Jason Merrill
OK. Jason

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread David Edelsohn
On Thu, May 5, 2011 at 3:34 PM, Joseph S. Myers jos...@codesourcery.com wrote: On Thu, 5 May 2011, Michael Eager wrote: David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers jos...@codesourcery.com wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to

Re: [PATCH, powerpc], Fix PR48857, pass/return V2DI as other vector types

2011-05-05 Thread David Edelsohn
On Tue, May 3, 2011 at 5:27 PM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: When I added VSX support to the powerpc, I overlooked passing and return V2DImode arguments, since the only machine operation that supports V2DI is vector floating point conversion.  Consequentally, V2DI types

Re: [PATCH] Fix PR c++/48574

2011-05-05 Thread Jason Merrill
How about type_dependent_expression_p_push instead? Jason

[patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068) (issue4433068)

2011-05-05 Thread Cary Coutant
commit bf6ab23aad749d927108ace21ee01a94af31a38b Author: Cary Coutant ccout...@google.com Date: Mon Apr 25 13:54:19 2011 -0700 Check for classes that contain defining declarations of subprograms, and do not move such classes into a comdat type unit. I've updated the patch to assert

Fix PR48900, powerpc duplicate __tls_get_addr calls

2011-05-05 Thread Alan Modra
My fix for PR44266 using the libcall machinery to ensure we had a proper stack frame allocated for __tls_get_addr calls sloppily used r3 as the arg to the dummy libcall. This made the call seem to depend on whatever was in r3 previously, at least until we get to the first split pass and the real

<    1   2   3