Re: Proposal to add FDO profile quality related diagnostics

2018-11-20 Thread Andi Kleen
Indu Bhagat writes: > Proposal to add diagnostics to know which functions were not run in the > training run in FDO. Don't you think the warning will be very noisy? I assume most programs have a lot of cold error handling functions etc. that are never executed in a normal execution. Like how do

Re: Not quoted option names in errors and warnings

2018-11-20 Thread Martin Sebor
On 11/20/2018 12:54 PM, Martin Liška wrote: On 11/20/18 4:24 PM, Martin Sebor wrote: On 11/20/2018 03:10 AM, Martin Liška wrote: On 11/15/18 5:54 PM, Martin Sebor wrote: On 11/15/2018 03:12 AM, Martin Liška wrote: Hi. I've done a quick grep of gcc/po/gcc.pot and I see quite a lot of missing

Re: Question about make_extraction() in combine.c

2018-11-20 Thread Jeff Law
On 11/20/18 11:07 AM, Michael Eager wrote: > On 11/18/2018 08:14 AM, Jeff Law wrote: >> On 11/18/18 8:44 AM, Michael Eager wrote: >>> On 11/16/18 14:50, Segher Boessenkool wrote: Hi! On Wed, Nov 14, 2018 at 11:22:58AM -0800, Michael Eager wrote: > The (mem:SI) is converted to (me

Proposal to add FDO profile quality related diagnostics

2018-11-20 Thread Indu Bhagat
Proposal to add diagnostics to know which functions were not run in the training run in FDO. Motivation : When using FDO, it is often desirable to know the quality of function profile. This means knowing which functions have STALE, NO/MISSING or ZERO profiles. GCC has diagnostics for STALE (Wcove

Re: Not quoted option names in errors and warnings

2018-11-20 Thread Martin Liška
On 11/20/18 4:24 PM, Martin Sebor wrote: On 11/20/2018 03:10 AM, Martin Liška wrote: On 11/15/18 5:54 PM, Martin Sebor wrote: On 11/15/2018 03:12 AM, Martin Liška wrote: Hi. I've done a quick grep of gcc/po/gcc.pot and I see quite a lot of missing quotations of option names (~400). Is it som

Re: Question about make_extraction() in combine.c

2018-11-20 Thread Michael Eager
On 11/18/2018 08:14 AM, Jeff Law wrote: On 11/18/18 8:44 AM, Michael Eager wrote: On 11/16/18 14:50, Segher Boessenkool wrote: Hi! On Wed, Nov 14, 2018 at 11:22:58AM -0800, Michael Eager wrote: The (mem:SI) is converted to (mem:QI). The return from make_extract() is     (zero_extract:SI (me

Re: Not quoted option names in errors and warnings

2018-11-20 Thread Martin Sebor
On 11/20/2018 03:10 AM, Martin Liška wrote: On 11/15/18 5:54 PM, Martin Sebor wrote: On 11/15/2018 03:12 AM, Martin Liška wrote: Hi. I've done a quick grep of gcc/po/gcc.pot and I see quite a lot of missing quotations of option names (~400). Is it something we should fix? How important is tha

Re: Not quoted option names in errors and warnings

2018-11-20 Thread Martin Liška
On 11/15/18 5:54 PM, Martin Sebor wrote: > On 11/15/2018 03:12 AM, Martin Liška wrote: >> Hi. >> >> I've done a quick grep of gcc/po/gcc.pot and I see quite a lot of missing >> quotations >> of option names (~400). Is it something we should fix? How important is that? > > That's quite a few... I'