Re: Some questions on hash_set/hash_map traits

2021-09-09 Thread Richard Biener via Gcc
On Wed, Sep 8, 2021 at 10:50 PM Erick Ochoa via Gcc wrote: > > Hello, > > I am refactoring some old code that runs as an IPA_PASS. This code is > intended to run at link-time using the LTO framework and so I am > always testing it that way. At the moment, I am trying to use > hash-maps but having

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Aldy Hernandez via Gcc
On 9/9/21 8:57 AM, Richard Biener wrote: On Wed, Sep 8, 2021 at 8:13 PM Michael Matz wrote: Hello, [lame answer to self] On Wed, 8 Sep 2021, Michael Matz wrote: The forward threader guards against this by simply disallowing threadings that involve different loops. As I see The thread

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Richard Biener via Gcc
On Thu, Sep 9, 2021 at 9:37 AM Aldy Hernandez wrote: > > > > On 9/9/21 8:57 AM, Richard Biener wrote: > > On Wed, Sep 8, 2021 at 8:13 PM Michael Matz wrote: > >> > >> Hello, > >> > >> [lame answer to self] > >> > >> On Wed, 8 Sep 2021, Michael Matz wrote: > >> > > The forward threader guards

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Aldy Hernandez via Gcc
On 9/8/21 8:13 PM, Michael Matz wrote: Hello, [lame answer to self] On Wed, 8 Sep 2021, Michael Matz wrote: The forward threader guards against this by simply disallowing threadings that involve different loops. As I see The thread in question (5->9->3) is all within the same outer loop

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Richard Biener via Gcc
On Thu, Sep 9, 2021 at 10:14 AM Aldy Hernandez wrote: > > > > On 9/8/21 8:13 PM, Michael Matz wrote: > > Hello, > > > > [lame answer to self] > > > > On Wed, 8 Sep 2021, Michael Matz wrote: > > > The forward threader guards against this by simply disallowing > threadings that involve dif

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Aldy Hernandez via Gcc
On 9/9/21 9:45 AM, Richard Biener wrote: On Thu, Sep 9, 2021 at 9:37 AM Aldy Hernandez wrote: On 9/9/21 8:57 AM, Richard Biener wrote: On Wed, Sep 8, 2021 at 8:13 PM Michael Matz wrote: Hello, [lame answer to self] On Wed, 8 Sep 2021, Michael Matz wrote: The forward threader guard

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Richard Biener via Gcc
On Thu, Sep 9, 2021 at 10:36 AM Aldy Hernandez wrote: > > > > On 9/9/21 9:45 AM, Richard Biener wrote: > > On Thu, Sep 9, 2021 at 9:37 AM Aldy Hernandez wrote: > >> > >> > >> > >> On 9/9/21 8:57 AM, Richard Biener wrote: > >>> On Wed, Sep 8, 2021 at 8:13 PM Michael Matz wrote: > > Hell

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Aldy Hernandez via Gcc
On 9/9/21 10:58 AM, Richard Biener wrote: On Thu, Sep 9, 2021 at 10:36 AM Aldy Hernandez wrote: On 9/9/21 9:45 AM, Richard Biener wrote: On Thu, Sep 9, 2021 at 9:37 AM Aldy Hernandez wrote: On 9/9/21 8:57 AM, Richard Biener wrote: On Wed, Sep 8, 2021 at 8:13 PM Michael Matz wrote:

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Richard Biener via Gcc
On Thu, Sep 9, 2021 at 11:21 AM Aldy Hernandez wrote: > > > > On 9/9/21 10:58 AM, Richard Biener wrote: > > On Thu, Sep 9, 2021 at 10:36 AM Aldy Hernandez wrote: > >> > >> > >> > >> On 9/9/21 9:45 AM, Richard Biener wrote: > >>> On Thu, Sep 9, 2021 at 9:37 AM Aldy Hernandez wrote: > >

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Aldy Hernandez via Gcc
On 9/9/21 12:15 PM, Richard Biener wrote: On Thu, Sep 9, 2021 at 11:21 AM Aldy Hernandez wrote: On 9/9/21 10:58 AM, Richard Biener wrote: I ran some experiments a while back, and my current work on the enhanced solver/threader, can fold virtually everything the DOM/threader gets (even wit

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Michael Matz via Gcc
Hello, On Thu, 9 Sep 2021, Richard Biener wrote: > > I believe something like below would be appropriate, it disables > > threading if the path contains a latch at the non-last position (due > > to being backwards on the non-first position in the array). I.e. it > > disables rotating the loop

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Michael Matz via Gcc
Hello, On Thu, 9 Sep 2021, Aldy Hernandez wrote: > The ldist-22 regression is interesting though: > > void foo () > { > int i; > >: > goto ; [INV] > >: > a[i_1] = 0; > if (i_1 > 100) > goto ; [INV] > else > goto ; [INV] > >: > b[i_1] = i_1; > >: > i_8 =

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Aldy Hernandez via Gcc
On 9/9/21 2:52 PM, Michael Matz wrote: Hello, On Thu, 9 Sep 2021, Aldy Hernandez wrote: The ldist-22 regression is interesting though: void foo () { int i; : goto ; [INV] : a[i_1] = 0; if (i_1 > 100) goto ; [INV] else goto ; [INV] : b[i_1] = i_1;

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Michael Matz via Gcc
Hello, On Thu, 9 Sep 2021, Aldy Hernandez wrote: > > Here there's no simple latch block to start with (the backedge comes > > directly out of the loop exit block). So my suggested improvement > > (testing if the latch was empty and only then reject the thread), would > > solve this. > > Well, t

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Aldy Hernandez via Gcc
On 9/9/21 4:44 PM, Michael Matz wrote: Hello, On Thu, 9 Sep 2021, Aldy Hernandez wrote: Here there's no simple latch block to start with (the backedge comes directly out of the loop exit block). So my suggested improvement (testing if the latch was empty and only then reject the thread), w

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Jeff Law via Gcc
On 9/9/2021 2:14 AM, Aldy Hernandez wrote: On 9/8/21 8:13 PM, Michael Matz wrote: Hello, [lame answer to self] On Wed, 8 Sep 2021, Michael Matz wrote: The forward threader guards against this by simply disallowing threadings that involve different loops.  As I see The thread in questi

Re: More aggressive threading causing loop-interchange-9.c regression

2021-09-09 Thread Jeff Law via Gcc
On 9/9/2021 2:58 AM, Richard Biener wrote: On Thu, Sep 9, 2021 at 10:36 AM Aldy Hernandez wrote: On 9/9/21 9:45 AM, Richard Biener wrote: On Thu, Sep 9, 2021 at 9:37 AM Aldy Hernandez wrote: On 9/9/21 8:57 AM, Richard Biener wrote: On Wed, Sep 8, 2021 at 8:13 PM Michael Matz wrote:

gcc-9-20210909 is now available

2021-09-09 Thread GCC Administrator via Gcc
Snapshot gcc-9-20210909 is now available on https://gcc.gnu.org/pub/gcc/snapshots/9-20210909/ and on various mirrors, see http://gcc.gnu.org/mirrors.html for details. This snapshot has been generated from the GCC 9 git branch with the following options: git://gcc.gnu.org/git/gcc.git branch