Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros

2008-02-28 Thread David Rientjes
On Thu, 28 Feb 2008, Jan Hubicka wrote: > > -static inline void __attribute__((format(printf, 1, 2))) > > -__simple_attr_check_format(const char *fmt, ...) > > It would be nice to have a testcase, but I guess it is because GCC can't > inline variadic functions. The function gets identified as c

Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros

2008-02-27 Thread David Rientjes
On Tue, 26 Feb 2008, Joe Perches wrote: > > Joe, what version of gcc are you using? > > $ gcc --version > gcc (GCC) 4.2.2 20071128 (prerelease) (4.2.2-3.1mdv2008.0) > > It's definitely odd. > The .o size changes are inconsistent. > Some get bigger, some get smaller. > > The versioning ones I un

Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros

2008-02-26 Thread David Rientjes
On Tue, 26 Feb 2008, Joe Perches wrote: > > I'm not seeing any change in text size with allyesconfig after applying > > this patch with latest git: > > This is just x86 defconfig > allyesconfig should be able to capture any text savings that this patch offers. > > Joe, what version of gcc ar

Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros

2008-02-26 Thread David Rientjes
On Tue, 26 Feb 2008, Matthew Wilcox wrote: > On Tue, Feb 26, 2008 at 08:02:27PM -0800, Joe Perches wrote: > > Converting inline __attribute__((format (printf,x,y) functions > > to macros or statement expressions produces smaller objects > > > > before: > > $ size vmlinux > >textdata b