Re: [PATCH][RFA][PR target/84128] Fix restore of scratch register used in probing loops

2018-01-31 Thread Eric Botcazou
Probably not on Linux indeed. But, since you modified the non-Linux path, you need to avoid repeating the same mistake and test on non-Linux native too. -- Eric Botcazou

Re: Fix gnat.dg/lto20.adb XPASS

2018-01-31 Thread Eric Botcazou
thing to do. > Tested with the appropriate runtest invocation on > sparc-sun-solaris2.11. Ok for mainline? Yes, thanks. -- Eric Botcazou

Re: Fix LRA subreg calculation for big-endian targets

2018-01-30 Thread Eric Botcazou
> OK. Makes me wonder how many big endian LRA targets are getting significant > use. Debian still has an active SPARC64 port now based on GCC 7 with LRA. -- Eric Botcazou

Re: [wwwdocs] GCC-7.3 changes: Add note about LEON3FT erratum workaround

2018-01-30 Thread Eric Botcazou
> I would like to commit the following comment about LEON3-FT errata now > available in GCC-7.3. Fine with me, thanks. -- Eric Botcazou

Fix PR rtl-optimization/81443

2018-01-23 Thread Eric Botcazou
, Richard B. agreed to have it fixed on the 7 branch by reverting the problematic bits from the PR rtl-optimization/59461 patch that introduced it. Manually tested on mips64-unknown-linux-gnu, applied on the 7 branch. 2018-01-23 Eric Botcazou <ebotca...@adacore.com> PR rtl-optimi

Re: Status of m32c target?

2018-01-23 Thread Eric Botcazou
O starting from scratch is a bad idea. > But writing a backend is too much for a GSoC, even a small one. Definitely, and doing a CC0 conversion is probably an upper bound. -- Eric Botcazou

Re: Status of m32c target?

2018-01-19 Thread Eric Botcazou
ads (assuming some AVR processors are pipelined), in which case CCmode will give you a performance bonus. -- Eric Botcazou

[testsuite] Tweak gcc.dg/ipa/inlinehint-4.c

2018-01-17 Thread Eric Botcazou
2018-01-17 Eric Botcazou <ebotca...@adacore.com> * gcc.dg/ipa/inlinehint-4.c: Also pass --param inline-unit-growth=20. -- Eric BotcazouIndex: gcc.dg/ipa/inlinehint-4.c === --- gcc.dg/ipa/inlinehint-4.c (revis

[patch] Fix PR tree-optimization/81184

2018-01-17 Thread Eric Botcazou
Hi, as suggested by Jakub in the audit trail, this simply adjusts the dg-final line according to whether it's for a logical_op_short_circuit target or not. Tested on visium-elf and x86_64-suse-linux, OK for the mainline? 2018-01-17 Eric Botcazou <ebotca...@adacore.com> P

Re: [testsuite] Tweak Wrestrict.c

2018-01-17 Thread Eric Botcazou
> There should be just one warning per call, and (as it is) -Wrestrict > should suppress -Wstringop-overflow. This suppression was a recent > change (r256683). Sorry, the changes indeed crossed, I'm going to revert mine. -- Eric Botcazou

Fix Warray-bounds-3.c on Visium

2018-01-16 Thread Eric Botcazou
se, because the offset of the field is then counted twice in refoff since it is already comprised in const_off. In the end, the correct thing to do is just to equate refoff and const_off. Tested on visium-elf & x86_64-suse-linux, applied on the mainline as obvious. 2018-01-16 Eric Bo

[testsuite] Tweak Wrestrict.c

2018-01-16 Thread Eric Botcazou
so that this call to memcpy is preserved on the other platforms too (by adding one character to the string) and adds the additional dg-warning directive. Tested on visium-elf & x86_64-suse-linux, applied on the mainline as obvious. 2018-01-16 Eric Botcazou <ebotca...@adac

[testsuite] XFAIL Warray-bounds-4.c on SPARC and Visium

2018-01-16 Thread Eric Botcazou
On these platforms, one of the instances of the constructor generated in test_strcpy_bounds_memarray_range is put into the constant pool so the strlen pass cannot do its magic. Tested on visium-elf, SPARC64 and x86-64/Linux, applied on the mainline. 2018-01-16 Eric Botcazou <ebo

[testsuite] Tweak patchable function tests

2018-01-16 Thread Eric Botcazou
On Visium, the compiler sometimes emits a NOP to avoid a pipeline hazard. Tested on visium-elf and x86_64-suse-linux, applied on the mainline. 2018-01-16 Eric Botcazou <ebotca...@adacore.com> * c-c++-common/patchable_function_entry-decl.c: Use 3 NOPs on Visium. * c-c++-

[testsuite] Skip loop tests on Visium

2018-01-16 Thread Eric Botcazou
They either use too much space in the data segment or on the stack. Tested on visium-elf, applied on the mainline. 2018-01-16 Eric Botcazou <ebotca...@adacore.com> * gcc.dg/tree-ssa/ldist-27.c: Skip on Visium. * gcc.dg/tree-ssa/loop-interchange-1.c: Likewise. *

[visium] Very minor tweak

2018-01-16 Thread Eric Botcazou
Tested on visium-elf, applied on the mainline. 2018-01-16 Eric Botcazou <ebotca...@adacore.com> * config/visium/visium.md (nop): Tweak comment. (hazard_nop): Likewise. -- Eric BotcazouIndex: config/visium/vis

Fix PR testsuite/77734 on SPARC

2018-01-16 Thread Eric Botcazou
We need to enable delayed-branch scheduling to have sibling calls on SPARC. Tested on SPARC64/Linux, applied on the mainline and 7 branch. 2018-01-16 Eric Botcazou <ebotca...@adacore.com> PR testsuite/77734 * gcc.dg/plugin/must-tail-call-1.c: Pass -fdelayed-branch on

[libstdc++] Fix 17_intro/names.cc on SPARC/Linux

2018-01-16 Thread Eric Botcazou
The SPARC-V8 architecture contains a Y register so defines a structure with a 'y' field on Linux. Tested on SPARC64/Linux, applied on the mainline and 7 branch as obvious. 2018-01-16 Eric Botcazou <ebotca...@adacore.com> * testsuite/17_intro/names.cc: Undefine 'y' on SPARC

Re: VIEW_CONVERT_EXPR slots for strict-align targets (PR 83884)

2018-01-16 Thread Eric Botcazou
nner_type to determine the stack slot size > when handling VIEW_CONVERT_EXPRs on strict-alignment targets. This looks good to me, thanks for fixing the problem. Unexpectedly enough, I don't see the failures on SPARC (32-bit or 64-bit). -- Eric Botcazou

Re: Patch ping (Re: [PATCH] Small regrename improvement)

2018-01-12 Thread Eric Botcazou
created gen_raw_REG. > > I'd like to ping this patch (for some reason it didn't make it into > gcc-patches archive). I apparently didn't get it either. The patch is OK, thanks. -- Eric Botcazou

Fix PR target/83368

2018-01-12 Thread Eric Botcazou
. There is a note in the SCD about this quirk of setjmp so we must probably live with it. Tested on SPARC64/Linux and SPARC/Solaris, applied on the mainline. 2018-01-12 Eric Botcazou <ebotca...@adacore.com> PR target/83368 * config/sparc/sparc.h (PIC_OFFSET_TABLE_REGNUM

Fix PR rtl-optimization/83565

2018-01-12 Thread Eric Botcazou
on mainline and 7 branch. 2018-01-12 Eric Botcazou <ebotca...@adacore.com> PR rtl-optimization/83565 * rtlanal.c (nonzero_bits1): On WORD_REGISTER_OPERATIONS machines, do not extend the result to a larger mode for rotate operations. (num_sign_bit_copies1): Li

[Ada] Fix ICE on Component_Size clause with atomic type

2018-01-10 Thread Eric Botcazou
on the mainline. 2018-01-10 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/decl.c (gnat_to_gnu_component_type): Apply the check for atomic access once the component size is taken into account and also do it if the component type is Atomic or Volatile_Full_Access. 2

Fix couple of -fdump-ada-spec issues on preprocessor macros

2018-01-10 Thread Eric Botcazou
The -fdump-ada-spec currently generates invalid Ada for preprocessor macros containing floating-point constants and string concatenations. Tested on x86-64/Linux, applied on the mainline. 2018-01-10 Eric Botcazou <ebotca...@adacore.com> c-family/ * c-ada-spec.c (dump_number

Fix buglet in dwarf2out_var_location

2018-01-10 Thread Eric Botcazou
for excess errors) -UNRESOLVED: gcc.dg/debug/dwarf2/pr43237.c scan-assembler-not LLST[^r\\\ \n]*DW_AT_upper_bound Tested on SPARC/Solaris and x86-64/Linux, applied on the mainline as obvious. 2018-01-10 Eric Botcazou <ebotca...@adacore.com> * dwarf2out.c (dwarf2out_var_locatio

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-10 Thread Eric Botcazou
f-backed RTL framework. -- Eric Botcazou

Re: Build Ada compiler for nios2?

2018-01-04 Thread Eric Botcazou
> This HOST_WIDE_INT is defined in gcc/hwint.h. Who is supposed to include > this file? Is this done via an #include or via a tm_file (gcc/config.gcc)? Nobody I'd say, the declaration shouldn't be compiled for the target. -- Eric Botcazou

Re: Dropping ChangeLogs

2017-12-22 Thread Eric Botcazou
e git has specific counter-measures against them, but that's useful at least with Subversion. -- Eric Botcazou

[Ada] Fix PR ada/83535

2017-12-21 Thread Eric Botcazou
This is a regression recently introduced on the mainline: the compiler doesn't use the specified size to access an atomic variable with an address clause. Tested on x86_64-suse-linux, applied on the mainline. 2017-12-21 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/

[patch] Fix PR C++/82872

2017-12-21 Thread Eric Botcazou
Botcazou <ebotca...@adacore.com> PR C++/82872 * convert.c (convert_to_integer_1) : Do not return the shared zero if the input has overflowed. 2017-12-21 Eric Botcazou <ebotca...@adacore.com> * c-c++-common/pr82872.c: New test. -- Eric Botcazou/*

Re: [C++] Add support for #pragma GCC unroll v4

2017-12-20 Thread Eric Botcazou
Tested on x86_64-suse-linux, OK for the mainline? 2017-12-20 Mike Stump <mikest...@comcast.net> Eric Botcazou <ebotca...@adacore.com> cp/ * constexpr.c (cxx_eval_constant_expression) : Remove assertion on 2nd operand. (potential_constant_expre

Re: [PATCH] Replace Yoda conditions in gcc/

2017-12-20 Thread Eric Botcazou
OK, let's go for IN_RANGE then, but it's Yoda style on steroids! -- Eric Botcazou

Re: [PATCH] Replace Yoda conditions in gcc/

2017-12-20 Thread Eric Botcazou
as fast as reading (x > a && x < b). And IN_RANGE is too ambiguous wrt the bounds. -- Eric Botcazou

[patch] More robust fix for PR target/66488

2017-12-15 Thread Eric Botcazou
patch replaces the fix by a more robust variant. And I'm proposing that it be installed on all active branches (the original fix is not on the 6 branch). Tested on x86_64-w64-mingw32 (6 branch) and x86_64-suse-linux (mainline), OK? 2017-12-15 Eric Botcazou <ebotca...@adacore.com>

[Ada] Minor tweak to default_pass_by_ref

2017-12-14 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on the mainline. 2017-12-14 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/misc.c (default_pass_by_ref): Minor tweak. -- Eric BotcazouIndex: gcc-interface/misc.c === -

[Ada] Fix compilation time explosion due to recursive inlining

2017-12-14 Thread Eric Botcazou
This clears DECL_DISREGARD_INLINE_LIMITS on recursive expression functions. Tested on x86_64-suse-linux, applied on the mainline. 2017-12-14 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/trans.c (Call_to): Set DECL_DISREGARD_INLINE_LIMITS to 0 on the

[Ada] Fix misalignment in record with aliased field and rep clause

2017-12-14 Thread Eric Botcazou
) and whose nominal alignment is smaller than that of the former field. Tested on x86_64-suse-linux, applied on the mainline, 7 & 6 branches. 2017-12-14 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/decl.c (gnat_to_gnu_field): Do not set the alignment of the enclos

[Ada] Fix discrepancy in annotated vs computed sizes

2017-12-14 Thread Eric Botcazou
. Tested on x86_64-suse-linux, applied on the mainline. 2017-12-14 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/gigi.h (pad_type_has_rm_size): Declare. * gcc-interface/decl.c (gnat_to_gnu_entity) : Do notbuild a padding type for the alignment before validating th

Re: [PATCH] Improve alloca alignment

2017-12-13 Thread Eric Botcazou
care much about that, so who am I to do it after all? ;-) Tested on x86_64-suse-linux and SPARC/Solaris, applied on the mainline. 2017-12-13 Eric Botcazou <ebotca...@adacore.com> Dominik Vogt <v...@linux.vnet.ibm.com> PR middle-end/78468 * emit-rtl.

Re: [C++] Add support for #pragma GCC unroll v4

2017-12-13 Thread Eric Botcazou
Ping for the last missing bits of the #pragma GCC unroll support: > this is the (hopefully) final implementation of the support for the > unrolling pragma in the C++ front-end. https://gcc.gnu.org/ml/gcc-patches/2017-12/msg00298.html Thanks in advance. -- Eric Botcazou

[Ada] Make sure subprogram locus is initialized

2017-12-13 Thread Eric Botcazou
This is another fixlet aimed at making gigi more robust in the presence of unexpected nodes in the expanded code. Tested on x86_64-suse-linux, applied on the mainline and 7 branch. 2017-12-13 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/trans.c (Subprogram_Body_

[Ada] Add small sanity check for package freezing

2017-12-13 Thread Eric Botcazou
on x86_64-suse-linux, applied on the mainline and 7 branch. 2017-12-13 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/trans.c (process_freeze_entity): Be prepared for a package without body. -- Eric BotcazouIndex: gcc-interface/t

[Ada] Fix spurious warning on function imported from C in LTO mode

2017-12-13 Thread Eric Botcazou
We treat System.Address as equivalent to void* for functions imported from C and other languages, but the existing implementation was not very robust. Tested on x86_64-suse-linux, applied on the mainline and 7 branch. 2017-12-13 Eric Botcazou <ebotca...@adacore.com> * gcc-int

Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p (take 2)

2017-12-11 Thread Eric Botcazou
> The old code was inconsistent, had return false; in one case and assert in > the remaining two spots. If you are not against it, I'd use return false; > in both cases if we want consistency. Sure, thanks. -- Eric Botcazou

Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p (take 2)

2017-12-11 Thread Eric Botcazou
d an assertion on the same PARALLEL in the second one. No big deal in either case so your call for the definitive version. -- Eric Botcazou

Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p

2017-12-11 Thread Eric Botcazou
on, it seems to duplicate everything in the 2 main arms. -- Eric Botcazou

Re: [PATCH] Allow USE in PARALLELs in store_data_bypass_p

2017-12-11 Thread Eric Botcazou
|| GET_CODE (xxx) == USE) Couldn't the code be also re-factored? Because 3x the same change is a lot... > 2017-12-06 Jakub Jelinek <ja...@redhat.com> > > * recog.c (store_data_bypass_p): Handle USE in a PARALLEL > like CLOBBER. Formatting fixes. OK for mainline modulo the above remark. -- Eric Botcazou

Re: [PATCH] [SPARC] Make sure that jump is to a label in errata workaround

2017-12-11 Thread Eric Botcazou
> 2017-12-11 Daniel Cederman <ceder...@gaisler.com> > > * config/sparc/sparc.c (sparc_do_work_around_errata): Make sure > the jump is to a label. OK for mainline and 7 branch, thanks. -- Eric Botcazou

Re: [fortran] Add support for #pragma GCC unroll v3

2017-12-06 Thread Eric Botcazou
> 6.1 Extensions implemented in GNU Fortran > 7.2 GNU Fortran Compiler Directives > > 6.1 describes extension covering legacy code and vendor extensions. > 7.2 describes other !$GCC directives. Currently, the section is > mainly calling conventions (CDECL, STDCALL, etc) and library > macroc

[C++] Add support for #pragma GCC unroll v4

2017-12-06 Thread Eric Botcazou
? 2017-12-06 Mike Stump <mikest...@comcast.net> Eric Botcazou <ebotca...@adacore.com> cp/ * constexpr.c (cxx_eval_constant_expression) : Remove assertion on 2nd operand. (potential_constant_expression_1): Likewise. * cp-tree.h (cp_convert_range_

Re: [PATCH 1/2] [SPARC] Prevent -mfix-ut699 from generating b2bst errata sequences

2017-12-06 Thread Eric Botcazou
here with write access, danielh, is currently traveling, so > we wont be able to revert it until next week. If it is urgent, could I > ask you to revert it for us? It's not that urgent of course but I've reverted it. -- Eric Botcazou

Re: [PATCH 1/2] [SPARC] Prevent -mfix-ut699 from generating b2bst errata sequences

2017-12-05 Thread Eric Botcazou
e change I already rejected back in July? https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00496.html If so, what has changed since then? If nothing, then please revert. -- Eric Botcazou

Re: [PATCH v2 3/4] [SPARC] Errata workaround for GRLIB-TN-0010

2017-12-04 Thread Eric Botcazou
> No, there was no particular reason. mem_ref seems like a better choice > if it detects more types of loads. Right, it's supposed to detect all types of loads. Here's what I have installed on the mainline and 7 branch. 2017-12-04 Eric Botcazou <ebotca...@adacore.com>

Re: [PATCH,RFC] combine: Remove use_crosses_set_p

2017-12-04 Thread Eric Botcazou
> Since there are no comments, I'll commit it now. The idea looks interesting but the timing is a bit more questionable. -- Eric Botcazou

Re: [PATCH v2 3/4] [SPARC] Errata workaround for GRLIB-TN-0010

2017-12-04 Thread Eric Botcazou
MEM_P instead of mem_ref here? It looks like there is also a case for the b2bst workaround (only loads are concerned). If no, I'll make the changes along with more cosmetic fixes. -- Eric Botcazou

Re: [patch] prevent .cfi_personality/.cfi_lsda on !dwarf eh configurations

2017-11-30 Thread Eric Botcazou
> 2017-11-30 Tristan Gingold <ging...@adacore.com> > > * dwarf2out.c (dwarf2out_do_cfi_startproc): Only emit > .cfi_personality or .cfi_lsda if the eh data format is dwarf2. PR ada/81470 must be put on the first line to trigger xref in Bugzilla. -- Eric Botcazou

Re: [PATCH v3 1/4] [SPARC] Errata workaround for GRLIB-TN-0012

2017-11-29 Thread Eric Botcazou
a for > GR712RC. > (pass_work_around_errata::gate): Also test sparc_fix_gr712rc. > * config/sparc/sparc.md (fix_gr712rc): New attribute. > (in_branch_annul_delay): Prevent floating-point instructions > in delay slot of annulled integer branch. OK for mainline and 7 branch, thanks. -- Eric Botcazou

Re: [PATCH 2/2] [SPARC] Recognize the load when accessing the GOT

2017-11-28 Thread Eric Botcazou
> 2017-11-27 Daniel Cederman <ceder...@gaisler.com> > > * config/sparc/sparc.c (sparc_do_work_around_errata): Treat the > movsi_pic_gotdata_op instruction as a load for the UT699 errata > workaround. OK for mainline, 7 and 6 branches, thanks. -- Eric Botcazou

Re: [PATCH 1/2] [SPARC] Prevent -mfix-ut699 from generating b2bst errata sequences

2017-11-28 Thread Eric Botcazou
> 2017-11-27 Martin Aberg <mab...@gaisler.com> > > * config/sparc/sparc.md (divdf3_fix): Add NOP and adjust length > to prevent b2bst errata sequence. > (sqrtdf2_fix): Likewise. OK for mainline and 7 branch, thanks. -- Eric Botcazou

Re: [PATCH v2 4/4] [SPARC] Errata workaround for GRLIB-TN-0013

2017-11-28 Thread Eric Botcazou
delay > attribute. Let's not though and make the modification I suggested instead. -- Eric Botcazou

Re: [PATCH v2 4/4] [SPARC] Errata workaround for GRLIB-TN-0013

2017-11-28 Thread Eric Botcazou
*/ > + if (i == 2) > + emit_insn_before (gen_nop (), next); > + insert_nop = true; > + break; > + } Superfluous "is". -- Eric Botcazou

Re: [PATCH v2 3/4] [SPARC] Errata workaround for GRLIB-TN-0010

2017-11-28 Thread Eric Botcazou
* config/sparc/sync.md (atomic_compare_and_swap_leon3_1): Make > instruction referable in atomic_insns_p. OK for mainline and 7 branch, thanks. -- Eric Botcazou

Re: [PATCH v2 2/4] [SPARC] Errata workaround for GRLIB-TN-0011

2017-11-28 Thread Eric Botcazou
> 2017-11-17 Daniel Cederman <ceder...@gaisler.com> > > * config/sparc/sync.md (swapsi): 16-byte align if sparc_fix_gr712rc. > (atomic_compare_and_swap_leon3_1): Likewise. > (ldstub): Likewise. OK for mainline and 7 branch, thanks. -- Eric Botcazou

Re: [PATCH v2 1/4] [SPARC] Errata workaround for GRLIB-TN-0012

2017-11-28 Thread Eric Botcazou
quot;) > + ] (const_string "false"))) > + > (define_delay (eq_attr "type" "call") >[(eq_attr "in_call_delay" "true") (nil) (nil)]) is barely maintainable. So let's go back to the original version and... > @@ -602,6 +626,10 @@ &g

Re: [fortran] Add support for #pragma GCC unroll v3

2017-11-28 Thread Eric Botcazou
ps and #pragma GCC N wins over --param max-unroll-times=M. -- Eric Botcazou

Re: [patch] Add support for #pragma GCC unroll v2

2017-11-27 Thread Eric Botcazou
ted on x86_64-suse-linux, applied on the mainline. > Pragma support in the FEs need FE maintainer approval. Yes, I have posted separate patches for the C/C++ and Fortran front-ends. 2017-11-27 Eric Botcazou <ebotca...@adacore.com> * cfgloop.h (struct loop): Document usage

[fortran] Add support for #pragma GCC unroll v3

2017-11-25 Thread Eric Botcazou
Bernhard Reutner-Fischer <al...@gcc.gnu.org> Eric Botcazou <ebotca...@adacore.com> fortran/ChangeLog: * array.c (gfc_copy_iterator): Copy unroll field. * decl.c (directive_unroll): New global variable. (gfc_match_gcc_unroll): New function.

[C/C++] Add support for #pragma GCC unroll v3

2017-11-25 Thread Eric Botcazou
-11-25 Mike Stump <mikest...@comcast.net> Eric Botcazou <ebotca...@adacore.com> ChangeLog/ * doc/extend.texi (Loop-Specific Pragmas): Document pragma GCC unroll. c-family/ChangeLog: * c-pragma.c (init_pragma): Register pragma GCC unroll. * c-pr

Re: [PATCH 4/4] [SPARC] Errata workaround for GRLIB-TN-0013

2017-11-24 Thread Eric Botcazou
pt b/gcc/config/sparc/sparc.opt > index 22267f5..43cd964 100644 > --- a/gcc/config/sparc/sparc.opt > +++ b/gcc/config/sparc/sparc.opt > @@ -253,6 +253,10 @@ Enable workarounds for the errata of the GR712RC > processor. TargetVariable > unsigned int sparc_fix_b2bst > > +;; Enable workaround for TN-0013 errata > +TargetVariable > +unsigned int sparc_fix_tn0013 Can we find a more evocative name for the variable? -- Eric Botcazou

Re: [PATCH 3/4] [SPARC] Errata workaround for GRLIB-TN-0010

2017-11-24 Thread Eric Botcazou
target = next_active_insn (JUMP_LABEL_AS_INSN (jump)); rtx_insn *target = next_active_insn (JUMP_LABEL_AS_INSN (jump)); > + if (target > + && atomic_insn_p (target)) On a single line. -- Eric Botcazou

Re: [PATCH 2/4] [SPARC] Errata workaround for GRLIB-TN-0011

2017-11-24 Thread Eric Botcazou
ngly (and conservatively), see atomic_compare_and_swapdi_v8plus for reference. -- Eric Botcazou

Re: [PATCH 1/4] [SPARC] Errata workaround for GRLIB-TN-0012

2017-11-24 Thread Eric Botcazou
@ > (define_delay (eq_attr "type" "branch") >[(eq_attr "in_branch_delay" "true") (nil) (eq_attr "in_branch_delay" > "true")]) > > +(define_delay (and (eq_attr "type" "branch") (eq_attr "branch_type" "icc")) > + [(eq_attr "in_branch_delay" "true") (nil) > + (eq_attr "in_branch_annul_delay" "true")]) > + I think that we'd better keep the various define_delay's mutually exclusive. -- Eric Botcazou

Re: [PATCH][i386,AVX] Enable VBMI2 support [2/7]

2017-11-24 Thread Eric Botcazou
6_BUILTIN__BDESC_SPECIAL_ARGS2_LAST) ^ /home/eric/gnat/gnat-head/src/gcc/config/i386/i386.c:37443:48: error: ‘bdesc_special_args2’ was not declared in this scope return ix86_expand_special_args_builtin (bdesc_special_args2 + i, exp, -- Eric Botcazou

[Ada] Fix PR ada/83091

2017-11-23 Thread Eric Botcazou
This fixes a small oversight in gigi, which can lead to an inconsistency between type variants for the mode when packed array types are involved. Tested on x86-64/Linux, applied on the mainline. 2017-11-23 Eric Botcazou <ebotca...@adacore.com> PR ada/83091 * gcc-int

Fix PR rtl-optimization/83030

2017-11-22 Thread Eric Botcazou
that CROSSING_JUMP_P is not documented at all (instead the now dead REG_CROSSING_JUMP still is) so the patch does a bit of housekeeping work. Tested on x86-64/Linux and SPARC64/Linux, applied on the mainline. 2017-11-22 Eric Botcazou <ebotca...@adacore.com> PR rtl-optimization

[patch] Add support for #pragma GCC unroll v2

2017-11-22 Thread Eric Botcazou
net> Eric Botcazou <ebotca...@adacore.com> Bernhard Reutner-Fischer <al...@gcc.gnu.org> ChangeLog/ * doc/extend.texi (Loop-Specific Pragmas): Document pragma GCC unroll. * doc/generic.texi (ANNOTATE_EXPR): Document 3rd operand. * cfgloop.h

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-22 Thread Eric Botcazou
> If we don't then i would say that's the bug to fix, not warp back in > time 20 years. Why let solaris hold hostage everybody else? Let's not start a flame war, please. Almost all other uses of grep in the libgo directory have >/dev/null instead of -q and nobody chokes on them.

Re: [PATCH] Fix i?86 bootstrap (PR rtl-optimization/82044)

2017-11-22 Thread Eric Botcazou
> Unfortunately this patch broke i686-linux bootstrap, during stage2 > libgcc configure fails due to numerous ICEs. Note that the patch is on the 7 branch too. -- Eric Botcazou

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-22 Thread Eric Botcazou
> grep -q was even required by SUSv2 from 1997 so Solaris should really > support it. What version if Solaris is that and what version of grep? /usr/bin/grep on Solaris 10 (/usr/xpg4/bin/grep does support it). -- Eric Botcazou

Re: libgo patch committed: Fix Makefile bug setting LD_LIBRARY_PATH

2017-11-21 Thread Eric Botcazou
> This patch by Than McIntosh fixes a small bug in the libgo Makefile > recipe that constructs the directory from which to pick up > libgcc_s.so; the gccgo invocation with -print-libgcc-file-name was > missing the flags, which meant that for -m32 builds we'd see the > 64-bit libgcc dir.

Re: [RFC][PATCH] Change default to -fcommon

2017-11-21 Thread Eric Botcazou
(var_decl) = 1; It's for Darwin - you need to evaluate your patch on Darwin. > I don't understand how this works - if there is no bss support in the > linker, wouldn't common variables would still end up in the data section? There is, it's essentially a syntactic issue in the assembler IIRC. -- Eric Botcazou

Re: [patch] Add support for #pragma GCC unroll

2017-11-21 Thread Eric Botcazou
er might do more than > intended, see https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01468.html > I expect updates to the C and C++ in this area to be reflected to Fortran > too. Yes, it's a generic issue. -- Eric Botcazou

Re: [patch] Add support for #pragma GCC unroll

2017-11-21 Thread Eric Botcazou
do} loop or a @samp{#pragma ivdep}, and applies > only to the loop that follows. @var{n} is an integer constant > expression; a value of 0 or 1 disables unrolling of the loop. Thanks, integrated into the patch. -- Eric Botcazou

Re: [patch] Add support for #pragma GCC unroll

2017-11-20 Thread Eric Botcazou
y the flag as well. The other optimization hints (ivdep, [no-]vector) aren't copied either. > I think this has the same issue as the RTL unroller change. Right. -- Eric Botcazou

Re: [patch] Add support for #pragma GCC unroll

2017-11-20 Thread Eric Botcazou
> If anybody finds the time to push the corresponding Fortran changes then I'd > be grateful. I won't have time for this until end of stage 1... > > https://gcc.gnu.org/ml/fortran/2015-02/msg00014.html OK, I'm going to merge it in the main patch. -- Eric Botcazou

Re: Fix PR81360

2017-11-20 Thread Eric Botcazou
> It was a typo in the conditional (I cleaned it up just before comitting > because I noticed I can merge it with earlier conditional and accidentally > dropped !). It should be fixed now. OK, thanks, unfortunately the bug made it into the latest source snapshot. -- Eric Botcazou

Re: [patch] Do not report non-executed blocks in Ada coverage

2017-11-20 Thread Eric Botcazou
> Is this still needed? I know Martin L did another teak for non-executed > blocks in Ada... BUt I don't know enough to determine if it was > sufficient to address this problem. Yes, Martin's patch fixed the regression in Ada so mine is obsolete. -- Eric Botcazou

Re: Fix PR81360

2017-11-20 Thread Eric Botcazou
> I believe this caused hundreds of new FAILs on both x86_64 and i686-linux. > Seems after this change we no longer inline always_inline functions into > -O0 callers, which is wrong. That's worse than this, inlining is totally broken... -- Eric Botcazou

[Ada] Fix PR ada/83016

2017-11-19 Thread Eric Botcazou
This gets rid of the warning about the unrecognized option -nostdinc++ passed to gnat1 during the build of the gnattools. Tested on x86_64-suse-linux, applied on the mainline. 2017-11-20 Eric Botcazou <ebotca...@adacore.com> PR ada/83016 * gnatlink.adb (Process_Args):

[patch] Add support for #pragma GCC unroll

2017-11-17 Thread Eric Botcazou
guards all over the place, polishing a few rough edges and eliminating a few preexisting nits in the unrolling code. Tested on x86_64-suse-linux, OK for the mainline? 2017-11-17 Mike Stump <mikest...@comcast.net> Eric Botcazou <ebotca...@adacore.com> ChangeLog:

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-11-15 Thread Eric Botcazou
> Following patch survives regression tests and bootstraps. Please drop the Ada bits though, -Wreturn-type just doesn't work in Ada. -- Eric Botcazou

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-11-15 Thread Eric Botcazou
in tree-cfg.c. That change is preapproved if it works, and your > patch if you want in addition to that is ok too. That's the first thing I tried and it indeed works. -- Eric Botcazou

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-11-13 Thread Eric Botcazou
killed any hope of preserving padding a long time ago for not-so-legal programs anyway). -- Eric Botcazou

Re: [patch] Fix PR lto/81351

2017-11-13 Thread Eric Botcazou
> 2017-11-10 Eric Botcazou <ebotca...@adacore.com> > > PR lto/81351 > * debug.h (dwarf2out_do_eh_frame): Declare. > * dwarf2cfi.c (dwarf2out_do_eh_frame): New predicate. > (dwarf2out_do_frame): Use it. > (dwarf2out_do_cfi_asm): Like

Re: [C++ PATCH] Remove the null check from placement new in all modes

2017-11-13 Thread Eric Botcazou
in any mode unless -fcheck-new is provided. Incorrect entry, it should go in gcc/cp/ChangeLog without the cp/ prefix: * init.c (build_new_1): Don't do a null check for a namespace-scope non-replaceable placement new in any mode unless -fcheck-new is provided. -- Eric Botcazou

[patch] Fix PR lto/81351

2017-11-10 Thread Eric Botcazou
for mainline? 2017-11-10 Eric Botcazou <ebotca...@adacore.com> PR lto/81351 * debug.h (dwarf2out_do_eh_frame): Declare. * dwarf2cfi.c (dwarf2out_do_eh_frame): New predicate. (dwarf2out_do_frame): Use it. (dwarf2out_do_cfi_asm): Likewise. * dwarf

[Ada] Fix ICE on defaulted string parameters at -O

2017-11-10 Thread Eric Botcazou
on the mainline, 7 and 6 branches. 2017-11-10 Eric Botcazou <ebotca...@adacore.com> * gcc-interface/utils.c (convert) : Add comment and do not fall through to the next case. : Deal specially with a dereference from another array type with the same elemen

Re: [PATCH] Fix compare-elim.c ICE (PR rtl-optimization/82913)

2017-11-09 Thread Eric Botcazou
c (try_merge_compare): Punt if def_insn is not > single set. > > * gcc.c-torture/compile/pr82913.c: New test. OK, thanks. -- Eric Botcazou

Re: [patch] Fix EH breakage in LTO mode

2017-11-09 Thread Eric Botcazou
is is all masked on x86 because -funwind-tables is always enabled). On the other hand, this is required for a normal link too. I guess that would be more consistent with what happens with -fdwarf2-cfi-asm. -- Eric Botcazou

Re: [patch] Fix EH breakage in LTO mode

2017-11-09 Thread Eric Botcazou
> this is PR lto/81351. Totally missed it... Do not hesitate to CC me for SPARC regressions. -- Eric Botcazou

<    8   9   10   11   12   13   14   15   16   17   >