Ping
On 07.07.2015 14:27, Ilmir Usmanov wrote:
Ping
30.06.2015, 03:43, Ilmir Usmanov m...@ilmir.us:
Hi Cesar!
Thanks for your review!
08.06.2015, 17:59, Cesar Philippidis ce...@codesourcery.com:
On 06/07/2015 02:05 PM, Ilmir Usmanov wrote:
Fixed fortran mail-list address. Sorry
Hi Cesar!
Thanks for your review!
08.06.2015, 17:59, Cesar Philippidis ce...@codesourcery.com:
On 06/07/2015 02:05 PM, Ilmir Usmanov wrote:
Fixed fortran mail-list address. Sorry for inconvenience.
08.06.2015, 00:01, Ilmir Usmanov m...@ilmir.us:
Hi Cesar!
This patch fixes checks
Hi Cesar!
This patch fixes checks of OpenMP and OpenACC continuations in case if someone
mixes them (i.e. continues OpenMP directive with !$ACC sentinel or vice versa).
OK for gomp branch?
--
Ilmir.
From 5492bf5bc991b6924f5e3b35c11eeaed745df073 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov
Fixed fortran mail-list address. Sorry for inconvenience.
08.06.2015, 00:01, Ilmir Usmanov m...@ilmir.us:
Hi Cesar!
This patch fixes checks of OpenMP and OpenACC continuations in case if
someone mixes them (i.e. continues OpenMP directive with !$ACC sentinel or
vice versa).
OK for gomp
Hi!
On 06.05.2015 14:38, Thomas Schwinge wrote:
Hi!
On Tue, 5 May 2015 15:38:03 -0400, David Malcolm dmalc...@redhat.com wrote:
On Wed, 2015-04-29 at 14:10 +0200, Mikael Morin wrote:
Le 29/04/2015 02:02, David Malcolm a écrit :
diff --git a/gcc/fortran/parse.c b/gcc/fortran/parse.c
index
Hi Cesar!
Thank you for the update!
On 05.10.2014 02:32, Cesar Philippidis wrote:
On 10/03/2014 07:34 AM, Cesar Philippidis wrote:
On 09/24/2014 12:18 AM, Ilmir Usmanov wrote:
Hi Cesar!
Thank you for the patch!
On 24.09.2014 02:29, Cesar Philippidis wrote:
This patch adds support
Hi Cesar!
Thank you for the patch!
On 24.09.2014 02:29, Cesar Philippidis wrote:
This patch adds support for the async clause in the wait directive in
fortran. It should be pretty straight forward. The fortran FE already
supports the wait directive, but the async clause was introduced to the
Hi Cesar!
Sorry for long delay, I was busy at the institute.
On 05.06.2014 07:58, Cesar Philippidis wrote:
I didn't see a whole lot different from your gfc_trans_oacc_loop and the
existing gfc_trans_omp_do, so I augmented the latter to handle the
openacc loop clause. It looks like the only
Hi Cesar!
This patch, which is derived from Ilmir Usmanov's work posted here
https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00027.html, implements
the loop directive in openacc. The original patch is mostly intact,
Thank you!
I looked through the patch and found that you also added middle-end
On 16.05.2014 19:44, Ilmir Usmanov wrote:
Hi Thomas!
On 16.05.2014 19:12, Thomas Schwinge wrote:
Hi Ilmir!
You recently indicated that you have already begun implementing OpenACC
subarray specifications in the GCC Fortran front end, but have not
been/are not currently able to complete
inner
ENDDO outer
we must generate mask of inner loop inside of outer one. Hence, the loop
cannot be collapsed.
Is this acceptable?
--
Ilmir.
From b3a6435a08612951ec8a330877e002a92a9b00f4 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Tue, 1 Apr 2014 21:02:50 +0400
collapse(1)
for (i = 1; i 3; i++)
{
if (b[i-1] == 5 my_mask[i-1])
{
b[i-1] = -42;
}
}
Is it OK now?
--
Ilmir.
From 50c0eef6f0a48fa05ab5de8924376a75fb23aca6 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Sat, 22 Mar 2014 18:54:17 +0400
Subject
Hi Thomas!
On 19.03.2014 23:35, Thomas Schwinge wrote:
Do you intend to support loop constructs that are not nested in a
parallel or kernels construct? As I'm reading it, the specification is
not clear on this. (I guess I'll raise this question with the OpenACC
guys.)
Yes, I do. There are
Hi Thomas!
On 20.03.2014 14:21, Thomas Schwinge wrote:
I just realized that this is wrong usage of the dg-excess-errors
directive, for this one will absorb *all* remaining errors, whereas you
just wanted to mask out any »sorry, unimplemented: directive not yet
implemented« ones.
Sorry for
Hi Thomas!
On 20.03.2014 14:22, Thomas Schwinge wrote:
As in
http://news.gmane.org/find-root.php?message_id=%3C87mwglf9vq.fsf%40schwinge.name%3E,
this is wrong usage of the dg-excess-errors directive, for this one will
absorb *all* remaining errors, whereas you just wanted to mask out any
Hi all!
My name is Ilmir Usmanov and I'm a student of Moscow Institute of Physics and
Technology.
Also I'm implementing OpenACC 1.0 in gomp4 branch as an employee of Samsung RD
Institute Russia (SRR). My research interests are connected with creating
OpenCL Code Generator. So I'd like
2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Wed, 19 Mar 2014 15:12:36 +0400
Subject: [PATCH] Transform OpenACC loop directive from fortran AST to GENERIC
---
* gcc/fortran/trans-openmp.c (gfc_trans_oacc_loop): New function.
(gfc_trans_oacc_combined_directive): Call
Ping.
On 13.03.2014 21:05, Ilmir Usmanov wrote:
On 07.03.2014 15:37, Ilmir Usmanov wrote:
Hi Thomas!
I prepared simple patch to add support of OpenACC data, kernels and
parallel constructs to C++ FE.
It adds support of data clauses too.
OK to gomp4 branch?
Fixed subject: changed file
parsing and resolving of loop directive but doesn't transformation to
GENERIC.
Bootstraped and tested with no new regressions on x86_64-unknown-linux-gnu.
OK for gomp4 branch?
--
Ilmir.
From 1adbb9d2e504c7acac8be89b053fa677cf285b42 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma
Committed as r208649.
--
Ilmir.
Committed as r208533.
--
Ilmir.
Hi Thomas!
On 13.03.2014 15:38, Thomas Schwinge wrote:
Hi Ilmir!
On Thu, 13 Mar 2014 13:34:54 +0400, Ilmir Usmanov i.usma...@samsung.com wrote:
Committed as r208533.
Yay! \o/
Thanks! Yay indeed.
And thanks a lot for your comments.
The following change seems the right thing to do
On 13.03.2014 16:19, Ilmir Usmanov wrote:
The following change seems the right thing to do -- but why doesn't the
current code trigger a GCC ICE due to a failing subcode check? (At least
I thought you had test cases exercising the respective OpenACC vector
clauses?) Can you please check
On 07.03.2014 15:37, Ilmir Usmanov wrote:
Hi Thomas!
I prepared simple patch to add support of OpenACC data, kernels and
parallel constructs to C++ FE.
It adds support of data clauses too.
OK to gomp4 branch?
Fixed subject: changed file extensions of tests and fixed comments.
OK to gomp4
Hi Tobias!
Thanks a lot for your review!
!$acc loop
outer_loop: do i = 1, n
inner_loop: do j = 1,m
! ...
cycle outer_loop
exit outer_loop
end do inner_loop
end do outer_loop
That's a new Fortran 2008 feature that CYCLE and EXIT can leave the
inner DO loop.
I added
OpenACC region.
From b783a60855f6649b6b8b440f177c1076f9af6521 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 7 Mar 2014 14:33:17 +0400
Subject: [PATCH 2/4] OpenACC Fortran FE -- part 2
---
gcc/fortran/openmp.c | 1222
70dca7f32b50e762f1295a2054bb484ef7fbb42e Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 7 Mar 2014 14:33:47 +0400
Subject: [PATCH 3/4] OpenACC Fortran FE -- part 3
---
gcc/fortran/trans-decl.c | 7 +
gcc/fortran/trans-openmp.c | 357
Hi Thomas!
I prepared simple patch to add support of OpenACC data, kernels and
parallel constructs to C++ FE.
It adds support of data clauses too.
OK to gomp4 branch?
--
Ilmir.
: Likewise.
gcc/testsuite/g++.dg/goacc/
* deviceptr-1.cpp: New test.
* sb-1.cpp: Likewise.
* sb-2.cpp: Likewise.
From c7cbe59516a1c21cfbad48863311e6d5389c Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 7 Mar 2014 15:12:30 +0400
Subject: [PATCH 2/2
, OACC_PARALLEL_CLAUSE_MASK): Likewise.
(cp_parser_omp_construct, cp_parser_pragma): Support OpenACC
directives.
* semantics.c (finish_oacc_data): New function.
(finish_oacc_kernels, finish_oacc_parallel): Likewise.
From 422e398c375ce6a62691bfc4cc9dd71c38f87b40 Mon Sep 17 00:00:00 2001
From: Ilmir
Hi Tobias!
I fixed my patches. Could you review them?
I'd use integer instead of INTEGER as it is not a 'reserved' word
OpenMP implementation uses capital letters, so, perhaps, we also should
do this, for consistency?
--
Ilmir.
OpenACC region.
From 11beca16743c66a112ec44717eaf9ed61f203d1e Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Wed, 26 Feb 2014 19:03:12 +0400
Subject: [PATCH 2/5] OpenACC Fortran FE: part 2
---
gcc/fortran/openmp.c | 1221
b5010b30cc9fe6495cb9b9df356c044d267210c9 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Wed, 26 Feb 2014 19:03:24 +0400
Subject: [PATCH 3/5] OpenACC Fortran FE: part 3
---
gcc/fortran/trans-decl.c | 7 +
gcc/fortran/trans-openmp.c | 357
, ')');
}
break;
--
Ilmir.
From bff6eb6dd930316bab91f222c1673e699fa97b96 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 27 Feb 2014 13:46:24 +0400
Subject: [PATCH] Fix ASYNC
---
gcc/gimplify.c | 4 ++--
gcc/omp-low.c | 4 ++--
gcc/tree-core.h | 6
Committed as r208197.
--
Ilmir.
Hi Thomas!
This patch is pretty obvious. Currently ASYNC clause cannot have
integer-expression-list. Patch fixes this.
OK for gomp4 branch?
--
Ilmir.
From df76a29ebf869687209d7a606e243624cc136dbc Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Wed, 26 Feb 2014 19:04
Hi Tobias!
On 20.02.2014 03:51, Tobias Burnus wrote:
On 10.02.2014 02:22, Tobias Burnus wrote:
a) Does this part work well when both -fopenmp and -fopenacc is
used? I mean: !$acc loop followed/preceded by !$omp do? I could
imagine that there could be clashes, especially when - e.g. -
Hi Tobias!
Thanks a lot for your review!
I have tested your notes on two compilers which support OpenACC: PGI
14.1 and CAPS 3.4.1.
If I made a mistake and you've collected results which differ from mine
(whether you compiler is one of the above or not), please, let me know.
Unfortunally,
Hi Tobias!
On 10.02.2014 03:10, Tobias Burnus wrote:
Shouldn't you also reject polymorphic types (BT_CLASS and
BT_ASSUMED)? [BT_CLASS = class(derived_type_name) or class(*);
BT_ASSUMED = type(*)]
+ if (n-sym-attr.pointer)
+gfc_error (POINTER object '%s' in %s clause at %L,
+
prefer.
I fixed patch according to your review and ready to commit it. OK for
GOMP4 branch?
--
Ilmir.
From bf14158b1a28c2c5b29c41071fa62c011d9f4f65 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 13 Feb 2014 15:58:28 +0400
Subject: [PATCH] OpenACC GENERIC nodes
Committed as r207776.
--
Ilmir.
Hi Thomas!
On 10.02.2014 12:52, Thomas Schwinge wrote:
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/goacc/goacc.exp
@@ -0,0 +1,36 @@
+# Load support procs.
+load_lib gfortran-dg.exp
+
+if ![check_effective_target_fopenmp] {
+ return
+}
I assume that this should be indeed fopenmp here and not
Hi Tobias!
Thanks a lot for your review!
I'm going to test you notes in reference implementation (PGI
compiler), and then share the results.
On 10.02.2014 03:42, Tobias Burnus wrote:
Is there a reason that you don't automatically add that flag via
goacc.exp?
Ditto. Also spaces before/after
Hi Jakub!
On 31.01.2014 15:45, Ilmir Usmanov wrote:
Hi Jakub!
Thank you for review and quick answer.
The above are OpenACC specific clauses, so they should have OACC_LIST_*?
I just followed Thomas's style recomendations:
If we're adding new names for implementing OpenACC things, maybe we
Hi Thomas!
I fixed these patches:
http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01520.html .
Instead of adding new OACC_* data structures and macros for OpenACC
clauses these patches reuse existing OMP_* functionality and extends it.
But OpenACC-specific constructs and directives still named
directives.
* st.c (gfc_free_statement): Free also OpenACC directives.
From f8f10537d2555e596bdd1655990150d45ef08f9b Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 31 Jan 2014 13:25:42 +0400
Subject: [PATCH 1/6] OpenACC fortran front-end -- part 1
---
gcc/fortran/dump
,
OACC_DECLARE_CLAUSES,
OACC_UPDATE_CLAUSES, OACC_ENTER_DATA_CLAUSES,
OACC_EXIT_DATA_CLAUSES): New defines.
From 64b05eeeadf25fca4f92f083cc11aaad1a7a692a Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 31 Jan 2014 13:26:13 +0400
Subject: [PATCH 2/6] OpenACC fortran front-end
c7fcfb4e2aaeb1833dad4d5e370da330bb1a3760 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 31 Jan 2014 13:27:24 +0400
Subject: [PATCH 3/6] OpenACC fortran front-end -- part 3
---
gcc/fortran/trans-decl.c | 7 +
gcc/fortran/trans-openmp.c | 367
, OACC_DATA_CLAUSES,
OACC_DECLARE_CLAUSES,
OACC_UPDATE_CLAUSES, OACC_WAIT_CLAUSES, OACC_CACHE_CLAUSES,
OACC_HOST_DATA_BODY, OACC_HOST_DATA_CLAUSES): Likewise.
From 3383f24ea09611525311e3e2147672421c31f9cb Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 31 Jan 2014 13
: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 31 Jan 2014 13:29:44 +0400
Subject: [PATCH 5/6] OpenACC fortran tests
---
gcc/testsuite/gfortran.dg/goacc/branch.f95 | 55 +
.../gfortran.dg/goacc/continuation-free-form.f95 | 24 ++
gcc/testsuite/gfortran.dg/goacc/data-clauses.f95
: Ilmir Usmanov i.usma...@samsung.com
Date: Fri, 31 Jan 2014 13:30:18 +0400
Subject: [PATCH 6/6] OpenACC GENERIC docs
---
gcc/doc/generic.texi | 40
1 file changed, 40 insertions(+)
diff --git a/gcc/doc/generic.texi b/gcc/doc/generic.texi
index a56715b..8153a6e
Hi Jakub!
Thank you for review and quick answer.
The above are OpenACC specific clauses, so they should have OACC_LIST_*?
I just followed Thomas's style recomendations:
If we're adding new names for implementing OpenACC things, maybe we
should also name these OMP_*, to keep things simple to
Hi, Thomas!
Likewise, if you have any comments on my patch series for »initial
support for OpenACC data clauses«, I'd like to hear them.
Sure:
+ else if (!strcmp (present_or_copy, p))
+result = PRAGMA_OMP_CLAUSE_PRESENT_OR_COPY;
+ else if (!strcmp (present_or_copyin, p))
+
Hi, Thomas!
Thank you for your review.
I agree with all your notes. I'm going to reuse your implementation of
data clauses, add minimal GIMPLE infrastructure, and then resend patches.
--
Ilmir.
Hi all.
Jakub, could you review these patches, if they are OK to gomp-4_0-branch?
Thomas, please, have a look whether this implementation applies current
OpenACC support style.
These patches port OpenACC 1.0 support in fortran front-end from
openacc-1_0-branch to gomp-4_0-branch. In
From 69bf2531e4512b7cdb2feba8541de1eaf9c2aa56 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 23 Jan 2014 21:05:11 +0400
Subject: [PATCH 2/6] OpenACC fortran FE part 2
---
gcc/fortran/openmp.c | 1032 +-
1 file
From 84dc72f88c1b23ae995afdda0b946ebd73af102f Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 23 Jan 2014 21:04:37 +0400
Subject: [PATCH 1/6] OpenACC fortran FE part 1
---
gcc/fortran/decl.c| 1 +
gcc/fortran/dump-parse-tree.c | 203
From 0658580cf665b8da8cc4533901989b7a1d54f73a Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 23 Jan 2014 21:06:00 +0400
Subject: [PATCH 3/6] OpenACC fortran FE part 3
---
gcc/fortran/trans-decl.c | 7 +
gcc/fortran/trans-openmp.c | 526
From 37806068fffcab95a21b51829c900d49be14961d Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 23 Jan 2014 21:08:05 +0400
Subject: [PATCH 4/6] OpenACC GENERIC nodes
---
gcc/gimplify.c | 73
gcc/omp-low.c | 84 --
gcc
From ae0ba17c51f6ed3529976a0cdf8f80046d1ed9b7 Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 23 Jan 2014 21:10:41 +0400
Subject: [PATCH 5/6] OpenACC fortran tests
---
gcc/testsuite/gfortran.dg/goacc/branch.f95 | 55 +
.../gfortran.dg/goacc
From 668a50443d0a70a633707ec49759d9e8b6d00b1e Mon Sep 17 00:00:00 2001
From: Ilmir Usmanov i.usma...@samsung.com
Date: Thu, 23 Jan 2014 21:26:50 +0400
Subject: [PATCH 6/6] OpenACC GENERIC docs
---
gcc/doc/generic.texi | 40
1 file changed, 40 insertions
Finally, ChangeLog entry.
23-01-2014 Ilmir Usmanov i.usma...@samsung.com
Add OpenACC 1.0 support to fortran FE and GENERIC, except loop directive
and subarrays.
gcc/fortran/
* decl.c (gfc_match_end): Match end of OpenACC region.
* dump-parse-tree.c
on it.
--
Regards, Ilmir Usmanov
63 matches
Mail list logo
