Re: [PATCH] Fix PR64277

2015-01-27 Thread Ilya Enkovich
2015-01-27 13:59 GMT+03:00 Richard Biener rguent...@suse.de: On Tue, 27 Jan 2015, Ilya Enkovich wrote: 2015-01-27 12:47 GMT+03:00 Richard Biener rguent...@suse.de: On Tue, 27 Jan 2015, Jakub Jelinek wrote: On Tue, Jan 27, 2015 at 10:25:48AM +0100, Richard Biener wrote: This disables

Re: [PATCH, PR tree-optimization/64277] Improve loop iterations count estimation

2015-01-27 Thread Ilya Enkovich
On 27 Jan 12:29, Richard Biener wrote: On Tue, Jan 27, 2015 at 11:47 AM, Ilya Enkovich enkovich@gmail.com wrote: On 27 Jan 12:40, Ilya Enkovich wrote: Hi, This patch was supposed to fix PR tree-optimization/64277. Tracker is now fixed by warnings disabling but I think patch

[PATCH, CHKP] Fix PR middle-end/64805

2015-01-27 Thread Ilya Enkovich
-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2015-01-27 Ilya Enkovich ilya.enkov...@intel.com PR middle-end/64805 * ipa-inline.c (early_inliner): Rebuild IPA_REF_CHKP reference to avoid error in cgraph node verification. 2015-01-27 Ilya Enkovich ilya.enkov

[PATCH, CHKP] Fix bounds return check for calls

2015-01-26 Thread Ilya Enkovich
Hi, Currently chkp_call_returns_bounds_p works incorrectly for bounds narrowing. Also it doesn't reflect recent changes in calls instrumentation. This patch fixes the problem. Bootstrapped and checked on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2015-01-26 Ilya Enkovich

[PATCH, committed] Fix chkp-always_inline.c test to not fail with -fpic

2015-01-20 Thread Ilya Enkovich
Hi, chkp-always_inline.c test fails with -fpic (https://gcc.gnu.org/ml/gcc-regression/2015-01/msg00528.html) because of non static function with 'always_inline' attribute. This patch fixes it. Committed as obvious. Thanks, Ilya -- 2015-01-20 Ilya Enkovich ilya.enkov...@intel.com

Re: [PATCH, CHKP] [always_inline 1/2] Allow inlining for not instrumented calls to always_inline functions

2015-01-19 Thread Ilya Enkovich
2015-01-16 19:58 GMT+03:00 Jeff Law l...@redhat.com: On 01/16/15 04:04, Ilya Enkovich wrote: Hi, Currently compiler emits an error in case of not instrumented call to instrumented alwyas_inline function. It happens because when we inline there is only instrumented version of function

Re: [PATCH, CHKP, PR64363] Don't instrument functions we cannot copy

2015-01-16 Thread Ilya Enkovich
On 15 Jan 15:03, Richard Biener wrote: On Thu, Jan 15, 2015 at 2:51 PM, Ilya Enkovich enkovich@gmail.com wrote: 2015-01-15 16:07 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Thu, Jan 15, 2015 at 12:46 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch

Re: [PATCH] Fix for PR64353

2015-01-16 Thread Ilya Enkovich
On 14 Jan 19:40, Richard Biener wrote: On January 14, 2015 5:23:21 PM CET, Ilya Enkovich enkovich@gmail.com wrote: On 14 Jan 15:35, Richard Biener wrote: On Wed, Jan 14, 2015 at 3:28 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, SRA gimple passes may add loads

[PATCH, CHKP] [always_inline 1/2] Allow inlining for not instrumented calls to always_inline functions

2015-01-16 Thread Ilya Enkovich
to problem in SRA fixed by the next patch. OK for trunk? Thanks, Ilya -- gcc/ 2015-01-16 Ilya Enkovich ilya.enkov...@intel.com * ipa-chkp.c (chkp_produce_thunks): Add early param. (pass_data_ipa_chkp_early_produce_thunks): New. (pass_ipa_chkp_early_produce_thunks): New

[PATCH, CHKP] [always_inline 2/2] Fix segafult in SRA

2015-01-16 Thread Ilya Enkovich
and checked on x86_64-unknown-linux-gnu. Fixes faults revealed by the first patch in the series. OK for trunk? Thanks, Ilya -- 2015-01-16 Ilya Enkovich ilya.enkov...@intel.com * tree-sra.c (some_callers_have_mismatched_arguments_p): Allow thunk callers. diff --git a/gcc/tree

Re: [PATCH] Fix for PR64353

2015-01-16 Thread Ilya Enkovich
On 16 Jan 12:38, Richard Biener wrote: On Fri, Jan 16, 2015 at 11:51 AM, Ilya Enkovich enkovich@gmail.com wrote: On 14 Jan 19:40, Richard Biener wrote: On January 14, 2015 5:23:21 PM CET, Ilya Enkovich enkovich@gmail.com wrote: On 14 Jan 15:35, Richard Biener wrote: On Wed

[PATCH, CHKP, PR64363] Don't instrument functions we cannot copy

2015-01-15 Thread Ilya Enkovich
Hi, This patch is to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64363. Patch disables instrumentation for functions we cannot clone correctly due to labels. Bootstrapped and checked on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-01-14 Ilya Enkovich ilya.enkov

Re: [PATCH, CHKP, PR64363] Don't instrument functions we cannot copy

2015-01-15 Thread Ilya Enkovich
2015-01-15 16:07 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Thu, Jan 15, 2015 at 12:46 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch is to fix https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64363. Patch disables instrumentation for functions we cannot clone

[PATCH] Fix for PR64353

2015-01-14 Thread Ilya Enkovich
/ 2015-01-14 Ilya Enkovich ilya.enkov...@intel.com PR middle-end/64353 * ipa-prop.c (ipa_modify_call_arguments): Update SSA for vops after adding a load. gcc/testsuite/ 2015-01-14 Ilya Enkovich ilya.enkov...@intel.com PR middle-end/64353 * g++.dg/pr64353

Re: [PATCH] Fix for PR64353

2015-01-14 Thread Ilya Enkovich
On 14 Jan 15:35, Richard Biener wrote: On Wed, Jan 14, 2015 at 3:28 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, SRA gimple passes may add loads to functions with no SSA update. Later it causes ICE when function with not updated SSA is processed by gimple passes. This patch

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 17:49 GMT+03:00 Andreas Schwab sch...@suse.de: Ilya Enkovich enkovich@gmail.com writes: * gcc.dg/lto/lto.exp: Load mpx-dg.exp. * gcc.dg/lto/chkp-privatize_0.c: New. * gcc.dg/lto/chkp-privatize_1.c: New. xgcc: error: unrecognized command line option '-mmpx

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 18:53 GMT+03:00 Andreas Schwab sch...@suse.de: Ilya Enkovich enkovich@gmail.com writes: 2014-12-10 17:49 GMT+03:00 Andreas Schwab sch...@suse.de: Ilya Enkovich enkovich@gmail.com writes: * gcc.dg/lto/lto.exp: Load mpx-dg.exp. * gcc.dg/lto/chkp-privatize_0.c

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 19:49 GMT+03:00 Andreas Schwab sch...@suse.de: Ilya Enkovich enkovich@gmail.com writes: 2014-12-10 18:53 GMT+03:00 Andreas Schwab sch...@suse.de: Ilya Enkovich enkovich@gmail.com writes: 2014-12-10 17:49 GMT+03:00 Andreas Schwab sch...@suse.de: Ilya Enkovich enkovich

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 21:07 GMT+03:00 James Greenhalgh james.greenha...@arm.com: On Wed, Dec 10, 2014 at 05:13:22PM +, Andreas Schwab wrote: Ilya Enkovich enkovich@gmail.com writes: 2014-12-10 19:49 GMT+03:00 Andreas Schwab sch...@suse.de: Ilya Enkovich enkovich@gmail.com writes: 2014

Re: [PATCH, CHKP] Fix instrumentation clones privatization

2014-12-10 Thread Ilya Enkovich
2014-12-10 21:29 GMT+03:00 James Greenhalgh james.greenha...@arm.com: On Wed, Dec 10, 2014 at 06:19:08PM +, Ilya Enkovich wrote: 2014-12-10 21:07 GMT+03:00 James Greenhalgh james.greenha...@arm.com: In the interests of breaking us out of this loop... At least: {arm-none-linux-gnueabihf

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-12-09 Thread Ilya Enkovich
On 24 Nov 17:02, Ilya Enkovich wrote: Right. This works for both top level and multilib checks because failing test is used and CC is usually not set when it's called by the top level configure. If we configure with CC=... then it may go wrong. I left only target check in configure.tgt

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-12-09 Thread Ilya Enkovich
On 05 Dec 15:52, Jeff Law wrote: On 12/03/14 07:28, Ilya Enkovich wrote: #ifndef MPX_SPEC #define MPX_SPEC \ -%{!nostdlib:%{!nodefaultlibs: LIBMPX_SPEC }} +%{!nostdlib:%{!nodefaultlibs: LIBMPX_SPEC LIBMPXWRAPPERS_SPEC }} #endif Ugh. Somehow I missed that MPX_SPEC was in gcc.c

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-12-09 Thread Ilya Enkovich
2014-12-09 22:57 GMT+03:00 Jeff Law l...@redhat.com: On 12/09/14 01:24, Ilya Enkovich wrote: On 24 Nov 17:02, Ilya Enkovich wrote: Right. This works for both top level and multilib checks because failing test is used and CC is usually not set when it's called by the top level configure

Re: [PATCH, i386] Fix PR64003

2014-12-08 Thread Ilya Enkovich
2014-12-07 12:51 GMT+03:00 Richard Sandiford rdsandif...@googlemail.com: Ilya Enkovich enkovich@gmail.com writes: diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 88435d6..9019ed8 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -10958,6 +10958,24

Re: [PATCH, CHKP] Don't try to optimize bounds returned by strchr

2014-12-08 Thread Ilya Enkovich
2014-12-06 1:55 GMT+03:00 Jeff Law l...@redhat.com: On 12/02/14 06:40, Ilya Enkovich wrote: Hi, For strchr calls bounds of the first argument are considered as returned which is wrong because NULL may be returned. This patch fixes that. Bootstrapped and tested on x86_64-unknown-linux-gnu

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-12-08 Thread Ilya Enkovich
Ping 2014-11-26 15:35 GMT+03:00 Ilya Enkovich enkovich@gmail.com: On 25 Nov 15:03, Ilya Enkovich wrote: 2014-11-25 14:11 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich enkovich@gmail.com wrote: Ok, then it's get_for_asmname

Re: [PATCH, i386] Fix PR64003

2014-12-08 Thread Ilya Enkovich
On 08 Dec 11:30, Ilya Enkovich wrote: 2014-12-07 12:51 GMT+03:00 Richard Sandiford rdsandif...@googlemail.com: Ilya Enkovich enkovich@gmail.com writes: diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 88435d6..9019ed8 100644 --- a/gcc/config/i386/i386.md +++ b

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-12-08 Thread Ilya Enkovich
2014-12-09 0:00 GMT+03:00 Jeff Law l...@redhat.com: On 12/08/14 04:00, Ilya Enkovich wrote: 2014-11-26 Ilya Enkovich ilya.enkov...@intel.com PR bootstrap/63995 * tree-chkp.c (chkp_make_static_bounds): Share bounds var between nodes sharing assembler name. gcc

[PATCH, i386] Fix PR64003

2014-12-05 Thread Ilya Enkovich
and tested on x86_64-unknown-linux-gnu. Valgrind run for reproducer shows problem is fixed. OK for trunk? Thanks, Ilya -- 2014-12-05 Ilya Enkovich ilya.enkov...@intel.com * config/i386/i386.md (*jcc_1_bnd): New. (*jcc_2_bnd): New. (jump_bnd): New. (*jcc_1): Remove bnd

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-12-04 Thread Ilya Enkovich
On 02 Dec 12:21, Uros Bizjak wrote: On Tue, Dec 2, 2014 at 12:08 PM, Ilya Enkovich enkovich@gmail.com wrote: Having stage1 close to end, may we make some decision regarding this patch? Having a couple of working variants, may we choose and use one of them? I propose to wait

[PATCH] Fix the rest of PR target/64056

2014-12-04 Thread Ilya Enkovich
Hi, This patch adds a check for stpcpy function into gcc.target/i386/chkp-strlen-2.c test. make check RUNTESTFLAGS=i386.exp=chkp-strlen-2.c is OK. OK for trunk? Thanks, Ilya -- 2014-12-04 Ilya Enkovich ilya.enkov...@intel.com PR target/64056 * lib/target-supports.exp

Re: [PATCH] Fix the rest of PR target/64056

2014-12-04 Thread Ilya Enkovich
On 04 Dec 15:58, Rainer Orth wrote: Hi Ilya, This patch adds a check for stpcpy function into gcc.target/i386/chkp-strlen-2.c test. make check RUNTESTFLAGS=i386.exp=chkp-strlen-2.c is OK. OK for trunk? Thanks, Ilya -- 2014-12-04 Ilya Enkovich ilya.enkov...@intel.com

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-12-03 Thread Ilya Enkovich
2014-12-02 0:16 GMT+03:00 Jeff Law l...@redhat.com: On 11/24/14 07:06, Ilya Enkovich wrote: Normally GCC target libraries assigned to the FSF would use GPL+exception rather than LGPL (especially if the library might be linked in statically), to keep predictable what requirements are imposed

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-12-02 Thread Ilya Enkovich
On 05 Nov 11:00, Uros Bizjak wrote: On Wed, Nov 5, 2014 at 10:35 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, Having stage1 close to end, may we make some decision regarding this patch? Having a couple of working variants, may we choose and use one of them? I propose to wait

[PATCH, CHKP] Don't generate bndret for not instrumented calls

2014-12-02 Thread Ilya Enkovich
/ 2014-12-02 Ilya Enkovich ilya.enkov...@intel.com * tree-chkp.c (chkp_call_returns_bounds_p): New. (chkp_build_returned_bound): Use zero bounds as returned by calls not returning bounds. gcc/testsuite/ 2014-12-02 Ilya Enkovich ilya.enkov...@intel.com

[PATCH, CHKP] Don't try to optimize bounds returned by strchr

2014-12-02 Thread Ilya Enkovich
Hi, For strchr calls bounds of the first argument are considered as returned which is wrong because NULL may be returned. This patch fixes that. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2014-12-02 Ilya Enkovich ilya.enkov...@intel.com

[PATCH, CHKP] Keep instrumentation references consistency when merging cgraph nodes

2014-12-02 Thread Ilya Enkovich
-pointer-bounds -mmpx'. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2014-12-02 Ilya Enkovich ilya.enkov...@intel.com * lto-cgraph.c (input_cgraph_1): Don't break existing instrumentation clone references. * lto/lto-symtab.c

[PATCH, CHKP] Fix instrumentation clones privatization

2014-12-02 Thread Ilya Enkovich
-- gcc/ 2014-12-02 Ilya Enkovich ilya.enkov...@intel.com * lto/lto-partition.c (privatize_symbol_name): Correctly privatize instrumentation clones. gcc/testsuite/ 2014-12-02 Ilya Enkovich ilya.enkov...@intel.com * gcc.dg/lto/lto.exp: Load mpx-dg.exp. * gcc.dg

[PATCH] Fix PR target/64055

2014-12-01 Thread Ilya Enkovich
Hi, This patch fixes ICE in chkp_find_bound_slots_1 by checking for non constant values in array domain. Bootstrapped on x86_64-unknown-linux-gnu with Ada. gnat.dg/derived_aggregate.adb is a new pass. OK for trunk? Thanks, Ilya -- 2014-12-01 Ilya Enkovich ilya.enkov...@intel.com

Re: [PATCH] Fix PR target/64055

2014-12-01 Thread Ilya Enkovich
2014-12-01 14:11 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Mon, Dec 1, 2014 at 10:33 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes ICE in chkp_find_bound_slots_1 by checking for non constant values in array domain. Bootstrapped on x86_64-unknown-linux

Re: [PATCH] Fix PR lto/64075

2014-11-27 Thread Ilya Enkovich
2014-11-27 19:55 GMT+03:00 Mike Stump mikest...@comcast.net: On Nov 26, 2014, at 1:35 AM, Ilya Enkovich enkovich@gmail.com wrote: This patch fixes LTO streamers which were not adjusted when function_code field was extended up to 12 bits. OK for trunk after bootstrap and check? Please

[PATCH] Fix PR lto/64075

2014-11-26 Thread Ilya Enkovich
Hi, This patch fixes LTO streamers which were not adjusted when function_code field was extended up to 12 bits. OK for trunk after bootstrap and check? Thanks, Ilya -- gcc/ 2014-11-26 Ilya Enkovich ilya.enkov...@intel.com * tree-streamer-in.c (unpack_ts_function_decl_value_fields

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-26 Thread Ilya Enkovich
On 25 Nov 15:03, Ilya Enkovich wrote: 2014-11-25 14:11 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich enkovich@gmail.com wrote: Ok, then it's get_for_asmname (). That said - the above loops look bogus to me. Honza - any better

[PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Ilya Enkovich
Hi, This patch makes optimization for bounds lifetime reduction to ignore debug stetments. This fixes stage2 and stage3 comparision for instrumented boostrap. OK for trunk? Thanks, Ilya -- 2014-11-26 Ilya Enkovich ilya.enkov...@intel.com PR bootstrap/63995 * tree-chkp

Re: [PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Ilya Enkovich
On 26 Nov 13:46, Jakub Jelinek wrote: On Wed, Nov 26, 2014 at 03:41:46PM +0300, Ilya Enkovich wrote: Hi, This patch makes optimization for bounds lifetime reduction to ignore debug stetments. This fixes stage2 and stage3 comparision for instrumented boostrap. OK for trunk? Please

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-26 Thread Ilya Enkovich
2014-11-26 19:07 GMT+03:00 Jan Hubicka hubi...@ucw.cz: On 25 Nov 15:03, Ilya Enkovich wrote: 2014-11-25 14:11 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich enkovich@gmail.com wrote: Ok, then it's get_for_asmname

[PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-25 Thread Ilya Enkovich
Hi, This patch partly fixes PR bootstrap/63995 by avoiding duplicating static bounds vars. With this fix bootstrap still fails at stage 2 and 3 comparison. Bootstrapped and checked on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2014-11-25 Ilya Enkovich ilya.enkov

[PATCH, PR64056, i386] Fix chkp tests requiring mempcpy

2014-11-25 Thread Ilya Enkovich
Hi, This patch adds check for mempcpy availability for tests requiring it. Checked with RUNTESTFLAGS=--target_board='unix{-m32,}' i386.exp=chkp-*. OK for trunk? Thanks, Ilya -- 2014-11-25 Ilya Enkovich ilya.enkov...@intel.com PR target/64056 * gcc.target/i386/chkp-strlen-4

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-25 Thread Ilya Enkovich
2014-11-25 12:43 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 9:45 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch partly fixes PR bootstrap/63995 by avoiding duplicating static bounds vars. With this fix bootstrap still fails at stage 2 and 3

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

2014-11-25 Thread Ilya Enkovich
2014-11-25 14:11 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 11:19 AM, Ilya Enkovich enkovich@gmail.com wrote: 2014-11-25 12:43 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 25, 2014 at 9:45 AM, Ilya Enkovich enkovich@gmail.com

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-24 Thread Ilya Enkovich
On 21 Nov 23:20, Joseph Myers wrote: On Fri, 21 Nov 2014, Ilya Enkovich wrote: +# Disable libmpx on unsupported systems. +if test -d ${srcdir}/libmpx; then +if test x$enable_libmpx = x; then + AC_MSG_CHECKING([for libmpx support]) + if (srcdir=${srcdir}/libmpx

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-24 Thread Ilya Enkovich
On 21 Nov 23:32, Joseph Myers wrote: On Fri, 21 Nov 2014, Ilya Enkovich wrote: * c-family/c.opt (static-libmpxwrappers): New. New options need documenting in invoke.texi. This includes driver options. I'll include it into patch with all checker options documented bacause

Re: [PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-24 Thread Ilya Enkovich
On 18 Nov 19:42, Ilya Enkovich wrote: On 18 Nov 16:23, Joseph Myers wrote: On Tue, 18 Nov 2014, Ilya Enkovich wrote: +@item -fcheck-pointer-bounds +@opindex fcheck-pointer-bounds +@opindex fno-check-pointer-bounds +Enable Pointer Bounds Checker instrumentation. Each memory

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-21 Thread Ilya Enkovich
On 19 Nov 21:11, Ilya Enkovich wrote: 2014-11-19 20:55 GMT+03:00 Jeff Law l...@redhat.com: On 11/19/14 07:15, Ilya Enkovich wrote: -- 2014-11-19 Ilya Enkovich ilya.enkov...@intel.com * Makefile.def: Add libmpx. * configure.ac: Add libmpx. * Makefile.in

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-21 Thread Ilya Enkovich
On 18 Nov 14:15, Jeff Law wrote: On 11/18/14 09:48, Ilya Enkovich wrote: On 15 Nov 00:10, Jeff Law wrote: On 11/14/14 10:26, Ilya Enkovich wrote: Hi, This patch introduces a simple library with several wrappers to be used with MPX and Pointer Bounds Checker. Wrappers allow to obtain

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-21 Thread Ilya Enkovich
2014-11-21 20:45 GMT+03:00 Jeff Law l...@redhat.com: On 11/20/14 09:40, Jakub Jelinek wrote: On Thu, Nov 20, 2014 at 07:36:03PM +0300, Ilya Enkovich wrote: Hi, MPX runtime checks some feature bits in order to check MPX is fully supported. Runtime does it by cpuid calls

[PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-20 Thread Ilya Enkovich
-- gcc/ 2014-11-20 Ilya Enkovich ilya.enkov...@intel.com * config/i386/cpuid.h (bit_MPX): New. (bit_BNDREGS): New. (bit_BNDCSR): New. * config/i386/i386.c (processor_features): Add F_XSAVE, F_OSXSAVE, F_MPX, F_BNDREGS, F_BNDCSR. (isa_names_table

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-19 Thread Ilya Enkovich
On 13 Nov 20:56, Joseph Myers wrote: On Thu, 13 Nov 2014, Ilya Enkovich wrote: You can leave it as a single library - it's just that imposes libgcc-like constraints on what the library does and how it does things, so as to be usable for arbitrary programs built with MPX (e.g. using

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-19 Thread Ilya Enkovich
2014-11-19 20:55 GMT+03:00 Jeff Law l...@redhat.com: On 11/19/14 07:15, Ilya Enkovich wrote: -- 2014-11-19 Ilya Enkovich ilya.enkov...@intel.com * Makefile.def: Add libmpx. * configure.ac: Add libmpx. * Makefile.in: Regenerate. * configure: Regenerate

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-18 Thread Ilya Enkovich
2014-11-18 5:56 GMT+03:00 Jeff Law l...@redhat.com: On 11/17/14 13:43, Ilya Enkovich wrote: I don't fully understand how this problem appears. Is it fully AIX specific and doesn't affect any other target? May we put all _CHKP codes to the end of enum and ignore them by AIX? Limiting number

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-18 Thread Ilya Enkovich
2014-11-18 15:04 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 18, 2014 at 11:51 AM, Ilya Enkovich enkovich@gmail.com wrote: 2014-11-18 5:56 GMT+03:00 Jeff Law l...@redhat.com: On 11/17/14 13:43, Ilya Enkovich wrote: I don't fully understand how this problem appears

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-18 Thread Ilya Enkovich
2014-11-18 15:18 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 18, 2014 at 1:13 PM, Ilya Enkovich enkovich@gmail.com wrote: 2014-11-18 15:04 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Nov 18, 2014 at 11:51 AM, Ilya Enkovich enkovich@gmail.com wrote

Re: [PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-18 Thread Ilya Enkovich
On 15 Nov 00:16, Jeff Law wrote: On 11/14/14 10:29, Ilya Enkovich wrote: Hi, This patch adds wrapper calls. It's simply achieved by using proper name for builtin clones. Patches apply over builtins instrumentation series. Thanks, Ilya -- 2014-11-14 Ilya Enkovich ilya.enkov

Re: [PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-18 Thread Ilya Enkovich
On 18 Nov 16:23, Joseph Myers wrote: On Tue, 18 Nov 2014, Ilya Enkovich wrote: +@item -fcheck-pointer-bounds +@opindex fcheck-pointer-bounds +@opindex fno-check-pointer-bounds +Enable Pointer Bounds Checker instrumentation. Each memory reference +is instrumented with checks

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-18 Thread Ilya Enkovich
On 15 Nov 00:10, Jeff Law wrote: On 11/14/14 10:26, Ilya Enkovich wrote: Hi, This patch introduces a simple library with several wrappers to be used with MPX and Pointer Bounds Checker. Wrappers allow to obtain, copy and just keep alive bounds whrough widely use library calls

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 1/5] Builtin codes and decls

2014-11-17 Thread Ilya Enkovich
On 15 Nov 00:03, Jeff Law wrote: On 11/14/14 01:22, Ilya Enkovich wrote: I don't think I'm hiding some problem here. Builtin function calls may be removed during various optimizations. Therefore we may remove all calls to some instrumented builtins and corresponding cgraph_node is removed

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 2/5] Instrument builtin calls

2014-11-17 Thread Ilya Enkovich
On 14 Nov 23:58, Jeff Law wrote: On 11/14/14 01:06, Ilya Enkovich wrote: - /* Avoid instrumented builtin functions for now. Due to IPA - it also means we have to avoid instrumentation of indirect - calls. */ - if (fndecl DECL_BUILT_IN_CLASS (fndecl) != NOT_BUILT_IN

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 5/5] Support instrumented calls in strlen pass

2014-11-17 Thread Ilya Enkovich
On 14 Nov 23:40, Jeff Law wrote: On 11/06/14 05:39, Ilya Enkovich wrote: Hi, This patch adds support of instrumented function calls into strlen pass. Whole series pass bootstrap and check on linux-x86_64. OK for trunk? Thanks, Ilya -- gcc/ 2014-11-06 Ilya Enkovich ilya.enkov

Re: [BUILDROBOT] Build breakage in builtin.c (was: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls)

2014-11-17 Thread Ilya Enkovich
On 17 Nov 16:12, Jan-Benedict Glaw wrote: On Mon, 2014-11-17 15:59:41 +0100, Markus Trippelsdorf mar...@trippelsdorf.de wrote: On 2014.11.17 at 15:52 +0100, Jan-Benedict Glaw wrote: On Thu, 2014-11-06 15:24:59 +0300, Ilya Enkovich enkovich@gmail.com wrote: [...] It seems

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-17 Thread Ilya Enkovich
2014-11-17 21:22 GMT+03:00 David Edelsohn dje@gmail.com: Ilya, Thanks for fixing the reference to BNDmode. However, the patch causes another problem that breaks bootstrap on AIX. All of the builtins are emitted as an enum in debug information and the CHKP enums now cause an overflow in

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-17 Thread Ilya Enkovich
2014-11-17 21:41 GMT+03:00 Jeff Law l...@redhat.com: On 11/17/14 11:22, David Edelsohn wrote: However, the patch causes another problem that breaks bootstrap on AIX. All of the builtins are emitted as an enum in debug information and the CHKP enums now cause an overflow in the debug data on

Re: [PATCH] Fix for PR63766 (handle removed functions in do_per_function_toporder)

2014-11-17 Thread Ilya Enkovich
On 17 Nov 13:32, Richard Biener wrote: On Mon, Nov 10, 2014 at 4:48 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, Here is a fix for PR63766. Currently all functions are transformed into SSA before local optimizations and it allows function to be inlined and removed before

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 2/5] Instrument builtin calls

2014-11-14 Thread Ilya Enkovich
2014-11-14 9:49 GMT+03:00 Jeff Law l...@redhat.com: On 11/06/14 05:10, Ilya Enkovich wrote: Hi, This patch enables instrumentation of chosen builtin calls. Thanks, Ilya -- 2014-11-06 Ilya Enkovich ilya.enkov...@intel.com * ipa-chkp.c (chkp_versioning): Clone builtin functions

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 1/5] Builtin codes and decls

2014-11-14 Thread Ilya Enkovich
2014-11-14 9:43 GMT+03:00 Jeff Law l...@redhat.com: On 11/06/14 04:48, Ilya Enkovich wrote: -- 2014-11-06 Ilya Enkovich ilya.enkov...@intel.com * tree-core.h (built_in_class): Add builtin codes to be used by Pointer Bounds Checker for instrumented builtin functions

[PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-14 Thread Ilya Enkovich
Enkovich ilya.enkov...@intel.com * gcc.c (MPX_SPEC): Add wrappers library. libmpx/ 2014-11-14 Ilya Enkovich ilya.enkov...@intel.com * Makefile.am (SUBDIRS): New. (MAKEOVERRIDES): New. * Makefile.in: Regenerate. * configure.ac: Add mpxintr/Makefile

[PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-14 Thread Ilya Enkovich
Hi, This patch adds wrapper calls. It's simply achieved by using proper name for builtin clones. Patches apply over builtins instrumentation series. Thanks, Ilya -- 2014-11-14 Ilya Enkovich ilya.enkov...@intel.com * c-family/c.opt (fchkp-use-wrappers): New. * ipa-chkp.c

[PATCH, MPX wrappers 3/3] Tests

2014-11-14 Thread Ilya Enkovich
Hi, Here are few tests for MPX wrappers. Will add more in case patches #1,2 are OK. Thanks, Ilya -- 2014-11-14 Ilya Enkovich ilya.enkov...@intel.com * lib/mpx-dg.exp (mpx_link_flags): Set path to wrappers library. * gcc.target/i386/mpx/calloc-1-lbv.c: New

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-13 Thread Ilya Enkovich
2014-11-13 2:03 GMT+03:00 Joseph Myers jos...@codesourcery.com: On Thu, 13 Nov 2014, Ilya Enkovich wrote: It's hard to decide which of runtime functionality should be considered as basic and how it should be used. We may say that the only basic thing is hardware enabling which is enable_mpx

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-12 Thread Ilya Enkovich
On 11 Nov 20:25, Joseph Myers wrote: On Tue, 11 Nov 2014, Andi Kleen wrote: Joseph Myers jos...@codesourcery.com writes: On Tue, 11 Nov 2014, Ilya Enkovich wrote: Hi, This patch integrates MPX runtime library into GCC source tree. MPX runtime is responsible

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-12 Thread Ilya Enkovich
2014-11-13 0:40 GMT+03:00 Joseph Myers jos...@codesourcery.com: On Wed, 12 Nov 2014, Ilya Enkovich wrote: MPX runtime needs to be linked with programs using MPX because it initializes hardware. Without it all MPX instructions are just NOPs. Thus it's not an extra functionality

[PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-11 Thread Ilya Enkovich
-- 2014-11-11 Ilya Enkovich ilya.enkov...@intel.com * Makefile.def: Add libmpx. * configure.ac: Add libmpx. * Makefile.in: Regenerate. * configure: Regenerate. gcc/ 2014-11-11 Ilya Enkovich ilya.enkov...@intel.com * gcc.c (MPX_SPEC): New

Re: [PATCH, MPX runtime 2/2] Add MPX tests

2014-11-11 Thread Ilya Enkovich
2014-11-11 22:55 GMT+03:00 Jeff Law l...@redhat.com: On 11/11/14 11:42, Mike Stump wrote: On Nov 11, 2014, at 8:02 AM, Ilya Enkovich enkovich@gmail.com wrote: This patch adds simple runtime MPX tests. Make check shows no fails for mpx.exp suite for x86_64-unknown-linux-gnu{-m32,-mx32

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-11 Thread Ilya Enkovich
2014-11-11 23:02 GMT+03:00 Jeff Law l...@redhat.com: On 11/11/14 08:34, Ilya Enkovich wrote: Hi, This patch integrates MPX runtime library into GCC source tree. MPX runtime is responsible for initialization of MPX feature in HW, signal handling, reporting etc. Library is linked to codes

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-11 Thread Ilya Enkovich
2014-11-11 21:09 GMT+03:00 Joseph Myers jos...@codesourcery.com: On Tue, 11 Nov 2014, Joseph Myers wrote: You have lots of static writable variables. Are you sure all those variables are handled in a thread-safe way (e.g. only modified before any threads start)? Another general

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Ilya Enkovich
2014-11-10 14:53 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Sun, Nov 9, 2014 at 5:57 PM, Jack Howarth howarth.at@gmail.com wrote: Iain, It doesn't look like it will be that simple. If I replace the proposed patches with a change like... Index: gcc/system.h

[PATCH] Fix for PR63766 (handle removed functions in do_per_function_toporder)

2014-11-10 Thread Ilya Enkovich
on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2014-11-10 Ilya Enkovich ilya.enkov...@intel.com * passes.c (remove_cgraph_node_from_order): New. (do_per_function_toporder): Register cgraph removal hook. gcc/testsuite/ 2014-11-10 Ilya Enkovich

[PATCH, i386, MPX] Add target filter for MPX tests

2014-11-06 Thread Ilya Enkovich
tests on x86_64 and x32. OK for trunk? Thanks, Ilya -- gcc/testsuite/ 2014-11-06 Ilya Enkovich ilya.enkov...@intel.com * lib/mpx-dg.exp: New. * gcc.target/i386/i386.exp: Load mpx-dg.exp. * gcc.target/i386/chkp-builtins-1.c: Require mpx target. * gcc.target/i386

[PATCH, Pointer Bounds Checker, Builtins instrumentation 1/5] Builtin codes and decls

2014-11-06 Thread Ilya Enkovich
. This patch introduces new builtin codes, functions for builtin clones creation and modifies LTO streamer. Thanks, Ilya -- 2014-11-06 Ilya Enkovich ilya.enkov...@intel.com * tree-core.h (built_in_class): Add builtin codes to be used by Pointer Bounds Checker for instrumented builtin

[PATCH, Pointer Bounds Checker, Builtins instrumentation 2/5] Instrument builtin calls

2014-11-06 Thread Ilya Enkovich
Hi, This patch enables instrumentation of chosen builtin calls. Thanks, Ilya -- 2014-11-06 Ilya Enkovich ilya.enkov...@intel.com * ipa-chkp.c (chkp_versioning): Clone builtin functions. (chkp_instrument_normal_builtin): New. (chkp_add_bounds_to_call_stmt): Support

[PATCH, Pointer Bounds Checker, Builtins instrumentation 3/5] Expand instrumented builtin calls

2014-11-06 Thread Ilya Enkovich
patches are performance ones. Thanks, Ilya -- 2014-11-06 Ilya Enkovich ilya.enkov...@intel.com * builtins.c (expand_builtin_memcpy_args): New. (expand_builtin_memcpy): Call expand_builtin_memcpy_args. (expand_builtin_memcpy_with_bounds): New

[PATCH, Pointer Bounds Checker, Builtins instrumentation 4/5] Use alternative instrumented string function calls

2014-11-06 Thread Ilya Enkovich
Hi, This patch adds instrumentation optimization to use string function with no checks and/or bounds copy. Thanks, Ilya -- gcc/ 2014-11-06 Ilya Enkovich ilya.enkov...@intel.com * tree-chkp-opt.c (chkp_get_nobnd_fndecl): New. (chkp_get_nochk_fndecl): New

[PATCH, Pointer Bounds Checker, Builtins instrumentation 5/5] Support instrumented calls in strlen pass

2014-11-06 Thread Ilya Enkovich
Hi, This patch adds support of instrumented function calls into strlen pass. Whole series pass bootstrap and check on linux-x86_64. OK for trunk? Thanks, Ilya -- gcc/ 2014-11-06 Ilya Enkovich ilya.enkov...@intel.com * tree-ssa-strlen.c: include ipa-chkp.h

Re: [PATCH, i386] Add prefixes avoidance tuning for silvermont target

2014-11-05 Thread Ilya Enkovich
Hi, Having stage1 close to end, may we make some decision regarding this patch? Having a couple of working variants, may we choose and use one of them? Thanks, Ilya 2014-07-15 17:38 GMT+04:00 Uros Bizjak ubiz...@gmail.com: On Tue, Jul 15, 2014 at 1:01 PM, Ilya Enkovich enkovich@gmail.com

[committed] MAINTAINERS: add myself to write-after-approval list

2014-10-31 Thread Ilya Enkovich
2014-10-31 Ilya Enkovich ilya.enkov...@intel.com * MAINTAINERS (Write After Approval): Add myself. Index: MAINTAINERS === --- MAINTAINERS (revision 216948) +++ MAINTAINERS (revision 216952) @@ -373,6 +373,7 @@ Bernd

Re: [PATCH, Pointer Bounds Checker 14/x] Passes [1/n] Expand interfaces

2014-10-30 Thread Ilya Enkovich
On 29 Oct 23:37, Jeff Law wrote: On 10/15/14 11:54, Ilya Enkovich wrote: Thanks for review! I see no more patches not reviewed at all. I see 4 more patches requiring approve before I can start a merge. Two of them are parts of split #14 (Passes): #14.3 (Helper functions) and #14.16

Re: [PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-29 Thread Ilya Enkovich
On 29 Oct 10:34, Richard Biener wrote: On Tue, Oct 28, 2014 at 5:14 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes PR63664 and PR63574. Problem is in NULL types for labels not handled by ICF properly. I assume it is OK for labels to have NULL type and added

Re: [PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-29 Thread Ilya Enkovich
2014-10-29 17:01 GMT+03:00 Martin Liška mli...@suse.cz: On 10/29/2014 02:45 PM, Ilya Enkovich wrote: On 29 Oct 10:34, Richard Biener wrote: On Tue, Oct 28, 2014 at 5:14 PM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes PR63664 and PR63574. Problem is in NULL types

[PATCH, IPA ICF] Fix PR63664, PR63574 (segfault in ipa-icf pass)

2014-10-28 Thread Ilya Enkovich
/ 2014-10-28 Ilya Enkovich ilya.enkov...@intel.com PR ipa/63664 PR bootstrap/63574 * ipa-icf-gimple.c (func_checker::compatible_types_p): Allow NULL args. gcc/testsuite/ 2014-10-28 Ilya Enkovich ilya.enkov...@intel.com PR ipa/63664 * gcc.dg/ipa

[PATCH, Pointer Bounds Checker 40/x] Support in IPA ICF

2014-10-28 Thread Ilya Enkovich
clean runs of instrumented (run in NOP mode) and not isntrumented SPEC2000 and SPEC2006. I also tried to bootstrap it for Darwin but unfortunately trunk fails to bootstrap there even with patches from PR63534 applied. Error is the same for mpx branch. Thanks, Ilya -- 2014-10-28 Ilya Enkovich

Re: [PATCH, Pointer Bounds Checker 29/x] Debug info

2014-10-15 Thread Ilya Enkovich
2014-06-18 0:56 GMT+04:00 Jeff Law l...@redhat.com: On 06/11/14 02:50, Ilya Enkovich wrote: Hi, This patch skips all bounds during debug info generation. Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-06-11 Ilya Enkovich ilya.enkov...@intel.com

<    1   2   3   4   5   6   7   8   9   10   >