adding support for vxworks os variants

2014-05-19 Thread Olivier Hainque
Hello, Here is a quick description of changes we would like to contribute to the VxWorks ports, with a preliminary query to maintainers on what would be the most appropriate form for such changes to be deemed acceptable: On a few CPU families, variants of the VxWorks OS are available.

Re: adding support for vxworks os variants

2014-05-19 Thread Olivier Hainque
On May 19, 2014, at 15:41 , Olivier Hainque hain...@adacore.com wrote: For vxsim or smp, having entirely separate toolchains with different triplets for so minor differences seemed overkill and impractical for users, so we have added -vxsim and -vxsmp command line options to our toolchains

Re: back to the Ada target vs target_alias issue wrt target pairs

2013-09-13 Thread Olivier Hainque
Hello Dominique, On Sep 13, 2013, at 20:03 , domi...@lps.ens.fr (Dominique Dhumieres) wrote: The bootstrap failure is fixed with the following patch: [macbook] gcc/work% diff -up ../_clean/gcc/ada/gcc-interface/Makefile.in gcc/ada/gcc-interface/Makefile.in ---

Re: back to the Ada target vs target_alias issue wrt target pairs

2013-09-13 Thread Olivier Hainque
On Sep 13, 2013, at 23:35 , Olivier Hainque hain...@adacore.com wrote: # Darwin (Mac OS X) -ifeq ($(strip $(filter-out darwin%,$(target_cpu))),) +ifeq ($(strip $(filter-out darwin%,$(target_os))),) 2) I don't have write access. I'll take care of committing. Thanks! rev 202578. Thanks

back to the Ada target vs target_alias issue wrt target pairs

2013-09-12 Thread Olivier Hainque
Regards, Olivier 2013-10-11 Thomas Schwinge tho...@codesourcery.com Olivier Hainque hain...@adacore.com * gcc-interface/Makefile.in: Import target_cpu, target_vendor, target_os and their host_ counterparts. Remove host_canonical and target_cpu_default, unused

Re: SPE detection broken on Linux (bits/predefs.h: No such file or directory)

2013-06-12 Thread Olivier Hainque
On Jun 11, 2013, at 16:50 , David Edelsohn dje@gmail.com wrote: I solved this in gcc/config/rs6000/t-linux by replacing the line MULTIARCH_DIRNAME = powerpc-linux-gnuspe$(if $(findstring rs6000/e500-double.h, $(tm_file_list)),,v1) with MULTIARCH_DIRNAME = powerpc-linux-gnuspe$(if

Re: [ada, build] host/target configuration

2013-06-04 Thread Olivier Hainque
On Jun 3, 2013, at 22:59 , Olivier Hainque hain...@adacore.com wrote: I suggest another approach: if there are significant differences between the run-time systems, they ought to be preserved in the canonical target names. So, adjust config.sub so that it preserve them, and then we can

Re: [ada, build] host/target configuration

2013-06-03 Thread Olivier Hainque
On Jun 2, 2013, at 21:18 , Alexandre Oliva aol...@redhat.com wrote: - Use target_alias explicitly just at the points where we know that we need to depart from the canonical name I suggest another approach: if there are significant differences between the run-time systems, they ought to be

Re: [ada, build] host/target configuration

2013-05-31 Thread Olivier Hainque
On May 30, 2013, at 23:08 , Olivier Hainque hain...@adacore.com wrote: The idea of the target-target_alias change in gcc-interface/Makefile.in for Ada was to let us still distinguish for the purpose of the Ada RTSes in particular. This happens to be significant in a limited amount of cases

Re: [ada, build] host/target configuration

2013-05-30 Thread Olivier Hainque
On May 30, 2013, at 15:44 , Arnaud Charlet char...@adacore.com wrote: In other words, this change will impact basically all targets, so needs either much more testing, or more review, which is on going. Part of the issue comes from the need to support some targets with non-canonical names

Re: Fix PR 56077

2013-04-05 Thread Olivier Hainque
On Apr 5, 2013, at 12:21 , Eric Botcazou ebotca...@adacore.com wrote: I don't know whether backporting this would be better than reverting the offending change as just done on 4.7. I presume that you meant on the 4.6 branch. Arf, indeed, thanks for correcting :)

Re: Fix PR 56077

2013-04-05 Thread Olivier Hainque
On Apr 5, 2013, at 13:22 , Andrey Belevantsev a...@ispras.ru wrote: http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01625.html I don't know whether backporting this would be better than reverting the offending change as just done on 4.7. I'd say for 4.6 the best way is to revert. PR

Re: Fix PR 56077

2013-04-05 Thread Olivier Hainque
On Apr 5, 2013, at 15:40 , Jakub Jelinek ja...@redhat.com wrote: As written in PR56848, the patch should be reverted for 4.7.3 and reapplied together with the additional fix after 4.7.3 is released (before 4.7.3 release there is just too short time to do anything else, while before 4.7.4

Re: Fix PR 56077

2013-04-05 Thread Olivier Hainque
On Apr 5, 2013, at 11:18 PM, Eric Botcazou wrote: Andrey, could you please take care of this ? I've reverted the patch after bootstrapping/regtesting on x86-64/Linux. Thanks Eric.

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-15 Thread Olivier Hainque
On Oct 15, 2012, at 15:12 , Kirill Yukhin kirill.yuk...@gmail.com wrote: I was able to bootstrap successfully with the patch. Checked in: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00581.html Thanks :)

Re: [PATCH, libstdc++] Fix missing gthr-default.h issue on libstdc++ configure

2012-10-11 Thread Olivier Hainque
Hello, The change apparently broke targets that have their gthr- header not in libgcc/ directly, quite a few. We are seeing failure on ppc-aix for example, which has ./libgcc/config/rs6000/gthr-aix.h We are also seeing failures while building a win32 canadian from linux, where we have

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Olivier Hainque
On Sep 4, 2012, at 22:42 , Hans-Peter Nilsson h...@bitrange.com wrote: Please, no inlining. Think of stack back-traces and their use when debugging. But, there was a talk at the GNU Tools Cauldron with related contents -

Re: fix thinko in tree-emutls, breaking tls support on vxworks

2012-08-06 Thread Olivier Hainque
On Jul 16, 2012, at 19:48 , Richard Henderson wrote: * tree-emutls.c (new_emutls_decl): When a var_section is requested by the target, attach the new decl to that, not to the template section. Ok. rev 190179, after a couple of weeks off. Thanks :)

Re: PR53914, rs6000 constraints and reload queries

2012-08-02 Thread Olivier Hainque
On Aug 1, 2012, at 16:04 , Ulrich Weigand wrote: I've been wondering about mode_dependent_address_p myself. It currently appears to cover two quite separate questions: - If I have a valid address, will it remain valid if I change its mode to something else? - If I have a valid address,

Re: PR53914, rs6000 constraints and reload queries

2012-08-01 Thread Olivier Hainque
On Jul 17, 2012, at 17:34 , Alan Modra wrote: The ICE is combine.c:5318:1: error: insn does not satisfy its constraints: (insn 4211 1484 1493 140 (set (mem/c:DI (plus:SI (reg/f:SI 19 19 [2736]) (const_int 32760 [0x7ff8])) [3 __gcov0.subst+816 S8 A64]) (reg:DI 6 6))

Re: PR53914, rs6000 constraints and reload queries

2012-08-01 Thread Olivier Hainque
On Aug 1, 2012, at 13:18 , Alan Modra wrote: http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01668.html. I like the idea. :-) It is worth pursuing for code improvement we'll see even if we avoid the o constraint everywhere. For example, long long llo (long long *x) { return x[4095];

refine libstdc++ configure check on mutex_timedlock

2012-07-06 Thread Olivier Hainque
Hello, On a gcc 4.7 tree, we are witnessing build failures on Aix 5.2 with libstdc++ failing on ...pthread/libstdc++-v3/include/powerpc-ibm-aix5.2.0.0/bits/gthr-posix.h:789:69: error: 'pthread_mutex_timedlock' was not declared in this scope The anomaly is visible from the libstdc++

Re: refine libstdc++ configure check on mutex_timedlock

2012-07-06 Thread Olivier Hainque
On Jul 6, 2012, at 15:04 , David Edelsohn wrote: libstdc++-v3/ * acinclude.m4 (check for mutex_timelock): Check straight on _POSIX_TIMEOUTS, regardless of defined (_PTHREADS). * configure: Regenerate. It's okay with me, but I do not know who can approve it. Yes,

fix thinko in tree-emutls, breaking tls support on vxworks

2012-07-03 Thread Olivier Hainque
the patch (no error + __tls_y emitted in .tls_vars). Also bootstrapped and regression tested on x86_64-linux. OK to commit ? Thanks in advance, With Kind Regards, Olivier 2012-07-03 Olivier Hainque hain...@adacore.com * tree-emutls.c (new_emutls_decl): When a var_section is requested

Re: ping x3 : latch mem to reg before multi-access in convert_move

2012-06-26 Thread Olivier Hainque
Hello Richard, On Jun 25, 2012, at 20:36 , Richard Henderson wrote: Can you explain the sequence that results in multiple memory references? Because I can't see how it can... Compared to the point at which we were observing the problem, the code has changed a bit in this area though not so

Re: ping x3 : latch mem to reg before multi-access in convert_move

2012-06-26 Thread Olivier Hainque
On Jun 26, 2012, at 17:28 , Richard Henderson wrote: Ah, right, since convert_to_mode can just reshuffle the MEM. The patch is ok. Great, will commit shortly. Thanks a lot for your prompt feedback, With Kind Regards, Olivier

ping x3 : latch mem to reg before multi-access in convert_move

2012-06-24 Thread Olivier Hainque
Hello, ping # 3 for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00298.html This is related to convert-move possibly emitting a sequence with multiple accesses to one input, triggering multiple memory accesses when that input happens to be a mem. The original problem we had with this was the

ping x2: fix mem+32760 ICE on powerpc - introduce predicates weaker than mode_dependent_address_p

2012-06-24 Thread Olivier Hainque
for your feedback, Olivier On Apr 26, 2012, at 11:30 , Olivier Hainque wrote: ... a number of places in the compiler use the mode_dependent_address_p predicate to actually check for weaker necesssary conditions. Typically, a few places need to check that a MEM access remains valid when just

Re: [Ada] fix use of PICFLAG for Ada library variants

2012-06-14 Thread Olivier Hainque
Hello Jakub, On Jun 14, 2012, at 18:22 , Jakub Jelinek wrote: 2012-06-10 Olivier Hainque hain...@adacore.com * Makefile.in (GNATLIBCFLAGS_FOR_C): Remove $(PIC_FLAG_FOR_TARGET). You've apparently committed during 4.7 branch freeze a variant of this patch to the 4.7 branch as well

Re: [Ada] fix use of PICFLAG for Ada library variants

2012-06-14 Thread Olivier Hainque
On Jun 14, 2012, at 19:00 , Jakub Jelinek wrote: For reverting it is too late, 4.7.1 has been released already with the bug. I'm already bootstrapping/regtesting the simple one-liner, if it works, will post it. Thanks. So sorry again :-( Olivier

Re: [Ada] fix use of PICFLAG for Ada library variants

2012-06-14 Thread Olivier Hainque
On Jun 14, 2012, at 19:50 , Jakub Jelinek wrote: Here is what I've committed as obvious after bootstrap/regtest on x86_64-linux. 2012-06-14 Jakub Jelinek ja...@redhat.com * gcc-interface/Makefile.in (gnatlib-shared-default): Append $(PICFLAG_FOR_TARGET) to

[Ada] fix use of PICFLAG for Ada library variants

2012-06-11 Thread Olivier Hainque
-06-10 Olivier Hainque hain...@adacore.com * Makefile.in (GNATLIBCFLAGS_FOR_C): Remove $(PIC_FLAG_FOR_TARGET). (gnatlib-shared-default): Add $(PIC_FLAG_FOR_TARGET) to GNATLIBCFLAGS_FOR_C passed to gnatlib. (gnatlib-shared-win32): Likewise. (gnatlib-shared

fix t-vxworks fetching of $(MULTIDIR) for libgcc

2012-06-04 Thread Olivier Hainque
? Thanks in advance, Olivier 2012-06-04 Olivier Hainque hain...@adacore.com libgcc/ * config/t-vxworks (LIBGCC2_INCLUDES): Remove extraneous $ in attempt at fetching the value of MULTIDIR. multidir.diff Description: Binary data

Re: restore do { mistakenly taken out in SUBSUBTARGET_OVERRIDE_OPTIONS for ppc-vxworks

2012-06-02 Thread Olivier Hainque
On Jun 1, 2012, at 19:09 , Eric Botcazou wrote: * config/rs6000/vxworks.h (SUBSUBTARGET_OVERRIDE_OPTIONS): Restore the do { part of the do-while(0) loop. This is needed on the 4.7 branch as well. Hmm, I don't think so. The removal was part of the E500 related reorg, which was

restore do { mistakenly taken out in SUBSUBTARGET_OVERRIDE_OPTIONS for ppc-vxworks

2012-06-01 Thread Olivier Hainque
This fixes a glitch introduced by me with rev 187581. Committing as obvious. 2012-07-01 Olivier Hainque hain...@adacore.com * config/rs6000/vxworks.h (SUBSUBTARGET_OVERRIDE_OPTIONS): Restore the do { part of the do-while(0) loop. vxoverride.diff Description: Binary data

Re: use longcall to abort from !pic trampoline setup on ppc-vxworks

2012-05-25 Thread Olivier Hainque
Hello David, On May 25, 2012, at 03:25 , David Edelsohn wrote: libgcc/ * config/rs6000/vxworks/tramp.S (trampoline_setup): Use a longcall sequence in the non pic case on VxWorks. + addis 11, 0,JUMP_TARGET(abort)@ha Why do you use the addis mnemonic instead of

ping: fix mem+32760 ICE on powerpc - introduce predicates weaker than mode_dependent_address_p

2012-05-25 Thread Olivier Hainque
, at 11:30 , Olivier Hainque wrote: ... a number of places in the compiler use the mode_dependent_address_p predicate to actually check for weaker necesssary conditions. Typically, a few places need to check that a MEM access remains valid when just narrowing the mode, while

Re: unwind.h installation causes rebuilds

2012-05-25 Thread Olivier Hainque
Hello Michael, On May 25, 2012, at 16:30 , Michael Matz wrote: I've noticed that libitm is always rebuild with a non-bootstrap tree even with merely a sequence of two makes. The reason turns out to be that installation of unwind.h from libgcc, which is always done with a simple make:

Re: unwind.h installation causes rebuilds

2012-05-25 Thread Olivier Hainque
On May 25, 2012, at 17:17 , Michael Matz wrote: This should have been fixed by rev 187839 ... Super, yes, that works. Great :) Though I still wonder if the whole copy-over-to-gcc business shouldn't be dependend on anything newly built. I can't see the use in copying over the same

Re: fix install-no-fixedincludes mishaps

2012-05-24 Thread Olivier Hainque
Olivier Hainque hain...@adacore.com libgcc/ * Makefile.in: move dependency on install-unwind_h from install-leaf to install. unwh.diff Description: Binary data

Re: fix install-no-fixedincludes mishaps

2012-05-24 Thread Olivier Hainque
by make clean. Can you send a patch for that? Sure. Attached. The use of a separate command for stamp removals is only to avoid an overlong line. 2012-05-24 Olivier Hainque hain...@adacore.com libgcc/ * Makefile.in (clean): Remove libgcc_tm.stamp as well. Use

Re: fix install-no-fixedincludes mishaps

2012-05-24 Thread Olivier Hainque
On May 24, 2012, at 16:32 , Paolo Bonzini wrote: libgcc/ * Makefile.in (clean): Remove libgcc_tm.stamp as well. Use a separate command for stamp removals. Ok, thanks. Committed. The other one also, on the 4.7 branch as well. Thanks for for prompt feedback. And thanks Ian

Re: fix install-no-fixedincludes mishaps

2012-05-24 Thread Olivier Hainque
On May 24, 2012, at 6:18 PM, Ian Lance Taylor wrote: * Makefile.in: move dependency on install-unwind_h from install-leaf to install. I don't see the final patch, but it sounds promising. :) Testing was good on my side and Paolo approved so this was checked in, rev 187839.

ping x2 : latch mem to reg before multi-access in convert_move

2012-05-24 Thread Olivier Hainque
Hello, Ping # 2 for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00298.html Thanks in advance, Olivier (sorry for a possible empty version of that message sent by mistake a few minutes ago) On Apr 5, 2012, at 17:30 , Olivier Hainque wrote: ... With a previous version of the compiler, we

ping x2: recognize .persistent.bss sections as bss

2012-05-24 Thread Olivier Hainque
Hello, Ping # 2 for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00833.html Thanks in advance, Olivier (sorry for a possible duplicate or empty version of that message a few minutes ago) On Apr 13, 2012, at 15:06 , Olivier Hainque wrote: For several years now, Ada has support

ping x2: use longcall to abort from !pic trampoline setup on ppc-vxworks

2012-05-24 Thread Olivier Hainque
Hello, Ping #2 for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00808.html Thanks in advance, Olivier (sorry for a duplicate or empty version of this message a few minutes ago) On Apr 13, 2012, at 10:08 , Olivier Hainque wrote: Relocation troubles (24bit reloc overflows) might show up when

Re: fix install-no-fixedincludes mishaps

2012-05-18 Thread Olivier Hainque
tested that when you specify --libexecdir=${exec_prefix}/lib, that works fine, and the result is still relocatable. Setting the variable this way is nevertheless confusing IMO, so what about 2012-05-18 Olivier Hainque hain...@adacore.com * Makefile.in (FLAGS_TO_PASS): Pass

Re: fix install-no-fixedincludes mishaps

2012-05-18 Thread Olivier Hainque
On May 18, 2012, at 17:59 , Paolo Bonzini wrote: * Makefile.in (FLAGS_TO_PASS): Pass $(libexecsubdir) instead of $(libsubdir) as libexecsubdir. Yes, ok. FLAGS_TO_PASS is only used by Ada until now. Installed, thanks :)

Re: remove TARGET_E500 and factorize SPE defaults computation in powerpc ports

2012-05-16 Thread Olivier Hainque
On May 16, 2012, at 03:10 , David Edelsohn wrote: Okay. revision 187581. Thanks!

Re: ping: Use sed -n … instead of sed s/…/p -e d in s-header-vars

2012-05-16 Thread Olivier Hainque
On May 16, 2012, at 08:29 , Paolo Bonzini wrote: Ok. Applied, Thanks Paolo :) Opinion on http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00274.html ? Thanks in advance, Olivier

Re: ping: Use sed -n … instead of sed s/…/p -e d in s-header-vars

2012-05-16 Thread Olivier Hainque
On May 16, 2012, at 11:47 , Paolo Bonzini wrote: install-no-fixedincludes: installdirs install-host-nogcc \ !install-target gcc-install-no-fixedincludes ... This is missing in the ChangeLog. Indeed. + install-no-fixedincludes: \ +stash-maybefixed-headers \ +stmp-int-hdrs \

Re: fix install-no-fixedincludes mishaps

2012-05-16 Thread Olivier Hainque
Regards, Olivier 2012-05-16 Olivier Hainque hain...@adacore.com toplevel/ * Makefile.tpl (gcc-no-fixedincludes): Rename into ... (gcc-install-no-fixedincludes): Now forwarder to local target in gcc/ (install-no-fixedincludes): Adjust accordingly

Re: fix install-no-fixedincludes mishaps

2012-05-16 Thread Olivier Hainque
is thus not installed any more and this is causing troubles for at least canadian builds. We fixed it with the attached patch in our tree. How does that look to you ? Many thanks in advance, Olivier 2012-05-16 Olivier Hainque hain...@adacore.com libgcc/ * Makefile.in

Re: fix install-no-fixedincludes mishaps

2012-05-16 Thread Olivier Hainque
On May 16, 2012, at 17:03 , Paolo Bonzini wrote: Ok, thanks! Great :-) All these are regressions, right? Right. Please commit them to 4.7 branch too. Will do. Thanks for your prompt and constructive feedback, With Kind Regards, Olivier

Re: remove TARGET_E500 and factorize SPE defaults computation in powerpc ports

2012-05-15 Thread Olivier Hainque
on powerpc-generic-linux-gnu. OK to commit ? With Kind Regards, Olivier 2012-05-15 Olivier Hainque hain...@adacore.com config/rs6000: * rs6000-opts.h (enum processor_type): Add PROCESSOR_PPC8548. * rs6000-cpus.def: Reference it for cpu=8548. * rs6000.md

Re: Use sed -n … instead of sed s/…/p -e d in s-header-vars

2012-05-15 Thread Olivier Hainque
Hello Hans, On May 15, 2012, at 05:22 , Hans-Peter Nilsson wrote: * Makefile.in (s-header-vars): Resort to -n instead of trailing -e d in sed invocation. Random non-maintainer comments: I'd suggest adding a nearby comment to avoid a future edit changing it back. Sure.

ping: Use sed -n … instead of sed s/…/p -e d in s-header-vars

2012-05-15 Thread Olivier Hainque
, 2012, at 18:55 , Olivier Hainque wrote: sed s/…/p -e d as used in s-header-vars doesn't work on at least ia64-hpux, where s/.../p only prints out if -n was requested as well. ... * Makefile.in (s-header-vars): Resort to -n instead of trailing -e d in sed invocation. sed-n.diff

Re: unwinding fallbacks for powerpc32 on aix 5.2 and 5.3

2012-05-14 Thread Olivier Hainque
On May 13, 2012, at 00:03 , David Edelsohn wrote: I forgot to ask, is there a non-Ada, target-specific testcase that you can add to ensure this functionality does not get broken? Thanks, David Something like that in cp/eh ? // { dg-do run { target { { *-*-aix5* } } } } // { dg-options

Re: unwinding fallbacks for powerpc32 on aix 5.2 and 5.3

2012-05-14 Thread Olivier Hainque
On May 12, 2012, at 16:43 , David Edelsohn wrote: Please do not create another definition of the register number for LR. Oh ... Earlier in the file it is defined as R_LR. Dropping in a completely self-contained chunk with its own naming is confusing. LR_REGNO is fine, but please define the

Re: unwinding fallbacks for powerpc32 on aix 5.2 and 5.3

2012-05-14 Thread Olivier Hainque
On May 14, 2012, at 15:14 , David Edelsohn wrote: Yes, something like that test. Should the test go in g++.dg/eh or in g++.target/powerpc? It's really about the general capability to have unwinding get through signal handlers. The same test (same sources) should work on other targets than

unwinding fallbacks for powerpc32 on aix 5.2 and 5.3

2012-05-11 Thread Olivier Hainque
(tested on 64bit 5.2 kernel nevertheless). Thanks in advance for your feedback, Cheers, Olivier 2012-05-11 Olivier Hainque hain...@adacore.com libgcc/ * config/rs6000/aix-unwind.h (ucontext_for): Helper for ... (ppc_aix_fallback_frame_state): New, implementation

Re: [PATCH] Remove TYPE_IS_SIZETYPE

2012-05-11 Thread Olivier Hainque
On May 10, 2012, at 14:00 , Richard Guenther wrote: Of course the mere existence of DECL_OFFSET_ALIGN complicates matters for no good reasons (well, at least I did not find a good use of it until now ...). I remember an old discussion about it ... hmm ...

remove TARGET_E500 and factorize SPE defaults computation in powerpc ports

2012-05-07 Thread Olivier Hainque
), ...) Thanks much in advance, Olivier 2012-05-07 Olivier Hainque hain...@adacore.com config/rs6000: * rs6000-opts.h (enum processor_type): Add PROCESSOR_PPC8548. * rs6000-cpus.def: Reference it for cpu=8548. * rs6000.md (cpu attribute definition): Add ppc8548

Re: remove TARGET_E500 and factorize SPE defaults computation in powerpc ports

2012-05-07 Thread Olivier Hainque
On May 7, 2012, at 15:57 , Olivier Hainque wrote: My first attempt at building there failed, with --target=powerpc-eabispe --with-cpu=8548 --enable-languages=c --disable-libada (internal compiler error on unwind-dw2.c) This failure reproduces with an unpatched tree as well, so

Re: remove TARGET_E500 and factorize SPE defaults computation in powerpc ports

2012-05-07 Thread Olivier Hainque
On May 7, 2012, at 18:59 , David Edelsohn wrote: Yes, exactly. If we can work through the fallout, this is exactly the type of cleanup I envisioned. Great :) Thanks, David Do you want a PR for the fallout ? It is not related to this patch at all. I can look into it further and make

Re: remove TARGET_E500 and factorize SPE defaults computation in powerpc ports

2012-05-07 Thread Olivier Hainque
On May 7, 2012, at 21:27 , Olivier Hainque wrote: Of course. That was actually my point in offering to open a PR, so that Alan (who did the nice recent reorg) can take it from there. He will certainly be more efficient than me in resolving this :) PR 53271

Re: fix spec function evaluations part of an outer string construction

2012-05-04 Thread Olivier Hainque
On May 3, 2012, at 22:50 , Joseph S. Myers wrote: -* gcc.c (eval_spec_function): Finalize/restore the current string obstack state as part of the context push/pop operations. OK. Installed, thanks :)

Re: strengthen protection against REG_EQUIV/EQUAL on !REG set

2012-05-04 Thread Olivier Hainque
Hello Richard, Re $subject, at http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01515.html You suggested: Would be nice to use a single function that knows about the extra contraints here. Maybe something like the attached? 2012-04-24 ... * rtl.h (set_for_reg_notes): Declare.

Re: strengthen protection against REG_EQUIV/EQUAL on !REG set

2012-05-04 Thread Olivier Hainque
On May 4, 2012, at 16:16 , Richard Sandiford wrote: Sorry, was going to test this earlier, but got distracted by lower-subreg stuff. No problem at all. I just happened to have had an opportunity to test as part of a series of miscellaneous other submissions. I need to fix the subreg

Re: fix mem+32760 ICE on powerpc - provide/use predicates weaker than mode_dependent_address_p

2012-05-04 Thread Olivier Hainque
On May 4, 2012, at 20:42 , David Edelsohn wrote: I cannot approve the common parts of the patch, but the rs6000 parts are okay. That's a good start, Thanks! The new comment in rs6000_mode_dependent_address adapted from the original comment above the hook should mention VSX in addition to

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-05-03 Thread Olivier Hainque
On Apr 30, 2012, at 16:18 , Olivier Hainque wrote: Can you formally relate those three representations and tell me why VIEW_CONVERT_EXPR is useful (not only convenient because of less operands) to use on lvalues (thus memory, compared to registers or constants)? I have ideas on how

improve collect2 to preserve a RO output as the linker does

2012-05-03 Thread Olivier Hainque
. OK ? Thanks in advance for your feedback, With Kind Regards, Olivier 2012-05-03 Olivier Hainque hain...@adacore.com * collect2.c (may_unlink_output_file): New global. (maybe_unlink): Honor it. * collect2.h: Add extern for it. * tlink.c (do_tlink): Set

Re: fix ppc-aix build failures with spaces in CC (internal) variable

2012-05-03 Thread Olivier Hainque
Hello, Ping for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00661.html Thanks in advance, Olivier On Apr 11, 2012, at 16:43 , Olivier Hainque wrote: We sometimes get to invoke Makefile targets with a CC variable value containing spaces (for extra options, typically). This causes failure

ping: latch mem to reg before multi-access in convert_move

2012-05-03 Thread Olivier Hainque
Hello, Ping for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00298.html Thanks in advance, Olivier On Apr 5, 2012, at 17:30 , Olivier Hainque wrote: ... The original problem we had with this was the introduction of an artificial race condition in addition to the potential performance impact

ping: use longcall to abort from !pic trampoline setup on ppc-vxworks

2012-05-03 Thread Olivier Hainque
Hello, Ping for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00808.html Thanks in advance, Olivier On Apr 13, 2012, at 10:08 , Olivier Hainque wrote: ... Relocation troubles (24bit reloc overflows) might show up when module instructions contain short references to kernel symbols

ping: recognize .persistent.bss sections as bss

2012-05-03 Thread Olivier Hainque
Hello, Ping for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00833.html Thanks in advance, Olivier On Apr 13, 2012, at 15:06 , Olivier Hainque wrote: For several years now, Ada has support for a Persistent_BSS pragma that let users place data in a .persistent.bss section. This section

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-05-03 Thread Olivier Hainque
On May 3, 2012, at 12:24 , Richard Guenther wrote: One area of potential difference came to mind yesterday: regarding the processing of type alignment differences. VCE to more aligned (of the same size) would make a temp copy to yield a correctly aligned object. Would MEM_REF do that as

Re: fix ppc-aix build failures with spaces in CC (internal) variable

2012-05-03 Thread Olivier Hainque
On May 3, 2012, at 16:45 , David Edelsohn wrote: * config/mh-ppc-aix (LDFLAGS): Quote $(CC). Okay. Committed, thanks :)

fix spec function evaluations part of an outer string construction

2012-05-03 Thread Olivier Hainque
on x86-linux. OK to commit ? Thanks in advance, Olivier 2012-05-03 Olivier Hainque hain...@adacore.com * gcc.c (eval_spec_function): Finalize/restore the current string obstack state as part of the context push/pop operations. specfn.dif Description: video/dv

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-04-30 Thread Olivier Hainque
Hello Richard, Thanks for the constructive exchange :-) On Apr 26, 2012, at 10:48 , Richard Guenther wrote: In particular, I'm pretty sure that we can get component refs of integral modes that access a smaller range of bits than what the mode conveys. It is common with packing or rep

Use sed -n … instead of sed s/…/p -e d in s-header-vars

2012-04-30 Thread Olivier Hainque
of years now. Bootstrapped and regtested with mainline on x86_64-linux-gnu. OK to commit ? Thanks in advance, With Kind Regards, Olivier 2012-04-30 Olivier Hainque hain...@adacore.com * Makefile.in (s-header-vars): Resort to -n instead of trailing -e d in sed invocation. sed

Re: strengthen protection against REG_EQUIV/EQUAL on !REG set

2012-04-26 Thread Olivier Hainque
Hello Richard, On Apr 25, 2012, at 00:06 , Richard Sandiford wrote: STRICT_LOW_PART is OK too. Ah, right. Would be nice to use a single function that knows about the extra contraints here. Maybe something like the attached? I'm deliberately requiring the SET to the first rtx in the

fix mem+32760 ICE on powerpc - provide/use predicates weaker than mode_dependent_address_p

2012-04-26 Thread Olivier Hainque
and powerpc-linux. We (AdaCore) also have been using a gcc-4.5 minor variation of it without problem for a couple of years on powerpc-aix. OK to commit ? Thanks in advance, With Kind Regards, Olivier -- 2012-04-26 Olivier Hainque hain...@adacore.com * target.def

fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-04-25 Thread Olivier Hainque
using this internally for a while now. I also checked that it fixes the observable problem on sparc, then bootstrapped and regtested on i686-suse-linux. OK to commit ? Thanks in advance for your feedback, Olivier 2012-04-25 Olivier Hainque hain...@adacore.com * tree-sra.c (create_access

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-04-25 Thread Olivier Hainque
Thanks for your feedback Richard, On Apr 25, 2012, at 16:16 , Richard Guenther wrote: I think much better would be to simply disallow any toplevel VIEW_CONVERT_EXPR of BLKmode, Does that fix your problems, too? If so I prefer that. Hmm, I think that this would fix the particular testscase

Re: default to strict dwarf-2 on powerpc-vxworks

2012-04-24 Thread Olivier Hainque
On Apr 24, 2012, at 17:49 , Jakub Jelinek wrote: Talked to Jason about this on IRC last night, he is ok with that, so your patch is ok for trunk. Just committed - Thanks :-)

use longcall to abort from !pic trampoline setup on ppc-vxworks

2012-04-13 Thread Olivier Hainque
in advance, With Kind Regards, Olivier 2012-04-12 Olivier Hainque hain...@adacore.com libgcc/ * config/rs6000/vxworks/tramp.S (trampoline_setup): Use a longcall sequence in the non pic case on VxWorks. vxtramp.dif Description: video/dv

default to strict dwarf-2 on powerpc-vxworks

2012-04-13 Thread Olivier Hainque
dwarf_version = 2 for VxWorks via vxworks_override_options. Sanity checked on mainline for powerpc-wrs-vxworks and bootstrapped on x86_64-pc-linux-gnu. Thanks in advance for your feedback, With Kind Regards, Olivier 2012-04-13 Olivier Hainque hain...@adacore.com * common.opt (gdwarf

recognize .persistent.bss sections as bss

2012-04-13 Thread Olivier Hainque
2012-04-13 Olivier Hainque hain...@adacore.com * varasm.c (default_section_type_flags): Flag .persistent.bss sections as SECTION_BSS. pbss.dif Description: video/dv

strengthen protection against REG_EQUIV/EQUAL on !REG set

2012-04-12 Thread Olivier Hainque
issue resurface again since then. Bootstrapped and regtested on x86_64-suse-linux OK to commit ? Thanks in advance, With Kind Regards, Olivier 2012-04-12 Olivier Hainque hain...@adacore.com * emit-rtl.c (set_unique_reg_note): Don't add REG_EQUAL or REG_EQUIV on a SET

Re: strengthen protection against REG_EQUIV/EQUAL on !REG set

2012-04-12 Thread Olivier Hainque
Clarifying: On Apr 12, 2012, at 11:54 , Olivier Hainque wrote: At the time we had fixed specific locations where this was happening via explicit calls to set_unique_reg_note. We had fixed the problems observable at the time by preventing calls to set_unique_reg_notes when they would lead

Re: [RS6000] Stack tie fix.

2012-04-12 Thread Olivier Hainque
On Apr 12, 2012, at 17:34 , David Edelsohn wrote: This version is okay, but I also want to give Richi and Olivier an opportunity to comment if they still have any concerns. Thanks :) I'm rebuilding our old compiler with the patch and will double check how things go on our original failing

Re: [RS6000] Stack tie fix.

2012-04-12 Thread Olivier Hainque
On Apr 12, 2012, at 18:07 , Olivier Hainque wrote: I'm rebuilding our old compiler with the patch and will double check how things go on our original failing case. All is well :) Thanks Alan!

fix ppc-aix build failures with spaces in CC (internal) variable

2012-04-11 Thread Olivier Hainque
as part of the case controlling value, triggering shell syntax errors. This patch fixes this by adding quotes around. OK to commit ? Bootstrapped and regtested on powerpc-aix-5.2. Thanks in adavnce, Olivier 2012-04-11 Olivier Hainque hain...@adacore.com * config/mh-ppc-aix (LDFLAGS

Re: [RS6000] Stack tie fix.

2012-04-06 Thread Olivier Hainque
Hello Alan, On Apr 6, 2012, at 02:32 , Alan Modra wrote: [...] In the epilogue, the previous frame read must be prevented from moving after the stack adjust. If the adjacent write/read uses r1 as a base reg, then we don't need a stack tie at all. Right Writes/reads further away won't be

Re: [RS6000] Stack tie fix.

2012-04-05 Thread Olivier Hainque
Hello Alan, On Apr 4, 2012, at 03:22 , Alan Modra wrote: I'll see whether my approach fixes pr30282 for gcc-4.4 which has known deficiencies in alias analysis. Olivier, would you be kind enough to backport and test against other versions of gcc that needed your bigger hammer? Sure. I can

fix install-no-fixedincludes mishaps

2012-04-05 Thread Olivier Hainque
identical otherwise. Bootstrapped and regtested on x86_64-pc-linux-gnu with languages=all,ada. OK to commit ? Thanks in advance for your feedback, Olivier 2012-04-05 Olivier Hainque hain...@adacore.com * Makefile.tpl (gcc-no-fixedincludes): Rename into ... (gcc-install

Re: fix install-no-fixedincludes mishaps

2012-04-05 Thread Olivier Hainque
On Apr 5, 2012, at 15:07 , Richard Guenther wrote: Nice. Thanks :) I suppose this would enable a --disable-fixinclude? fixinclude can take quite some time when a lot of headers are installed and if we are not going to install them, why produce them ... That was another suggestion in the

latch mem to reg before multi-access in convert_move

2012-04-05 Thread Olivier Hainque
-linux. OK to commit ? Thanks in advance, Olivier 2012-04056 Olivier Hainque hain...@adacore.com * expr.c (convert_move): Latch mem integer inputs into a register before expanding a multi-instructions sequence. memlatch.dif Description: video/dv

Re: [RS6000] Stack tie fix.

2012-04-05 Thread Olivier Hainque
On Apr 5, 2012, at 16:03 , Alan Modra wrote: Well it turns out that gcc-4.4 still gets this testcase from pr30282 wrong. Hmph :-( There are lots of places in the emit_epilogue code that assign frame_reg_rtx with different possible values, (hard_fp, sp, r11) r12 too Right ... It is

<    1   2   3   4   5   6   7   >