[PATCH][RFC] -EB / -EL don't properly affect gcc predefined symbols

2006-10-12 Thread Hiroki Kaminaga
Hi, Regarding the PR: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29413 Is below patch adequate to fix the problem? Works fine with me, but haven't done any regression test. Thanks in Advance (Hiroki Kaminaga) t -- Index: gcc/gcc/config/mips/mips.h ===

Re: [PATCH][RFC] -EB / -EL don't properly affect gcc predefined symbols

2006-10-12 Thread Andrew Pinski
On Thu, 2006-10-12 at 17:06 +0900, Hiroki Kaminaga wrote: > Hi, > > Regarding the PR: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29413 > > Is below patch adequate to fix the problem? > Works fine with me, but haven't done any regression test. As I mentioned in the bug report, the problem is t

Re: [PATCH][RFC] -EB / -EL don't properly affect gcc predefined symbols

2006-10-12 Thread Hiroki Kaminaga
From: Andrew Pinski <[EMAIL PROTECTED]> > As I mentioned in the bug report, the problem is that CC1_SPEC > is the wrong one. (snip) > The attached patch is the more correct way to solve this. Thanks alot! (Hiroki Kaminaga) t --

Re: [PATCH][RFC] -EB / -EL don't properly affect gcc predefined symbols

2006-10-12 Thread Hiroki Kaminaga
From: Andrew Pinski <[EMAIL PROTECTED]> > On Thu, 2006-10-12 at 17:06 +0900, Hiroki Kaminaga wrote: > > Hi, > > > > Regarding the PR: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29413 > > > > Is below patch adequate to fix the problem? > > Works fine with me, but haven't done any regression t

Re: [PATCH][RFC] -EB / -EL don't properly affect gcc predefined symbols

2006-10-12 Thread Andrew Pinski
On Fri, 2006-10-13 at 14:32 +0900, Hiroki Kaminaga wrote: > > The attached patch is the more correct way to solve this. > > Your patch would cause `-profile' option not to set `-p' to cc1. Is this OK? Not really, the following patch on top of the previous fixes the above problem: Index: config/mip

Re: [PATCH][RFC] -EB / -EL don't properly affect gcc predefined symbols

2006-10-12 Thread Hiroki Kaminaga
From: Andrew Pinski <[EMAIL PROTECTED]> > > Your patch would cause `-profile' option not to set `-p' to cc1. Is this OK? > Not really, the following patch on top of the previous fixes the above > problem: > Index: config/mips/linux.h > ===

Re: [PATCH][RFC] -EB / -EL don't properly affect gcc predefined symbols

2006-10-12 Thread Andrew Pinski
On Fri, 2006-10-13 at 14:45 +0900, Hiroki Kaminaga wrote: > How about appending to CC1_SPEC? > > -#ifndef CC1_SPEC > +#undef CC1_SPEC > #define CC1_SPEC "\ > %{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1} \ > %{G*} %{EB:-meb} %{EL:-mel} %{EB:%{EL:%emay not use both -EB and -EL}} \ > %{save-temps: }