Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread J.C. Pizarro
On 2007/12/06, David Kastrup <[EMAIL PROTECTED]> wrote: > Johannes Schindelin <[EMAIL PROTECTED]> writes: > > > However, I think that --aggressive should be aggressive, and if you > > decide to run it on a machine which lacks the muscle to be aggressive, > > well, you should have known better. > >

Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread David Kastrup
Johannes Schindelin <[EMAIL PROTECTED]> writes: > However, I think that --aggressive should be aggressive, and if you > decide to run it on a machine which lacks the muscle to be aggressive, > well, you should have known better. That's a rather cheap shot. "you should have known better" than exp

Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread Linus Torvalds
On Thu, 6 Dec 2007, Harvey Harrison wrote: > > 7:41:25elapsed 86%CPU Heh. And this is why you want to do it exactly *once*, and then just export the end result for others ;) > -r--r--r-- 1 hharrison hharrison 324094684 2007-12-06 07:26 > pack-1d46ca030c3d6d6b95ad316deb922be06b167a3d.pack Bu

Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread Johannes Schindelin
Hi, On Thu, 6 Dec 2007, Harvey Harrison wrote: > -r--r--r-- 1 hharrison hharrison 324094684 2007-12-06 07:26 > pack-1d46ca030c3d6d6b95ad316deb922be06b167a3d.pack Wow. Ciao, Dscho

Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread Johannes Schindelin
Hi, On Thu, 6 Dec 2007, Pierre Habouzit wrote: > On Thu, Dec 06, 2007 at 12:03:38PM +, Johannes Schindelin wrote: > > > > The default was not to change the window or depth at all. As > > suggested by Jon Smirl, Linus Torvalds and others, default to > > > > --window=250 --depth=250 >

Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread Harvey Harrison
Wow /usr/bin/time git repack -a -d -f --window=250 --depth=250 23266.37user 581.04system 7:41:25elapsed 86%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (419835major+123275804minor)pagefaults 0swaps -r--r--r-- 1 hharrison hharrison 29091872 2007-12-06 07:26 pack-1d46ca030c3d6d6b95ad31

Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread Pierre Habouzit
On Thu, Dec 06, 2007 at 12:03:38PM +, Johannes Schindelin wrote: > > The default was not to change the window or depth at all. As suggested > by Jon Smirl, Linus Torvalds and others, default to > > --window=250 --depth=250 well, this will explode on many quite reasonnably sized syst

Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread Nicolas Pitre
On Thu, 6 Dec 2007, Theodore Tso wrote: > Linus later pointed out that what we *really* should do is at some > point was to change repack -f to potentially retry to find a better > delta, but to reuse the existing delta if it was no worse. That > automatically does the right thing in the case whe

Re: [PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread Theodore Tso
On Thu, Dec 06, 2007 at 12:03:38PM +, Johannes Schindelin wrote: > > The default was not to change the window or depth at all. As suggested > by Jon Smirl, Linus Torvalds and others, default to > > --window=250 --depth=250 I'd also suggest adding a comment in the man pages that this s

[PATCH] gc --aggressive: make it really aggressive

2007-12-06 Thread Johannes Schindelin
The default was not to change the window or depth at all. As suggested by Jon Smirl, Linus Torvalds and others, default to --window=250 --depth=250 Signed-off-by: Johannes Schindelin <[EMAIL PROTECTED]> --- On Wed, 5 Dec 2007, Linus Torvalds wrote: > On Thu, 6 Dec 2007