Re: [RFC] Removal of loop notes

2006-03-09 Thread Joe Buck
On 3/9/06, Joe Buck <[EMAIL PROTECTED]> wrote: > > Profile information isn't always available. On Thu, Mar 09, 2006 at 06:26:27PM +0100, Steven Bosscher wrote: > But branch predictions are, and those are still far more reliable than loop > notes. The predictions use natural loop discovery and the

Re: [RFC] Removal of loop notes

2006-03-09 Thread Joe Buck
> > I see that flow no longer uses loop_depth when computing REG_N_REFS, > > > > That strikes me as wrong. Don't we want to give pseudos that are in loops > > preference over those that aren't? > On Thu, Mar 09, 2006 at 09:12:35AM +0100, Zdenek Dvorak wrote: > we have much more reliable he

Re: [RFC] Removal of loop notes

2006-03-09 Thread Zdenek Dvorak
Hello, > I see that flow no longer uses loop_depth when computing REG_N_REFS, > > That strikes me as wrong. Don't we want to give pseudos that are in loops > preference over those that aren't? we have much more reliable heuristic based on profile information for some time now. Zdenek

Re: [RFC] Removal of loop notes

2006-03-08 Thread Richard Kenner
I see that flow no longer uses loop_depth when computing REG_N_REFS, That strikes me as wrong. Don't we want to give pseudos that are in loops preference over those that aren't?

Re: [RFC] Removal of loop notes

2006-03-08 Thread Jim Wilson
Bernd Schmidt wrote: Do we have a replacement for this heuristic? I see REG_FREQ, which is computed from some basic block frequency info. -- Jim Wilson, GNU Tools Support, http://www.specifix.com

Re: [RFC] Removal of loop notes

2006-03-08 Thread Bernd Schmidt
Jim Wilson wrote: I see that flow no longer uses loop_depth when computing REG_N_REFS, so the original reason for the sched support seems to be gone. Do we have a replacement for this heuristic? Bernd

Re: [RFC] Removal of loop notes

2006-03-08 Thread Jim Wilson
Zdenek Dvorak wrote: *sched* -- no idea what happens there; it seems to make REG_SAVE_NOTE notes from loop notes, and then makes some magic, but I do not understand what and why. The loop notes are converted into REG_NOTES, and attached to an adjacent instruction. The REG_SAVE_NOTES are t

Re: [RFC] Removal of loop notes

2006-03-03 Thread Paolo Bonzini
Zdenek Dvorak wrote: Hello, here is a proposal for the patch to remove loop notes (I still need to benchmark it, and probably split into smaller parts). However, I do not understand some of the code from that it removes loop note usage, so I would appreciate comments on them: cse.c:cse_end_of_

[RFC] Removal of loop notes

2006-03-03 Thread Zdenek Dvorak
Hello, here is a proposal for the patch to remove loop notes (I still need to benchmark it, and probably split into smaller parts). However, I do not understand some of the code from that it removes loop note usage, so I would appreciate comments on them: cse.c:cse_end_of_basic_block -- somethin