Re: GCC_FOR_TARGET settings being overridden by toplevel Makefile

2011-03-04 Thread Diego Novillo
On Thu, Mar 3, 2011 at 23:38, Paolo Bonzini bonz...@gnu.org wrote: On 03/03/2011 05:26 PM, Diego Novillo wrote: On Thu, Mar 3, 2011 at 00:27, Paolo Bonzinibonz...@gnu.org  wrote: On 03/02/2011 10:00 PM, Ian Lance Taylor wrote: That does not sound like the right approach to me.  Why not add

Re: GCC_FOR_TARGET settings being overridden by toplevel Makefile

2011-03-04 Thread Paolo Bonzini
On 03/04/2011 04:03 PM, Diego Novillo wrote: Sure, but my question was whether I should prepare a patch to fix the current lack of consistency between the two definitions. Certainly. I'm not sure it would be acceptable for 4.6, but it is worth posting it. Paolo

Re: GCC_FOR_TARGET settings being overridden by toplevel Makefile

2011-03-04 Thread Diego Novillo
On Fri, Mar 4, 2011 at 07:07, Paolo Bonzini bonz...@gnu.org wrote: On 03/04/2011 04:03 PM, Diego Novillo wrote: Sure, but my question was whether I should prepare a patch to fix the current lack of consistency between the two definitions. Certainly.  I'm not sure it would be acceptable for

Re: GCC_FOR_TARGET settings being overridden by toplevel Makefile

2011-03-03 Thread Paolo Bonzini
On 03/02/2011 10:00 PM, Ian Lance Taylor wrote: That does not sound like the right approach to me. Why not add the new flags to GCC_FOR_TARGET at top-level? It seems to me that GCC_FOR_TARGET should mean the same thing at all levels. I agree. Why is it incorrect to use those flags when,

Re: GCC_FOR_TARGET settings being overridden by toplevel Makefile

2011-03-03 Thread Diego Novillo
On Thu, Mar 3, 2011 at 00:27, Paolo Bonzini bonz...@gnu.org wrote: On 03/02/2011 10:00 PM, Ian Lance Taylor wrote: That does not sound like the right approach to me.  Why not add the new flags to GCC_FOR_TARGET at top-level?  It seems to me that GCC_FOR_TARGET should mean the same thing at

Re: GCC_FOR_TARGET settings being overridden by toplevel Makefile

2011-03-03 Thread Paolo Bonzini
On 03/03/2011 05:26 PM, Diego Novillo wrote: On Thu, Mar 3, 2011 at 00:27, Paolo Bonzinibonz...@gnu.org wrote: On 03/02/2011 10:00 PM, Ian Lance Taylor wrote: That does not sound like the right approach to me. Why not add the new flags to GCC_FOR_TARGET at top-level? It seems to me that

GCC_FOR_TARGET settings being overridden by toplevel Makefile

2011-03-02 Thread Diego Novillo
We are trying to add some flags to GCC_FOR_TARGET so that when check-gcc runs, it includes a few extra sysroot and -isystem options. To do this, we've modified the definition in gcc/Makefile.in to add these extra options: -GCC_FOR_TARGET = $(STAGE_CC_WRAPPER) ./xgcc -B./ -B$(build_tooldir)/bin/

Re: GCC_FOR_TARGET settings being overridden by toplevel Makefile

2011-03-02 Thread Ian Lance Taylor
Diego Novillo dnovi...@google.com writes: We are trying to add some flags to GCC_FOR_TARGET so that when check-gcc runs, it includes a few extra sysroot and -isystem options. To do this, we've modified the definition in gcc/Makefile.in to add these extra options: -GCC_FOR_TARGET =