Re: PATCH: Compile options.c with -fcommon

2006-05-16 Thread Andrew Pinski
> > Ping? I think this fixes a current bootstrap problem. Looks safe > and reasonable to me. It was already APPROVED in the bug report about the orginal issue. Mike, next time please look at what is going on before replying. -- Pinski

Re: PATCH: Compile options.c with -fcommon

2006-05-16 Thread Mark Mitchell
H. J. Lu wrote: > 2006-05-16 H.J. Lu <[EMAIL PROTECTED]> > > * Makefile.in (GCC_OBJS): Replace options.o with gcc-options.o. > (gcc-options.o): New rule. > > * optc-gen.awk: Protect variables for gcc-options.o with > #ifdef GCC_DRIVER/#endif. OK. -- Mark Mitchell Cod

Re: PATCH: Compile options.c with -fcommon

2006-05-16 Thread Mike Stump
Ping? I think this fixes a current bootstrap problem. Looks safe and reasonable to me. On May 16, 2006, at 1:09 PM, H. J. Lu wrote: Here is a patch to compile gcc-options.o from options.c. 2006-05-16 H.J. Lu <[EMAIL PROTECTED]> * Makefile.in (GCC_OBJS): Replace options.o with g

Re: PATCH: Compile options.c with -fcommon

2006-05-16 Thread H. J. Lu
On Tue, May 16, 2006 at 02:08:13PM -0400, Andrew Pinski wrote: > > > > > > > > On Tue, May 16, 2006 at 10:41:22AM -0700, Andrew Pinski wrote: > > > > > > > > On May 16, 2006, at 10:39 AM, H. J. Lu wrote: > > > > > > > > > > > > > >I assume that -fno-common is added by hand since I didn't see it

Re: PATCH: Compile options.c with -fcommon

2006-05-16 Thread Andrew Pinski
> > > > > On Tue, May 16, 2006 at 10:41:22AM -0700, Andrew Pinski wrote: > > > > > > On May 16, 2006, at 10:39 AM, H. J. Lu wrote: > > > > > > > > > > >I assume that -fno-common is added by hand since I didn't see it > > > >in my build logs on Linux/x86, Linux/x86-64 and Linux/ia64. > > > > >

Re: PATCH: Compile options.c with -fcommon

2006-05-16 Thread Andrew Pinski
> > On Tue, May 16, 2006 at 10:41:22AM -0700, Andrew Pinski wrote: > > > > On May 16, 2006, at 10:39 AM, H. J. Lu wrote: > > > > > > > >I assume that -fno-common is added by hand since I didn't see it > > >in my build logs on Linux/x86, Linux/x86-64 and Linux/ia64. > > > > No it is not added by

PATCH: Compile options.c with -fcommon

2006-05-16 Thread H. J. Lu
On Tue, May 16, 2006 at 10:41:22AM -0700, Andrew Pinski wrote: > > On May 16, 2006, at 10:39 AM, H. J. Lu wrote: > > > > >I assume that -fno-common is added by hand since I didn't see it > >in my build logs on Linux/x86, Linux/x86-64 and Linux/ia64. > > No it is not added by hand. It is used wh