Re: Please, do not use the merged revisions log as the commit message when merging

2008-09-06 Thread Daniel Berlin
Feel free to edit the hook scripts to do this. On Sat, Sep 6, 2008 at 1:26 PM, Joseph S. Myers <[EMAIL PROTECTED]> wrote: > On Sat, 6 Sep 2008, Manuel López-Ibáñez wrote: > >> Well, that is a property change and it is surprising that the log >> shows the diff of the change. Normally logs only sho

Re: Please, do not use the merged revisions log as the commit message when merging

2008-09-06 Thread Joseph S. Myers
On Sat, 6 Sep 2008, Manuel López-Ibáñez wrote: > Well, that is a property change and it is surprising that the log > shows the diff of the change. Normally logs only show what has been > changed but not the diff. Neither John, nor I expected this behaviour. Changes to *revision* properties delibe

Re: Please, do not use the merged revisions log as the commit message when merging

2008-09-06 Thread Manuel López-Ibáñez
2008/9/6 Christopher Faylor <[EMAIL PROTECTED]>: > >--- svn:log (original) >+++ svn:log Fri Sep 5 14:39:56 2008 >@@ -1,19740 +1,1 @@ >-Merged revisions > 136194,136196,136200,136209,136215-136217,136221-136222,1= > > 36229,136235-136239,136242,136247,136249,136251-136254,13626

Re: Please, do not use the merged revisions log as the commit message when merging

2008-09-05 Thread Christopher Faylor
On Fri, Sep 05, 2008 at 01:34:08PM -0500, John Freeman wrote: > Christopher Faylor wrote: >> On Sun, Aug 17, 2008 at 03:01:03PM -0500, John Freeman wrote: >> >>> Daniel Berlin wrote: >>> >>> It's listed on the wiki that explains how to maintain branches :) >>> I had no id

Re: Please, do not use the merged revisions log as the commit message when merging

2008-09-05 Thread Daniel Berlin
I'll commit your patch. On Fri, Sep 5, 2008 at 12:42 PM, Manuel López-Ibáñez <[EMAIL PROTECTED]> wrote: > 2008/9/5 Christopher Faylor <[EMAIL PROTECTED]>: >> On Sun, Aug 17, 2008 at 03:01:03PM -0500, John Freeman wrote: >>> Daniel Berlin wrote: >>> It's listed on the wiki that explains how to

Re: Please, do not use the merged revisions log as the commit message when merging

2008-09-05 Thread John Freeman
Christopher Faylor wrote: On Sun, Aug 17, 2008 at 03:01:03PM -0500, John Freeman wrote: Daniel Berlin wrote: It's listed on the wiki that explains how to maintain branches :) I had no idea such a wiki even existed. It would really help future contributors, I'm sure, if, per

Re: Please, do not use the merged revisions log as the commit message when merging

2008-09-05 Thread Manuel López-Ibáñez
2008/9/5 Christopher Faylor <[EMAIL PROTECTED]>: > On Sun, Aug 17, 2008 at 03:01:03PM -0500, John Freeman wrote: >> Daniel Berlin wrote: >> >>> It's listed on the wiki that explains how to maintain branches :) >>> >> I had no idea such a wiki even existed. It would really help future >> contributo

Re: Please, do not use the merged revisions log as the commit message when merging

2008-09-05 Thread Christopher Faylor
On Sun, Aug 17, 2008 at 03:01:03PM -0500, John Freeman wrote: > Daniel Berlin wrote: > >> It's listed on the wiki that explains how to maintain branches :) >> > I had no idea such a wiki even existed. It would really help future > contributors, I'm sure, if, perhaps during copyright assignment

Re: Please, do not use the merged revisions log as the commit message when merging

2008-08-23 Thread Gerald Pfeifer
On Sun, 17 Aug 2008, Ralf Wildenhues wrote: > It should be on svnwrite.html Something like the following? (Not committed yet.) Gerald Index: svnwrite.html === RCS file: /cvs/gcc/wwwdocs/htdocs/svnwrite.html,v retrieving revision 1.

Re: Please, do not use the merged revisions log as the commit message when merging

2008-08-17 Thread Gerald Pfeifer
On Sun, 17 Aug 2008, John Freeman wrote: > No one informed me of any commit policies when I was given subversion > access. I thought that since I was working on a branch, I had free > reign. Education would go a long way in preventing future errors. You are right. This is one of the weaknesse

Re: Please, do not use the merged revisions log as the commit message when merging

2008-08-17 Thread Ralf Wildenhues
* Daniel Berlin wrote on Sun, Aug 17, 2008 at 09:18:01PM CEST: > It's listed on the wiki that explains how to maintain branches :) It should be on svnwrite.html, or at least a pointer to the wiki page should be. Cheers, Ralf

Re: Please, do not use the merged revisions log as the commit message when merging

2008-08-17 Thread John Freeman
Daniel Berlin wrote: It's listed on the wiki that explains how to maintain branches :) I had no idea such a wiki even existed. It would really help future contributors, I'm sure, if, perhaps during copyright assignment, there were some sort of "introduction" process that clearly communicat

Re: Please, do not use the merged revisions log as the commit message when merging

2008-08-17 Thread Daniel Berlin
It's listed on the wiki that explains how to maintain branches :) On Sun, Aug 17, 2008 at 2:32 PM, John Freeman <[EMAIL PROTECTED]> wrote: > Christopher Faylor wrote: >> >> On Sat, Aug 16, 2008 at 02:35:08PM +0200, Manuel L?pez-Ib??ez wrote: >> >>> >>> Dear GCC devs, >>> >>> Please do *not* use t

Re: Please, do not use the merged revisions log as the commit message when merging

2008-08-17 Thread John Freeman
Christopher Faylor wrote: On Sat, Aug 16, 2008 at 02:35:08PM +0200, Manuel L?pez-Ib??ez wrote: Dear GCC devs, Please do *not* use the full logs of the merged revisions as the commit message of a merge. Apart from making the output of svn log useless, commits messages are parsed are tracked f

Re: Please, do not use the merged revisions log as the commit message when merging

2008-08-16 Thread Manuel López-Ibáñez
2008/8/16 Christopher Faylor <[EMAIL PROTECTED]>: > On Sat, Aug 16, 2008 at 02:35:08PM +0200, Manuel L?pez-Ib??ez wrote: >>Dear GCC devs, >> >>Please do *not* use the full logs of the merged revisions as the >>commit message of a merge. Apart from making the output of svn log >>useless, commits mes

Re: Please, do not use the merged revisions log as the commit message when merging

2008-08-16 Thread Christopher Faylor
On Sat, Aug 16, 2008 at 02:35:08PM +0200, Manuel L?pez-Ib??ez wrote: >Dear GCC devs, > >Please do *not* use the full logs of the merged revisions as the >commit message of a merge. Apart from making the output of svn log >useless, commits messages are parsed are tracked for PR numbers, the >commit

Please, do not use the merged revisions log as the commit message when merging

2008-08-16 Thread Manuel López-Ibáñez
Dear GCC devs, Please do *not* use the full logs of the merged revisions as the commit message of a merge. Apart from making the output of svn log useless, commits messages are parsed are tracked for PR numbers, the commit message is added to the bugzilla page of the PR and people subscribed to th