Re: Should -msse3 enable fisttp

2005-10-05 Thread Paolo Bonzini
Richard Henderson wrote: On Tue, Oct 04, 2005 at 10:07:31AM -0700, Dale Johannesen wrote: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23809 The patch in the PR looks reasonable. I committed it after fixing some grammar problems. Tested with `make info'. Paolo 2005-10-05 Billy Biggs <[EM

Re: Should -msse3 enable fisttp

2005-10-04 Thread Richard Henderson
On Tue, Oct 04, 2005 at 10:07:31AM -0700, Dale Johannesen wrote: > >http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23809 The patch in the PR looks reasonable. r~

Re: Should -msse3 enable fisttp

2005-10-04 Thread Dale Johannesen
On Oct 3, 2005, at 3:49 PM, Andrew Pinski wrote: On Oct 3, 2005, at 6:41 PM, Evan Cheng wrote: But according to the manual -msse3 does not turn on generation of SSE3 instructions: The manual is semi-confusing I had forgot about that. There is a bug about the issue recorded as PR 23809: http://

Re: Should -msse3 enable fisttp?

2005-10-04 Thread Richard Henderson
On Tue, Oct 04, 2005 at 10:07:07AM +0200, Uros Bizjak wrote: > * config/i386/i386.h (TARGET_FISTTP): Enable also for > TARGET_SSE3 and only for TARGET_80387. > * config/i386/i386.md (fix_trunc_fisttp_i387_1, > (fix_trunc_i387_fisttp, fix_trunc_i387_fisttp_with_temp): >

Re: Should -msse3 enable fisttp?

2005-10-04 Thread Paolo Bonzini
This one also works for -mno-80387 and simplifies insn pattern constraints a bit: 2005-10-05 Uros Bizjak <[EMAIL PROTECTED]> * config/i386/i386.h (TARGET_FISTTP): Enable also for TARGET_SSE3 and only for TARGET_80387. * config/i386/i386.md (fix_trunc_fisttp_i387_1,

Re: Should -msse3 enable fisttp?

2005-10-04 Thread Uros Bizjak
Quoting Uros Bizjak <[EMAIL PROTECTED]>: > Following simple patch should implement your suggested approach: > > -march=prescott enables fisttp > -msse3enables fisttp > -march=prescott -mno-sse3 enables fisttp > > Otherwise fisttp is disabled. This one also works

Re: Should -msse3 enable fisttp?

2005-10-04 Thread Uros Bizjak
Quoting Evan Cheng <[EMAIL PROTECTED]>: > Let me know what you think. I kind of agree with your argument. But > for practical reasons I thinkg -msse3 should enable fisttp. Certainly > here in Apple, a few folks have been surprised by this. Following simple patch should implement your sugges

Re: Should -msse3 enable fisttp

2005-10-03 Thread Andrew Pinski
On Oct 3, 2005, at 6:41 PM, Evan Cheng wrote: But according to the manual -msse3 does not turn on generation of SSE3 instructions: The manual is semi-confusing I had forgot about that. There is a bug about the issue recorded as PR 23809: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23809 Tha

Re: Should -msse3 enable fisttp

2005-10-03 Thread Eric Christopher
Actually it enables more than the builtins. It enables the use sse3 instructions. This is just like -maltivec on PowerPC and -msse and -msse on x86, etc. Right, so the manual disagrees and should probably be fixed. And then RTH agreed: http://gcc.gnu.org/ml/gcc-patches/2005-03/msg01432.h

Re: Should -msse3 enable fisttp

2005-10-03 Thread Evan Cheng
Well, both Intel and AMD calls fisttp a SSE3 instruction even though it operates on the x87 stack ST(0). My argument is users who specify - msse3 to turn on SSE3 instructions would expect fisttp be turned on as well. But according to the manual -msse3 does not turn on generation of SSE3 in

Re: Should -msse3 enable fisttp

2005-10-03 Thread Andrew Pinski
On Oct 3, 2005, at 5:56 PM, Evan Cheng wrote: My mistake. I misunderstood the meaning of -msse3 (it only enables the sse3 builtins). Please ignore. Actually it enables more than the builtins. It enables the use sse3 instructions. This is just like -maltivec on PowerPC and -msse and -msse

Re: Should -msse3 enable fisttp

2005-10-03 Thread Evan Cheng
My mistake. I misunderstood the meaning of -msse3 (it only enables the sse3 builtins). Please ignore. On Sep 29, 2005, at 1:48 PM, Evan Cheng wrote: Hi, I know this has been discussed in bug 18668. But I'd like to bring it up again. Currently, fisttp is only generated with -march=prescot

Re: Should -msse3 enable fisttp?

2005-10-03 Thread Evan Cheng
Hi Uros, Since you are the one who enabled fisttp, I figure I should send this email to you directly. Let me know what you think. I kind of agree with your argument. But for practical reasons I thinkg -msse3 should enable fisttp. Certainly here in Apple, a few folks have been surprised by

Should -msse3 enable fisttp

2005-09-29 Thread Evan Cheng
Hi, I know this has been discussed in bug 18668. But I'd like to bring it up again. Currently, fisttp is only generated with -march=prescott. The argument is fisttp is not a SSE instruction. While this is technically true, it's likely to surprise the users. Intel, after all, does lump f