Re: VTA guality assessment: better than -O0 ;-)

2009-06-17 Thread Jakub Jelinek
On Sun, Jun 14, 2009 at 11:17:32AM -0400, Daniel Jacobowitz wrote: On Sat, Jun 13, 2009 at 10:08:39PM +0200, Jakub Jelinek wrote: I really think we need to do (limited) -fvar-tracking even for -O0, it is really bad that most arguments have wrong locations through the prologue, while at -O1

Re: VTA guality assessment: better than -O0 ;-)

2009-06-14 Thread Daniel Jacobowitz
On Sat, Jun 13, 2009 at 10:08:39PM +0200, Jakub Jelinek wrote: I really think we need to do (limited) -fvar-tracking even for -O0, it is really bad that most arguments have wrong locations through the prologue, while at -O1 or above they often have correct location. We should just do the

VTA guality assessment: better than -O0 ;-)

2009-06-13 Thread Alexandre Oliva
So, after I tested and installed this patch http://gcc.gnu.org/ml/gcc-patches/2009-06/msg00903.html I started looking closely at the guality (debug info quality) test results. So far, I have only added two very simple tests to the guality testsuite, but they already show very promising results.

Re: VTA guality assessment: better than -O0 ;-)

2009-06-13 Thread Richard Guenther
On Sat, Jun 13, 2009 at 9:29 AM, Alexandre Olivaaol...@redhat.com wrote: So, after I tested and installed this patch http://gcc.gnu.org/ml/gcc-patches/2009-06/msg00903.html I started looking closely at the guality (debug info quality) test results. So far, I have only added two very simple

Re: VTA guality assessment: better than -O0 ;-)

2009-06-13 Thread Eric Botcazou
Yes, I don't like -O0 producing worse debug info - what does the -O0 -fvar-tracking-assignments results look like? I'd do the opposite: totally disable VTA at -O0 like we do for -fvar-tracking. We once tried to enable -fvar-tracking with -O0 at AdaCore and ended up with bloated and inferior

Re: VTA guality assessment: better than -O0 ;-)

2009-06-13 Thread Richard Guenther
On Sat, Jun 13, 2009 at 8:00 PM, Eric Botcazouebotca...@adacore.com wrote: Yes, I don't like -O0 producing worse debug info - what does the -O0 -fvar-tracking-assignments results look like? I'd do the opposite: totally disable VTA at -O0 like we do for -fvar-tracking. We once tried to enable

Re: VTA guality assessment: better than -O0 ;-)

2009-06-13 Thread Eric Botcazou
Well, I see FAILs for -O0 compared to -O1 with VTA - that doesn't look right. How we fix this is not relevant - but we should try to do so. It would be better not to artificially introduce them in the first place. -- Eric Botcazou

Re: VTA guality assessment: better than -O0 ;-)

2009-06-13 Thread Alexandre Oliva
On Jun 13, 2009, Richard Guenther richard.guent...@gmail.com wrote: Yes, I don't like -O0 producing worse debug info - what does the -O0 -fvar-tracking-assignments results look like? No difference, -fvar-tracking is disabled at -O0, so either -fvar-tracking-assignments gets disabled as well

Re: VTA guality assessment: better than -O0 ;-)

2009-06-13 Thread Jakub Jelinek
On Sat, Jun 13, 2009 at 08:00:35PM +0200, Eric Botcazou wrote: Yes, I don't like -O0 producing worse debug info - what does the -O0 -fvar-tracking-assignments results look like? I'd do the opposite: totally disable VTA at -O0 like we do for -fvar-tracking. We once tried to enable